| Message ID | 1487268932-6469-3-git-send-email-bgolaszewski@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 16 February 2017 11:45 PM, Bartosz Golaszewski wrote: > Add a new pinctrl sub-node for vpif display pins. Move VP_CLKIN3 and > VP_CLKIN2 to the display node where they actually belong (vide section > 35.2.2 of the da850 datasheet). You mean 36.2.2. Also, its in the technical reference manual (TRM). The datahseet is another document. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/boot/dts/da850-evm.dts | 2 +- > arch/arm/boot/dts/da850.dtsi | 17 +++++++++++++++-- Can you separate out the board and SoC specific changes? The board changes could be done in patch 3/4 where other video output parts are added. Thanks, Sekhar
2017-02-20 11:29 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: > On Thursday 16 February 2017 11:45 PM, Bartosz Golaszewski wrote: >> Add a new pinctrl sub-node for vpif display pins. Move VP_CLKIN3 and >> VP_CLKIN2 to the display node where they actually belong (vide section >> 35.2.2 of the da850 datasheet). > > You mean 36.2.2. Also, its in the technical reference manual (TRM). The > datahseet is another document. > I'm looking at the revision from September 2016 and it's 35.2.2: VPIF -> Architecture -> signal descriptions. Thanks, Bartosz
On Monday 20 February 2017 09:12 PM, Bartosz Golaszewski wrote: > 2017-02-20 11:29 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: >> On Thursday 16 February 2017 11:45 PM, Bartosz Golaszewski wrote: >>> Add a new pinctrl sub-node for vpif display pins. Move VP_CLKIN3 and >>> VP_CLKIN2 to the display node where they actually belong (vide section >>> 35.2.2 of the da850 datasheet). >> >> You mean 36.2.2. Also, its in the technical reference manual (TRM). The >> datahseet is another document. >> > > I'm looking at the revision from September 2016 and it's 35.2.2: VPIF > -> Architecture -> signal descriptions. Is this the document ? http://www.ti.com/lit/ug/spruh77c/spruh77c.pdf In this VPIF is chapter 36. Thanks, Sekhar
2017-02-21 5:49 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: > On Monday 20 February 2017 09:12 PM, Bartosz Golaszewski wrote: >> 2017-02-20 11:29 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: >>> On Thursday 16 February 2017 11:45 PM, Bartosz Golaszewski wrote: >>>> Add a new pinctrl sub-node for vpif display pins. Move VP_CLKIN3 and >>>> VP_CLKIN2 to the display node where they actually belong (vide section >>>> 35.2.2 of the da850 datasheet). >>> >>> You mean 36.2.2. Also, its in the technical reference manual (TRM). The >>> datahseet is another document. >>> >> >> I'm looking at the revision from September 2016 and it's 35.2.2: VPIF >> -> Architecture -> signal descriptions. > > Is this the document ? > > http://www.ti.com/lit/ug/spruh77c/spruh77c.pdf > > In this VPIF is chapter 36. > > Thanks, > Sekhar > -ETOOMANYPDFS I was looking at spruh82c.pdf. You're right of course. Thanks, Bartosz
On Tuesday 21 February 2017 02:53 PM, Bartosz Golaszewski wrote: > 2017-02-21 5:49 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: >> On Monday 20 February 2017 09:12 PM, Bartosz Golaszewski wrote: >>> 2017-02-20 11:29 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: >>>> On Thursday 16 February 2017 11:45 PM, Bartosz Golaszewski wrote: >>>>> Add a new pinctrl sub-node for vpif display pins. Move VP_CLKIN3 and >>>>> VP_CLKIN2 to the display node where they actually belong (vide section >>>>> 35.2.2 of the da850 datasheet). >>>> >>>> You mean 36.2.2. Also, its in the technical reference manual (TRM). The >>>> datahseet is another document. >>>> >>> >>> I'm looking at the revision from September 2016 and it's 35.2.2: VPIF >>> -> Architecture -> signal descriptions. >> >> Is this the document ? >> >> http://www.ti.com/lit/ug/spruh77c/spruh77c.pdf >> >> In this VPIF is chapter 36. >> >> Thanks, >> Sekhar >> > > -ETOOMANYPDFS I was looking at spruh82c.pdf. > > You're right of course. I see. I guess its better to call it OMAP-L138 technical reference manual (instead of da850) and also provide a link. Thanks, Sekhar
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts index dece981..14f6f8ea 100644 --- a/arch/arm/boot/dts/da850-evm.dts +++ b/arch/arm/boot/dts/da850-evm.dts @@ -296,7 +296,7 @@ &vpif { pinctrl-names = "default"; - pinctrl-0 = <&vpif_capture_pins>; + pinctrl-0 = <&vpif_capture_pins>, <&vpif_display_pins>; status = "okay"; /* VPIF capture port */ diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 92d633d..5150331 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -216,8 +216,21 @@ 0x3c 0x11111111 0xffffffff /* VP_DIN[8..9] */ 0x40 0x00000011 0x000000ff - /* VP_CLKIN3, VP_CLKIN2 */ - 0x4c 0x00010100 0x000f0f00 + >; + }; + vpif_display_pins: vpif_display_pins { + pinctrl-single,bits = < + /* VP_DOUT[2..7] */ + 0x40 0x11111100 0xffffff00 + /* VP_DOUT[10..15,0..1] */ + 0x44 0x11111111 0xffffffff + /* VP_DOUT[8..9] */ + 0x48 0x00000011 0x000000ff + /* + * VP_CLKOUT3, VP_CLKIN3, + * VP_CLKOUT2, VP_CLKIN2 + */ + 0x4c 0x00111100 0x00ffff00 >; }; };
Add a new pinctrl sub-node for vpif display pins. Move VP_CLKIN3 and VP_CLKIN2 to the display node where they actually belong (vide section 35.2.2 of the da850 datasheet). Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/boot/dts/da850-evm.dts | 2 +- arch/arm/boot/dts/da850.dtsi | 17 +++++++++++++++-- 2 files changed, 16 insertions(+), 3 deletions(-)