Message ID | 1487872921-26628-6-git-send-email-fisaksen@baylibre.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 092B460210 for <patchwork-linux-arm@patchwork.kernel.org>; Thu, 23 Feb 2017 18:05:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1F382877E for <patchwork-linux-arm@patchwork.kernel.org>; Thu, 23 Feb 2017 18:05:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E68F528793; Thu, 23 Feb 2017 18:05:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5D7882877E for <patchwork-linux-arm@patchwork.kernel.org>; Thu, 23 Feb 2017 18:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=TaZ9o24RjDpQ5PgxaH623KIp1nQAGp0IW8qNI9DSh+o=; b=mjzey5VVrB+zUHFpHdjTvAB15O shqv1Hl1swlv6tzwTzFMfdEIKyr6U659bOWvVjDDNrXi13rK9Vi6G2kzcUrEztaC3v/aeokOvqra9 y778hlT5FtGvRBhOVXO8pOlFvLKaqdoE4JjKKe19D3dYO5777Jc0LfEjrHSm6rlcIK/RKpqubYCVK Ra8wxKxIQ/otdJB6hxQQyGBMejD6GP/DnNDDIXT4hqosGFWPdnBQdilKEd1DOijHqp3kmxqMSiyyB 7zuetklZy1cXKbaXQ/PNSehsYE5yXKLIT1VTt5tO3KTK3jnqct+59JuHDVDSNtSh/rtuRupPQDPG+ OnCVKMBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cgxli-0003pN-Ju; Thu, 23 Feb 2017 18:05:30 +0000 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cgxjq-0001NF-De for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2017 18:03:37 +0000 Received: by mail-wr0-x229.google.com with SMTP id s27so26735453wrb.2 for <linux-arm-kernel@lists.infradead.org>; Thu, 23 Feb 2017 10:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4tqqRZZKxw6JLGy6BC63p49tiXRY7L9N9xzmKf9QyWw=; b=rW1UDtzS+GaGWm3wO5SUMSQol9xW3ws/SkmNsdPSZGK4DopYCv77k3qvLDlrRqQSvD W8HkGliJ1316Sm+Hj9BiagnwYH7UNERXDX2OX1H6fXI2hMxFbMYBegxfDs48QS/zReXR lAsfjneP9jIbzC/DFPymlmoLSI0UpatT8/MyjSYUEQGv6L5Kw9xNcBuR14NRHRr53NkJ sgNT2WRklqDU8a2XsYyMroIO6y3ui6gEotL6N9ltEk3BkgxfZjb0wSZtG9d1G6MlSKNH icVSDarJWJr8E4/fEukv8823Xd7P0Cpa413Ewxp+VX46G0dyDmEd7jTMl1zkuu/A3S9i ijGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4tqqRZZKxw6JLGy6BC63p49tiXRY7L9N9xzmKf9QyWw=; b=ubJhnV8GmwuWY7e02m9sxTDu1YFT6sWp3Er/UGburSbphp6VlhpBXgmCs9tCKJgFaz 6SlBemwopZS+MK0/fBdsx8iMUMbOraUnN38AzmbsM3bmGSpmGyG/Svn2vXiu+4E41EYG Hq2tdD0Ff96jGiInzvML/Iqp0ssBJ3NYyx8XPuzTx4TFg2Zoa2gUHyXO6ehr8WPxC3QR B2x1XcncmH/mAWE7u/E93WOkP6cRqN4vSq58Uah/YKs2OdujOB2dKn16NTBKJKIPe94v LPsuROHo1Rj/dzaf6F+IgF8Fu/UyuTnmvnUXZ+ms6fjr3Axy+0uixTUQF/gdr3jB+W2J 7b9A== X-Gm-Message-State: AMke39l32VLe2EjVS9k4ebfrYfOKGnOu8XUwsu59XU3xXYmQjIad3eT1evHemzPv7rc4fU7w X-Received: by 10.223.171.17 with SMTP id q17mr12919719wrc.179.1487872992586; Thu, 23 Feb 2017 10:03:12 -0800 (PST) Received: from localhost.localdomain ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id z134sm7739182wmc.20.2017.02.23.10.03.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Feb 2017 10:03:12 -0800 (PST) From: Frode Isaksen <fisaksen@baylibre.com> To: nsekhar@ti.com, khilman@baylibre.com, ptitiano@baylibre.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 5/6] spi: davinci: do not use DMA for vmalloc'ed buffers Date: Thu, 23 Feb 2017 19:02:00 +0100 Message-Id: <1487872921-26628-6-git-send-email-fisaksen@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1487872921-26628-1-git-send-email-fisaksen@baylibre.com> References: <1487872921-26628-1-git-send-email-fisaksen@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170223_100335_137497_4FE30D84 X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Frode Isaksen <fisaksen@baylibre.com>, broonie@kernel.org, linux-spi@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 75c658e..f37bbdd 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -482,7 +482,9 @@ static bool davinci_spi_can_dma(struct spi_master *master, if (spicfg) can_dma = (spicfg->io_type == SPI_IO_TYPE_DMA) && - (xfer->len >= DMA_MIN_BYTES); + (xfer->len >= DMA_MIN_BYTES) && + !is_vmalloc_addr(xfer->rx_buf) && + !is_vmalloc_addr(xfer->tx_buf); return can_dma; }
Using vmalloc'ed buffers will fail since daVinci has VIVT cache and only the kernel lowmem virtual address is invalidated/flushed when performing DMA. The virtual address returned from vmalloc() is not invalidated/flushed and may contain stale data when returning from spi_sync(). Fixes errors when running UBIFS over SPI NOR. Revert this when all upper layer users of vmalloc'ed buffers sent to SPI handles cache flushing/invalidating. Signed-off-by: Frode Isaksen <fisaksen@baylibre.com> --- drivers/spi/spi-davinci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)