| Message ID | 1488549385-19899-3-git-send-email-sean.wang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 03, 2017 at 09:56:23PM +0800, sean.wang@mediatek.com wrote: > From: Sean Wang <sean.wang@mediatek.com> > > This patch adds documentation for devicetree bindings > for LED support as the subnode of MT6323 PMIC > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 5 +++++ > 1 file changed, 5 insertions(+) Acked-by: Rob Herring <robh@kernel.org>
On 03/03/17 14:56, sean.wang@mediatek.com wrote: > From: Sean Wang <sean.wang@mediatek.com> > > This patch adds documentation for devicetree bindings > for LED support as the subnode of MT6323 PMIC > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index 949c85f..522a3bb 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -6,6 +6,7 @@ MT6397/MT6323 is a multifunction device with the following sub modules: > - Audio codec > - GPIO > - Clock > +- LED > > It is interfaced to host controller using SPI interface by a proprietary hardware > called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of pwrap. > @@ -34,6 +35,10 @@ Optional subnodes: > - clk > Required properties: > - compatible: "mediatek,mt6397-clk" > +- led > + Required properties: > + - compatible: "mediatek,mt6323-led" > + see Documentation/devicetree/bindings/leds/leds-mt6323.txt Part of this patch is already part of linux-next: 05daab3 ("Documentation: devicetree: Add LED subnode binding for MT6323 PMIC") Regards, Matthias
Hi Matthias, On 03/13/2017 01:00 PM, Matthias Brugger wrote: > > > On 03/03/17 14:56, sean.wang@mediatek.com wrote: >> From: Sean Wang <sean.wang@mediatek.com> >> >> This patch adds documentation for devicetree bindings >> for LED support as the subnode of MT6323 PMIC >> >> Signed-off-by: Sean Wang <sean.wang@mediatek.com> >> --- >> Documentation/devicetree/bindings/mfd/mt6397.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt >> b/Documentation/devicetree/bindings/mfd/mt6397.txt >> index 949c85f..522a3bb 100644 >> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt >> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt >> @@ -6,6 +6,7 @@ MT6397/MT6323 is a multifunction device with the >> following sub modules: >> - Audio codec >> - GPIO >> - Clock >> +- LED >> >> It is interfaced to host controller using SPI interface by a >> proprietary hardware >> called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of >> pwrap. >> @@ -34,6 +35,10 @@ Optional subnodes: >> - clk >> Required properties: >> - compatible: "mediatek,mt6397-clk" >> +- led >> + Required properties: >> + - compatible: "mediatek,mt6323-led" >> + see Documentation/devicetree/bindings/leds/leds-mt6323.txt > > Part of this patch is already part of linux-next: > 05daab3 ("Documentation: devicetree: Add LED subnode binding for MT6323 > PMIC") Yes, it's been merged via mfd tree. It doesn't break anything besides that it points to non-existent file. Hopefully we will manage to merge the LED part before merge window, otherwise the mfd part will have to be dropped.
On Mon, 2017-03-13 at 13:00 +0100, Matthias Brugger wrote: > > On 03/03/17 14:56, sean.wang@mediatek.com wrote: > > From: Sean Wang <sean.wang@mediatek.com> > > > > This patch adds documentation for devicetree bindings > > for LED support as the subnode of MT6323 PMIC > > > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > --- > > Documentation/devicetree/bindings/mfd/mt6397.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > > index 949c85f..522a3bb 100644 > > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > > @@ -6,6 +6,7 @@ MT6397/MT6323 is a multifunction device with the following sub modules: > > - Audio codec > > - GPIO > > - Clock > > +- LED > > > > It is interfaced to host controller using SPI interface by a proprietary hardware > > called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of pwrap. > > @@ -34,6 +35,10 @@ Optional subnodes: > > - clk > > Required properties: > > - compatible: "mediatek,mt6397-clk" > > +- led > > + Required properties: > > + - compatible: "mediatek,mt6323-led" > > + see Documentation/devicetree/bindings/leds/leds-mt6323.txt > > Part of this patch is already part of linux-next: > 05daab3 ("Documentation: devicetree: Add LED subnode binding for MT6323 > PMIC") > Hi Matthias, There is still small differences from the merged patch. I will submit the series for the next version based on newer kernel and split the already merged ones out. Thanks for your kindly remainder. Sean > Regards, > Matthias
diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt index 949c85f..522a3bb 100644 --- a/Documentation/devicetree/bindings/mfd/mt6397.txt +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt @@ -6,6 +6,7 @@ MT6397/MT6323 is a multifunction device with the following sub modules: - Audio codec - GPIO - Clock +- LED It is interfaced to host controller using SPI interface by a proprietary hardware called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of pwrap. @@ -34,6 +35,10 @@ Optional subnodes: - clk Required properties: - compatible: "mediatek,mt6397-clk" +- led + Required properties: + - compatible: "mediatek,mt6323-led" + see Documentation/devicetree/bindings/leds/leds-mt6323.txt Example: pwrap: pwrap@1000f000 {