From patchwork Tue Mar 31 23:03:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rafael J. Wysocki" X-Patchwork-Id: 6136701 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 29986BF4A6 for ; Tue, 31 Mar 2015 22:42:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 307E620154 for ; Tue, 31 Mar 2015 22:42:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 464162013D for ; Tue, 31 Mar 2015 22:42:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yd4pI-0001QE-Vl; Tue, 31 Mar 2015 22:40:04 +0000 Received: from v094114.home.net.pl ([79.96.170.134]) by bombadil.infradead.org with smtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yd4pD-0001Cw-OP for linux-arm-kernel@lists.infradead.org; Tue, 31 Mar 2015 22:40:00 +0000 Received: from aeqv225.neoplus.adsl.tpnet.pl (79.191.177.225) (HELO vostro.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer v0.80) id 68be84f55849675b; Wed, 1 Apr 2015 00:39:38 +0200 From: "Rafael J. Wysocki" To: Tyler Baker Subject: Re: Build regression in next-20150331 Date: Wed, 01 Apr 2015 01:03:52 +0200 Message-ID: <1489627.zlEOcOu4fx@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.19.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150331_154000_033337_D06486E4 X-CRM114-Status: GOOD ( 15.44 ) X-Spam-Score: -0.0 (/) Cc: Kevin Hilman , rafael.j.wysocki@intel.com, "linux-kernel@vger.kernel.org" , John Stultz , Thomas Gleixner , linux-arm-kernel X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tuesday, March 31, 2015 11:39:37 AM Tyler Baker wrote: > Hi Thomas, Rafael, > > I was notified this morning by the kernelci.org system that a new > build error has been detected in next-20150331[0][1][2]. It seems that > "clockevents: Remove CONFIG_GENERIC_CLOCKEVENTS_BUILD" > c9439b1d6eb4ada5c2faf3970ac0d2bc4bd20e14 is the culprit. > > Initially, I reported these failures to John Stultz and his response is below. > > *snip* > > I suspect we either need to enable GENERIC_CLOCKEVENTS on those three > hardware types, or if that's not possible, rework the definitions. > > Or something like (copy-paste whitespace corruption below.. only for > reference, don't apply): > > diff --git a/kernel/time/tick-internal.h b/kernel/time/tick-internal.h > index 2a1563a..6da40c0 100644 > --- a/kernel/time/tick-internal.h > +++ b/kernel/time/tick-internal.h > @@ -107,12 +107,13 @@ static inline void tick_resume_broadcast(void) { } > static inline bool tick_resume_check_broadcast(void) { return false; } > static inline void tick_broadcast_init(void) { } > static inline int tick_broadcast_update_freq(struct > clock_event_device *dev, u32 freq) { return -ENODEV; } > - > +#ifdef CONFIG_GENERIC_CLOCKEVENTS > /* Set the periodic handler in non broadcast mode */ > static inline void tick_set_periodic_handler(struct > clock_event_device *dev, int broadcast) > { > dev->event_handler = tick_handle_periodic; > } > +#endif > #endif /* !BROADCAST */ > > *snip* > > Any chance either of you can reproduce this issue on your end? Can you please tell me if the appended patch helps? Rafael --- kernel/time/tick-internal.h | 4 ++++ 1 file changed, 4 insertions(+) Index: linux-pm/kernel/time/tick-internal.h =================================================================== --- linux-pm.orig/kernel/time/tick-internal.h +++ linux-pm/kernel/time/tick-internal.h @@ -107,11 +107,15 @@ static inline bool tick_resume_check_bro static inline void tick_broadcast_init(void) { } static inline int tick_broadcast_update_freq(struct clock_event_device *dev, u32 freq) { return -ENODEV; } +#ifdef CONFIG_GENERIC_CLOCKEVENTS /* Set the periodic handler in non broadcast mode */ static inline void tick_set_periodic_handler(struct clock_event_device *dev, int broadcast) { dev->event_handler = tick_handle_periodic; } +#else +static void tick_handle_periodic(struct clock_event_device *dev) { } +#endif #endif /* !BROADCAST */ /* Functions related to oneshot broadcasting */