From patchwork Tue Mar 21 22:47:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baicar X-Patchwork-Id: 9637777 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DCAD060327 for ; Tue, 21 Mar 2017 22:50:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCBE626E51 for ; Tue, 21 Mar 2017 22:50:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C09A628304; Tue, 21 Mar 2017 22:50:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4485E26E51 for ; Tue, 21 Mar 2017 22:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4x9Nw2xnfz2iEUoDBcwYNYneg2CknROdaoLkvisx81M=; b=LfC/tXkeLOcoz6Mml4HHv6U8E2 uCjru/XiqEQdWyoedx6Qw3sVn8FoXMtD+1X75KxqXFQCMnfcb4Yneji45TuGkvpM6Buph9C3ozHia 61yR+tmJPTk7IZe3w5PiOarxvBm5oC0FNSRDixq3ZELYb++sbwNRnfqtiHU2c5vxGOrMn6mgBogiK fToOeAlHZbxXltk4WwNj53crlTqdEwHD6afMf44tvroV9lqsHwoyIb2ldxgjB94Nr/FLfcJ4t70a5 CfVsUWSs148SAf4jcEiPL7+KU1UIMI73mq/chOrhY+E/RdcHM68Nc4nPqy/7Xwb3mj2xYFjAMumyo 91k68/rw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqSbT-0000Eb-I4; Tue, 21 Mar 2017 22:50:11 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqSZu-0006NP-OX for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2017 22:48:37 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C4C1A61155; Tue, 21 Mar 2017 22:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1490136498; bh=Sk2G4OYZU9ipcVjSeWxci7ujQcXKqzHK6Oa4yv8dP5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GES7L3+Ucobs44aZoavTmViOP4ghYk6ZTFTL8tA1mn40Hp1Gh3YB1gqg3+bKHrdSk 3RCE+WkstB3o0JoP5TWCZeTnoWF1xCVsMaZSIrnqjjl+4gpVK5/svcfrGdKWdubUCU QVfIayy9gznv9c8khxnaLWU/7LRzcVHAjLhN+9qI= Received: from tbaicar-lnx.qualcomm.com (unknown [129.46.14.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tbaicar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 594E860F6C; Tue, 21 Mar 2017 22:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1490136460; bh=Sk2G4OYZU9ipcVjSeWxci7ujQcXKqzHK6Oa4yv8dP5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lz0eNg+MACSRgecxhiVUSNbrkAmMMSjHbdrJ+s0Big8BDI6CbyUdBgwvF7mDmKKCv nr4gp9VhGfVx2hmM/PkvXsmvKWB1m8Qi1ymnPNw1LZRjn9PbQALDh4GBeJ8N5Nmcea eEGOVM+xGTOX3sNGeH/lFletNe/hItDj8mTuVgWs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 594E860F6C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org From: Tyler Baicar To: christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, matt@codeblueprint.co.uk, robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org, zjzhang@codeaurora.org, mark.rutland@arm.com, james.morse@arm.com, akpm@linux-foundation.org, eun.taik.lee@samsung.com, sandeepa.s.prabhu@gmail.com, labbott@redhat.com, shijie.huang@arm.com, rruigrok@codeaurora.org, paul.gortmaker@windriver.com, tn@semihalf.com, fu.wei@linaro.org, rostedt@goodmis.org, bristot@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, devel@acpica.org, Suzuki.Poulose@arm.com, punit.agrawal@arm.com, astone@redhat.com, harba@codeaurora.org, hanjun.guo@linaro.org, john.garry@huawei.com, shiju.jose@huawei.com, joe@perches.com Subject: [PATCH V13 07/10] efi: print unrecognized CPER section Date: Tue, 21 Mar 2017 16:47:02 -0600 Message-Id: <1490136425-4324-8-git-send-email-tbaicar@codeaurora.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1490136425-4324-1-git-send-email-tbaicar@codeaurora.org> References: <1490136425-4324-1-git-send-email-tbaicar@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170321_154834_904013_1AC58B6F X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tyler Baicar MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match with one of the section types that the kernel knows how to parse, the section is skipped. Therefore, user is not able to see such CPER data, for instance, error record of non-standard section. For above mentioned case, this change prints out the raw data in hex in dmesg buffer. Data length is taken from Error Data length field of Generic Error Data Entry. The following is a sample output from dmesg: [ 140.739180] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 2 [ 140.739182] {1}[Hardware Error]: It has been corrected by h/w and requires no further action [ 140.739191] {1}[Hardware Error]: event severity: corrected [ 140.739196] {1}[Hardware Error]: time: precise 2017-03-15 20:37:35 [ 140.739197] {1}[Hardware Error]: Error 0, type: corrected [ 140.739203] {1}[Hardware Error]: section type: unknown, d2e2621c-f936-468d-0d84-15a4ed015c8b [ 140.739205] {1}[Hardware Error]: section length: 568 (0x238) [ 140.739210] {1}[Hardware Error]: 00000000: 4d415201 4d492031 453a4d45 435f4343 .RAM1 IMEM:ECC_C [ 140.739214] {1}[Hardware Error]: 00000010: 53515f45 44525f42 00000000 00000000 E_QSB_RD........ [ 140.739217] {1}[Hardware Error]: 00000020: 00000000 00000000 00000000 00000000 ................ [ 140.739220] {1}[Hardware Error]: 00000030: 00000000 00000000 01010000 01010000 ................ [ 140.739223] {1}[Hardware Error]: 00000040: 00000000 00000000 00000005 00000000 ................ [ 140.739226] {1}[Hardware Error]: 00000050: 01010000 00000000 00000001 00dddd00 ................ ... The raw data from the error can then be decoded using vendor specific tools. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang Reviewed-by: James Morse --- drivers/firmware/efi/cper.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c index 56aa516..d263bc8 100644 --- a/drivers/firmware/efi/cper.c +++ b/drivers/firmware/efi/cper.c @@ -591,8 +591,16 @@ static void cper_estatus_print_section( cper_print_proc_arm(newpfx, arm_err); else goto err_section_too_small; - } else - printk("%s""section type: unknown, %pUl\n", newpfx, sec_type); + } else { + const void *unknown_err; + + unknown_err = acpi_hest_generic_data_payload(gdata); + printk("%ssection type: unknown, %pUl\n", newpfx, sec_type); + printk("%ssection length: %d (%#x)\n", newpfx, + gdata->error_data_length, gdata->error_data_length); + print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16, 4, + unknown_err, gdata->error_data_length, true); + } return;