From patchwork Thu Mar 23 04:53:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 9638737 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 38FC4602CB for ; Wed, 22 Mar 2017 12:57:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A37228464 for ; Wed, 22 Mar 2017 12:57:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D8192842C; Wed, 22 Mar 2017 12:57:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DATE_IN_FUTURE_12_24, DKIM_SIGNED, DKIM_VALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9A6312842C for ; Wed, 22 Mar 2017 12:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ot3cUdv9616omrkESxFZe0l838n0sy4Ao0gzenLDdjk=; b=dMr6rZNao0yLgh Mx+hkMTEpPYvYv3EBxMSu3pgvgNhAGI5PplaaRsuZJB9guN9bx0FhgHZq+gZeczNT/cto3RF16ilc lTYYW2B3kNmi5wU6wf6PakBypw4vu5phCA2kCVS0+0q6EbUpsKyvthA1Vt0FlYhk8bqY27EnxEeDR eB6jedIn+mksaBy6N5wRteOwPduw9oFvSOWIUYnvlVUnhbztGOrdS1u20htpzuHk0U8pfsvdbGBM4 CkGNVEEjUdv9UDY6fMEaRMXV1bxZ2pTzIywBYMwJre8Ra3aRhs7wQ1QZ4NST52f0RzY/LTJOmnhe4 Z/6FjCVc6dPMFY+pm6Xw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqfpQ-0002fH-At; Wed, 22 Mar 2017 12:57:28 +0000 Received: from mail-bl2nam02on0050.outbound.protection.outlook.com ([104.47.38.50] helo=NAM02-BL2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqfp7-0002Lt-9B for linux-arm-kernel@lists.infradead.org; Wed, 22 Mar 2017 12:57:12 +0000 Received: from CY4PR03CA0015.namprd03.prod.outlook.com (10.168.162.25) by CY4PR03MB2792.namprd03.prod.outlook.com (10.173.38.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.17; Wed, 22 Mar 2017 12:56:47 +0000 Received: from BY2FFO11FD036.protection.gbl (2a01:111:f400:7c0c::163) by CY4PR03CA0015.outlook.office365.com (2603:10b6:903:33::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.11 via Frontend Transport; Wed, 22 Mar 2017 12:56:47 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; gmail.com; dkim=none (message not signed) header.d=none; gmail.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD036.mail.protection.outlook.com (10.1.14.221) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.977.7 via Frontend Transport; Wed, 22 Mar 2017 12:56:46 +0000 Received: from b29396-OptiPlex-7040.ap.freescale.net (b29396-OptiPlex-7040.ap.freescale.net [10.192.242.182]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2MCueKa017027; Wed, 22 Mar 2017 05:56:43 -0700 From: Dong Aisheng To: Subject: [PATCH v2 1/8] soc: imx: gpc: fix gpc clk get error handling Date: Thu, 23 Mar 2017 12:53:18 +0800 Message-ID: <1490244805-3921-2-git-send-email-aisheng.dong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490244805-3921-1-git-send-email-aisheng.dong@nxp.com> References: <1490244805-3921-1-git-send-email-aisheng.dong@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131346610070522406; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(39850400002)(39840400002)(39410400002)(39400400002)(39450400003)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(9170700003)(356003)(47776003)(8936002)(76176999)(77096006)(54906002)(38730400002)(8656002)(53936002)(50986999)(81166006)(85426001)(305945005)(5003940100001)(50466002)(48376002)(575784001)(86362001)(6666003)(50226002)(105606002)(110136004)(8676002)(2351001)(106466001)(33646002)(6916009)(4326008)(104016004)(5660300001)(2906002)(2950100002)(36756003)(5890100001)(39060400002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2792; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD036; 1:74rge230qP2DjxvjL8/RfHCezzDbzg1fVnz+IlENqBWFH6rAIOxX884CYBOqi+MR7ezCAS0TryxVTI2krH+wfi1Gp7tB2oHNaSdsGNzGqLFoWo21HlMS0r/M1MvesbyXixCqwQBaWbDzWDqrgTEauPB3VYETifRSLT8F8YiDamqqfKgrHafZbKT7tNT9yBviWmzjOdluMulN8rWC8+nau8wZbvSqhsz0LnL7e2FaqL0JcLUR3Dm6KEzfd/Slv0XQ6kRlAezpzdkWb9jnMQiXk3/zo6sKCnzo56vTlV8qkDIAvE5mmLjneYcfcAcdaxuUmwuQfMJSw7Bj6nGx47yw5lG0ZGnq9s7s8aOUPNZNpf0sTQsovOOYgR1POVUuJlzSyb9Pj/pWcDy77ON/6g1ruxn7NfVXslXnACoNzPxvNJwCsSxHA7n5i9UDgRPPR76a/v4DG/2Bj258ugw34e36gPQ0Bp3kKhgn6cZnfy4DSHAttT6lpQM2hyKLw8r89zPQNkF7AzN8XSfx5dkh8Lnmq3zZjh0QqLGW8YGs5ATU4K4+W6x3xsEMTuxu4oYUoOWmLsvwikwx9pu1LuWaguSs22I6pVtW0sA9ZxAzzIzuwX8= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: cab3ce62-d76f-40d7-28c7-08d47122e629 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY4PR03MB2792; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 3:jytxCvQ9hshE20ZNJ6/n0jUV6NWm/wBEbk62mE205X4PlwnfQwIiFeKBgOXcE9Q/h3W7xMtDjBzbfrke0W7WYeedPOyzBeDuU8euh/Dwamm7Z46/l+eGsJtwY6cUkBOS70+C6s/fRiyuGLYppFyiB70ZqT9Fw9juPiuWKTlbnQG7xRa7/IeEobrRUau4xjtxdRTRGfDrevPy1cDsRhaiGdTAXQJyiBZx4AbNNLu29tuXUFSgq0uy7+3oomfV7MhZHqxMAoRuf3f15jurMF8Sc4/Zt9lsMuJ2mLXM1y261k4TkJURkbf90FxAeAhDjYLRpQBT2tvLF/edy3Am77UGUPoyCaxWBSkPhS/zR7N2dVT0P9xQPxE1evg1v7m29s/i; 25:z3SLioXqOcO0JOFwYKEVLg9VTbww49PYJa6CkiIwegHiVNeq/y95AUEmw8I8v3otn7jQ+WwjvGZDETnfNtIptyvOGSgo0dr+nGx9Ko7OhfjLA5a/vZNOsjQUQAdMnH53vRtKZhhaztqsr+TEcN6E3FQu8LfAiaDAGh0ssaE3twQRhKixXmvmZF9nezrhCSAw7b90bZkgP8OLvDtKBzWGI2h9WVTSiqj1uL+NcBOD+rHqGH8EFV72f9Ns6y2j/tEfGnu+2sftH/yjWVfZSohwE47e74uQTzc/3rocrFbh8iMj1R693cKRtrA2J/jTA10vlSMBzBXPq+HcZ8HbFwTvV6ElF3a1yiWtwTJsPBUzoePBbKI5v5iEbySkhKE50DJBmfEoRQCTCFp635UvmiFb/4TofP72yY8PeghYpUwermHTJR7Uon6u8QQXDV99s/f+4BaQQc5v6gWM4BgA3ByuRg== X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 31:Y8WHaGGP1GI3/e/TGzoWokXNLGkBAuUbmcNbWh2+gndjcs4b7i6Tz5mC2cJlqwWloQKHMq+AMl4zZGtuUBQjdkxq/iBLBNSuz+nrTTX85fD3rbpZm0xgQtnO2ibM6+4WkHV8ZdBy82pcag5gO4jPE9OpIyeGoJwUNX1RGb66SnA2T65lIBIHG02ioQe7XcLdCy5xadI2B+2GMwVzp1ig8nR39+J1WjQXbOTqp7pgJBlHyRcFTRVrgDO7lnJzQpaoAZdEiVMrsTgguFSxpsye8A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(5005006)(13017025)(13015025)(13023025)(8121501046)(13024025)(13018025)(10201501046)(3002001)(6055026)(6096035)(20161123565025)(20161123561025)(20161123563025)(20161123556025)(20161123559025); SRVR:CY4PR03MB2792; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2792; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 4:GkaokysXsfm7jcdsIuWkU5ZiueRkaB03Kc4nGBS1sjMEM5B504rV4WgVMOj5XaOKxsrgI3cDInrtXWyhJ51pwD/KKvBplr2qQB1u+66yYEAUN4e56CQfLthOEw6NpXPlrTmNiQ6dOtUGKhEWSpWuOEZZmtMIBGcqoFk9sTaK74re5ybi7SEZgtM9ZHLdaoNtued227cd8Jptg6EW6U+1kKYPoJC/BQU0RuRveGwfYEVkiYeu66HgPMt5i6ryZ+1w7KeqxXlXf3KBnP3Ia+ejVge79NlkDpWHGaRegCVE9ewwvuVtonBSWTwQVMbKrp+h7TV05O54CQPxEXbns4g8W3Kwq2YfBVmnggZ8zmmDm7xL4xiN5Bd9hilvr/xzI0lWbbAjNbPvW03INEqwwzcNstwQ58rbzEkYs62X0ngcOdIAq/DXJp/tPR691rvUUrrOXjiBvusiJ+RKLcD4LQynUfpcvpCxv6la39VrBm/jdSwzIAjD6zGSAYe4OhyIusvayiiFyZhdD8wZvYcAu/ivoho0I1lk36A909rrceu1ERlKI18M2YEnCywt8oVGnHGO8o3b8aY/2dMHAq49DsZVgrOwlIQdE83dQJ0IDqc5d4eS0ADUma+r7ZtxIiNRUmdZsoan79MPuqwSqj/FfIKfKgVn16H7kS7i7R/8FFAI46Xg+JPvG1X271B0263tG4JeW6z0nneYn7hLLK7eMFiRGAr/rtB5quSZFrkw77MNtXpxLLGlt1A+Oaj7PyBgyG/q X-Forefront-PRVS: 02543CD7CD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR03MB2792; 23:3gubg1MjHCdMlUrekl7nBVcQOy9wCOgZLYkGoWlpy?= =?us-ascii?Q?XN5Es9gjebes6L5vyhy3nz4jmhJZmVbZxMCNhEUCxoPlbzNipsCnIFyPDecb?= =?us-ascii?Q?SCyVVewzbTee+Fsof739VjFLxyBFO19zwFjQjivE2MHsJ/1zb7QEvrKNLymX?= =?us-ascii?Q?1qe3022eLjiqhR6llb3zE1SnJx7LPTsWo5ZqwGa/FNJX40MHQ5ivUS9Y+oti?= =?us-ascii?Q?w/ggYkcglH61cgAd1rqq3avBWyfnUL+IUrzay+oFMJxXEw2CEzAu5lICZajb?= =?us-ascii?Q?otMLx55Js0LwUwbcAwlaxnAMRR6A92+BCwGG+eQ1wJv/ECfn/WJzV0EkquO7?= =?us-ascii?Q?Md9qrFf4smKvFmgsXMtJaF9d3ev1u8Ou5ICXREzhOlGA9rUBF3bVWqNOsdRy?= =?us-ascii?Q?4IX4itQh82NbICvoL4TnaWOb/wO0xBoS7udNdscOvEZ5pZIdSgqWG/KKkgfq?= =?us-ascii?Q?v0sGnXJRDtmc3zoNUAO9hxvhZFSq9dTWwyG3tw8p8YFTZTdaA2vVLv9pbwzH?= =?us-ascii?Q?dWFY5JdgyELDT4ok2r6ZD+UkhLCxWxy19azXUqvqKVv4CD/x4mjtfTBwBEMh?= =?us-ascii?Q?YdrUdU/3WaIFs062k4+kj/bq4K5LU8QKAYNgb/xW6OxZc12gOkP8HP8pWhbj?= =?us-ascii?Q?jbL3BZnCb8KJL9snN90iBG948R/kKTSz45s9SVQv9zhVDFvqpawVr/zTFtUg?= =?us-ascii?Q?Z4Zhq8FtQcw0iOlahEsbwXslvMnSqS0RwtaxmeBR3y7s2wzf5iEiMCM223rH?= =?us-ascii?Q?Jcai9bIXruet2Vkp4ns2Ykpw8UuKEHD9MoFsPX7fwBWjzDyRSbDxOxhGlpcw?= =?us-ascii?Q?UPDtXE2C22qVZIO7hU4EqSJz9HdTaCbGaOt/6v6ThGx/rQbh6Qf6AHml3gRt?= =?us-ascii?Q?Ll1W12De5puwkwafN1FCb/LCo3GE7hBm/1mFEPYhwdLDV60avFgllF+JWghO?= =?us-ascii?Q?Psr0EqV2TU5Ktk8dHNHElPBxl8TxmdoLs21BjC0sO6D7tRI1StEy6ym6C8pp?= =?us-ascii?Q?Z005TDmRQIk8pv8mNzVwUAE5Eo52IXkQ2p8OPHWI9Z0cBy2ZZ9lMCNgxgeT0?= =?us-ascii?Q?ElG21JIShKzucQ4KutPOJYHVHxsSVDaN/f2Vot477rIV6d/kvuvrT5I/kBTJ?= =?us-ascii?Q?VPkeTsHyp/EWR7FYxwZAKBwLN/8HXkYpFEJ/XiKR4kZ1mCsC1jfQkbHQbHbw?= =?us-ascii?Q?d8BaJVZTpjpN8fIkUx45YLGgcPyNp9l6/cYMQ+elqZ7lY08eLRqSwyxE2dR7?= =?us-ascii?Q?K5yxUwgqk0rPKUMsqS+1q22obcdgvbv/vWPldyJnzops6XUJs1GUej+tPrYm?= =?us-ascii?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 6:CwXtEgwqi1UBcNb5WxyIUtUCdiJqQZesv4RET4CfzmisZKFFzzvOBwUTfB54TDvshZj5fT+hegB+wdZNPqIomVDQnpskkho+rqQJs0G9Hmw9NLZ132UofWRBJ/Xk0sP+rTi46W83Y7So7DkU1Qd1Nc0DvtUZz8QNCCJH6+SS1mQGdCmGjPZTCUaqhZQE2LcnRPSi43mHEo/UgSN9Hem/0U8KrgBPHy+79nMWsICrMbd3v9XH/pxfWwpq/wyt+7zcfy8FM9Y5CcNccaTCFkHrqNDNpDbxozwh32K2MDmPVg0Eh5qv6kA6uCvTTeAtyXguhen03BJfjF0Mo6UTcw5HyWkZENN+Vlp33CzmCaLGstmsUtQDHZkK2A02593JFIEUekYpYBY/4uCc/2NVugRkG0G14pHYYQivrzta6ZGRoqs=; 5:ev76SUhO8pk9rFsAD/5SNl7VRT1LvYc4x06ewJRm8CLgPvMuaTCeUwAQ3jwkIl4s7yI80FQRbR5jzqg4vpEbxh9GZvQ1T9wZeiW8lLiaHegudyvZyGCIVwi/Nd/ASHuc+uDNIw9NqjXTG1MBFTXT5FQKc/au5/osUOXPjxBA0vvJUK5BqMtcCw2Wrmob9oO8; 24:31/xoFt4cp+nx2oFjx0lg9BpslRsbNGQutiTX+1kmKGsQpQe+vVSrM1+/ZHUySkjD171FCmAooX4eeFCZwOUQtiEU4K3vabDPEOWtsW6azk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2792; 7:I6VFofB5q/+UJZ+jcHvI3xovT6MrKYooCJvsAn31xM1w8VJ0twxYsneINYkYgm0ewA8cm5NZwYYQydY5kaPnFxUcq2RgSrgkKZWDzcWnUbd5POAJ7aPtGrD2qY5i23I9qnzD8oTLBYXIheMP1qULnTjQGPpHuEdmW6sno4Fwm2sTzAxesiQL7iE1CC+vTmHyS70cfbFAlvJjrspft/LM3zCrMgrEuMgy6R3dREWIYZpONZhseiXz2gHA9zLe1wFoG4D3BQRsGynb1VSgVzKOEF4Kfpumh0ictjuxoyecfDPI879dsFW/cvHpkbJNqTYoPYfoVux+D8RE7SxKxc1rrg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 12:56:46.8494 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2792 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170322_055709_615483_07A7DBFA X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aisheng.dong@nxp.com, dongas86@gmail.com, andrew.smirnov@gmail.com, fabio.estevam@nxp.com, shawnguo@kernel.org, l.stach@pengutronix.de Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP We got a following kernel crash once supplying one more IPG clock in GPC node in devicetree. The original error handling of clocks get is a bit wrong that when reaching the maximum clock get error, the index 'i' is already GPC_CLK_MAX which can't be used as the array index for clk_put operations. [ 3.000110] imx-gpc 20dc000.gpc: more than 6 clocks [ 3.005141] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 3.013487] pgd = c0004000 [ 3.016300] [00000000] *pgd=00000000 [ 3.020060] Internal error: Oops: 805 [#1] SMP ARM [ 3.024957] Modules linked in: [ 3.028122] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.11.0-rc1-00056-g813791b-dirty #1140 [ 3.037801] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) [ 3.044435] task: ef298000 task.stack: ef294000 [ 3.049080] PC is at __clk_put+0x38/0xec [ 3.053103] LR is at 0x7f54ce9a [ 3.056345] pc : [] lr : [<7f54ce9a>] psr: 60000013 [ 3.056345] sp : ef295d48 ip : c8a582b2 fp : ef295d64 [ 3.068026] r10: ee9fc400 r9 : 00000000 r8 : ef398c10 [ 3.073354] r7 : ef398c10 r6 : c1071264 r5 : c10710f0 r4 : eea5be80 [ 3.079986] r3 : 00000000 r2 : 00000000 r1 : 00000100 r0 : 00000001 [ 3.086621] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 3.093863] Control: 10c5387d Table: 1000404a DAC: 00000051 [ 3.099712] Process swapper/0 (pid: 1, stack limit = 0xef294210) [ 3.105823] Stack: (0xef295d48 to 0xef296000) ... [ 3.292660] Backtrace: [ 3.295222] [] (__clk_put) from [] (clk_put+0x18/0x1c) [ 3.302206] r6:c1071264 r5:c10710f0 r4:c107124c r3:00000001 [ 3.307977] [] (clk_put) from [] (imx_pgc_get_clocks+0x64/0x78) [ 3.315747] [] (imx_pgc_get_clocks) from [] (imx_gpc_probe+0x204/0x31c) [ 3.324209] r7:00000000 r6:c1070eb0 r5:00000001 r4:ef398c00 [ 3.329980] [] (imx_gpc_probe) from [] (platform_drv_probe+0x5c/0xc0) [ 3.338270] r10:c0f00608 r9:00000000 r8:00000000 r7:fffffdfb r6:c1070f20 r5:ef398c10 [ 3.346207] r4:ef398c10 [ 3.348849] [] (platform_drv_probe) from [] (driver_probe_device+0x214/0x2ec) [ 3.357835] r7:c1070f20 r6:00000000 r5:c18cea74 r4:ef398c10 [ 3.363607] [] (driver_probe_device) from [] (__driver_attach+0xc4/0xc8) [ 3.372159] r9:c0f8b858 r8:c0f8b850 r7:00000000 r6:ef398c44 r5:c1070f20 r4:ef398c10 [ 3.380017] [] (__driver_attach) from [] (bus_for_each_dev+0x7c/0xb0) [ 3.388304] r6:c05e4328 r5:c1070f20 r4:00000000 r3:00000000 [ 3.394074] [] (bus_for_each_dev) from [] (driver_attach+0x28/0x30) [ 3.402188] r6:c107f3e8 r5:eea5be00 r4:c1070f20 [ 3.406913] [] (driver_attach) from [] (bus_add_driver+0x19c/0x224) [ 3.415034] [] (bus_add_driver) from [] (driver_register+0x88/0x108) [ 3.423235] r7:c10e1000 r6:00000000 r5:c0f57d2c r4:c1070f20 [ 3.429004] [] (driver_register) from [] (__platform_driver_register+0x40/0x54) [ 3.438160] r5:c0f57d2c r4:00000006 [ 3.441846] [] (__platform_driver_register) from [] (imx_gpc_driver_init+0x18/0x20) [ 3.451360] [] (imx_gpc_driver_init) from [] (do_one_initcall+0x4c/0x180) [ 3.460008] [] (do_one_initcall) from [] (kernel_init_freeable+0x130/0x1f8) [ 3.468820] r9:c0f8b858 r8:c0f8b850 r6:c0fc2414 r5:c10e1000 r4:00000006 [ 3.475637] [] (kernel_init_freeable) from [] (kernel_init+0x18/0x124) [ 3.484014] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c0ae6ad4 [ 3.491951] r4:00000000 [ 3.494590] [] (kernel_init) from [] (ret_from_fork+0x14/0x24) [ 3.502267] r4:00000000 r3:ef294000 [ 3.505947] Code: e5943014 e5942018 e3530000 e3a01c01 (e5823000) [ 3.512215] ---[ end trace 375f9f2a5ddeff3c ]--- [ 3.517036] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b Cc: Lucas Stach Cc: Shawn Guo Fixes: 721cabf6c660 ("soc: imx: move PGC handling to a new GPC driver") Signed-off-by: Dong Aisheng --- drivers/soc/imx/gpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c index 1e9b3b8..c9bfdfd 100644 --- a/drivers/soc/imx/gpc.c +++ b/drivers/soc/imx/gpc.c @@ -143,7 +143,7 @@ static int imx_pgc_get_clocks(struct device *dev, struct imx_pm_domain *domain) return 0; clk_err: - for (; i >= 0; i--) + while (i--) clk_put(domain->clk[i]); return ret;