| Message ID | 1492408934-22096-4-git-send-email-hoegeun.kwon@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17.04.2017 08:02, Hoegeun Kwon wrote: > This patch add the panel device tree node for s6e3hf2 display > controller to TM2e dts. > > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> Maybe it would be good to remove te-gpios property - tm2/tm2e uses hardware trigger, so it is not necessary and generates useless interrupts. Beside this: Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > index 694717a..98ad094 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > @@ -52,6 +52,18 @@ > assigned-clock-rates = <278000000>, <400000000>; > }; > > +&dsi { > + panel@0 { > + compatible = "samsung,s6e3hf2"; > + reg = <0>; > + vdd3-supply = <&ldo27_reg>; > + vci-supply = <&ldo28_reg>; > + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; > + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; > + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > &ldo31_reg { > regulator-name = "TSP_VDD_1.8V_AP"; > regulator-min-microvolt = <1800000>;
On 04/18/2017 03:00 PM, Andrzej Hajda wrote: > On 17.04.2017 08:02, Hoegeun Kwon wrote: >> This patch add the panel device tree node for s6e3hf2 display >> controller to TM2e dts. >> >> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > Maybe it would be good to remove te-gpios property - tm2/tm2e uses > hardware trigger, so it is not necessary and generates useless interrupts. Thanks for your review. I agree, but I thinks remove the te-gpio property after your patch [1] has been merged. [1] https://patchwork.kernel.org/patch/9625383/ Best regards, Hoegeun > > Beside this: > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > -- > Regards > Andrzej >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> index 694717a..98ad094 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> @@ -52,6 +52,18 @@ >> assigned-clock-rates = <278000000>, <400000000>; >> }; >> >> +&dsi { >> + panel@0 { >> + compatible = "samsung,s6e3hf2"; >> + reg = <0>; >> + vdd3-supply = <&ldo27_reg>; >> + vci-supply = <&ldo28_reg>; >> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >> + }; >> +}; >> + >> &ldo31_reg { >> regulator-name = "TSP_VDD_1.8V_AP"; >> regulator-min-microvolt = <1800000>; > > >
On 18.04.2017 09:44, Hoegeun Kwon wrote: > On 04/18/2017 03:00 PM, Andrzej Hajda wrote: >> On 17.04.2017 08:02, Hoegeun Kwon wrote: >>> This patch add the panel device tree node for s6e3hf2 display >>> controller to TM2e dts. >>> >>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >> Maybe it would be good to remove te-gpios property - tm2/tm2e uses >> hardware trigger, so it is not necessary and generates useless interrupts. > Thanks for your review. > > I agree, but I thinks remove the te-gpio property after your patch [1] > has been merged. Patch [1] has been merged about month ago :) Regards Andrzej > > > [1] https://patchwork.kernel.org/patch/9625383/ > > Best regards, > Hoegeun > >> Beside this: >> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> >> -- >> Regards >> Andrzej >>> --- >>> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >>> index 694717a..98ad094 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >>> @@ -52,6 +52,18 @@ >>> assigned-clock-rates = <278000000>, <400000000>; >>> }; >>> >>> +&dsi { >>> + panel@0 { >>> + compatible = "samsung,s6e3hf2"; >>> + reg = <0>; >>> + vdd3-supply = <&ldo27_reg>; >>> + vci-supply = <&ldo28_reg>; >>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >>> + }; >>> +}; >>> + >>> &ldo31_reg { >>> regulator-name = "TSP_VDD_1.8V_AP"; >>> regulator-min-microvolt = <1800000>; >> >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >
On 04/18/2017 04:56 PM, Andrzej Hajda wrote: > On 18.04.2017 09:44, Hoegeun Kwon wrote: >> On 04/18/2017 03:00 PM, Andrzej Hajda wrote: >>> On 17.04.2017 08:02, Hoegeun Kwon wrote: >>>> This patch add the panel device tree node for s6e3hf2 display >>>> controller to TM2e dts. >>>> >>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >>> Maybe it would be good to remove te-gpios property - tm2/tm2e uses >>> hardware trigger, so it is not necessary and generates useless interrupts. >> Thanks for your review. >> >> I agree, but I thinks remove the te-gpio property after your patch [1] >> has been merged. > Patch [1] has been merged about month ago :) Ah..., My mistake.... :) I will send ver3 patchset without te-gpio property. Best regards, Hoegeun
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts index 694717a..98ad094 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts @@ -52,6 +52,18 @@ assigned-clock-rates = <278000000>, <400000000>; }; +&dsi { + panel@0 { + compatible = "samsung,s6e3hf2"; + reg = <0>; + vdd3-supply = <&ldo27_reg>; + vci-supply = <&ldo28_reg>; + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; + }; +}; + &ldo31_reg { regulator-name = "TSP_VDD_1.8V_AP"; regulator-min-microvolt = <1800000>;
This patch add the panel device tree node for s6e3hf2 display controller to TM2e dts. Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)