| Message ID | 1493023915-21658-1-git-send-email-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 24, 2017 at 10:51 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > The device trees for Renesas SoCs use either pfc or pin-controller > as the node name for the PFC device. This patch is intended to take a step > towards unifying the node name used as pin-controller which appears to > be more the more generic of the two and thus more in keeping with the DT s/be more/be/ > specs. > > My analysis is that this is a user-visible change to the extent that kernel > logs, and sysfs entries change from e6060000.pfc and pfc@e6060000 to > e6060000.pin-controller and pin-controller@e6060000. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Apr 24, 2017 at 11:03:54AM +0200, Geert Uytterhoeven wrote: > On Mon, Apr 24, 2017 at 10:51 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > The device trees for Renesas SoCs use either pfc or pin-controller > > as the node name for the PFC device. This patch is intended to take a step > > towards unifying the node name used as pin-controller which appears to > > be more the more generic of the two and thus more in keeping with the DT > > s/be more/be/ > > > specs. > > > > My analysis is that this is a user-visible change to the extent that kernel > > logs, and sysfs entries change from e6060000.pfc and pfc@e6060000 to > > e6060000.pin-controller and pin-controller@e6060000. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I fixed the typo when queuing this up.
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index e99d6443b3e4..7d87dff70ac8 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi @@ -398,7 +398,7 @@ #power-domain-cells = <1>; }; - pfc: pfc@e6060000 { + pfc: pin-controller@e6060000 { compatible = "renesas,pfc-r8a7795"; reg = <0 0xe6060000 0 0x50c>; };
The device trees for Renesas SoCs use either pfc or pin-controller as the node name for the PFC device. This patch is intended to take a step towards unifying the node name used as pin-controller which appears to be more the more generic of the two and thus more in keeping with the DT specs. My analysis is that this is a user-visible change to the extent that kernel logs, and sysfs entries change from e6060000.pfc and pfc@e6060000 to e6060000.pin-controller and pin-controller@e6060000. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Before: /sys/kernel/debug/pinctrl/e6060000.pfc /sys/devices/platform/soc/e6060000.pfc /sys/firmware/devicetree/base/soc/pfc@e6060000 /sys/bus/platform/devices/e6060000.pfc /sys/bus/platform/drivers/sh-pfc /sys/bus/platform/drivers/sh-pfc/e6060000.pfc After: /sys/kernel/debug/pinctrl/e6060000.pin-controller /sys/devices/platform/soc/e6060000.pin-controller /sys/firmware/devicetree/base/soc/pin-controller@e6060000 /sys/bus/platform/devices/e6060000.pin-controller /sys/bus/platform/drivers/sh-pfc /sys/bus/platform/drivers/sh-pfc/e6060000.pin-controller --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)