From patchwork Thu May 18 16:57:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinath Mannam X-Patchwork-Id: 9734825 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 465E96022E for ; Thu, 18 May 2017 16:58:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3566128898 for ; Thu, 18 May 2017 16:58:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2A080288B9; Thu, 18 May 2017 16:58:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B0EF3288B5 for ; Thu, 18 May 2017 16:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ayxhDOGAvmkrT8+Pr6zxYA5WshbEZ4WeoskMITd+Ayo=; b=boH loy4sMHDCypfiGScDZTlVd4iGKoqjjYFWLVK/zKgbMVvhSPQX5HVnkRjJrhJO946WGQc/95mSk3xD vvBwOrxNn8E+Hfk1FxILsfENL0u1ftwlpCegmHDWnDpa0Dk4HIfyO+197uzwspeYz+7hbFqAfvs2d nsBnV5pcxea2wbtnCqhyZC+NqoKcwsyaGh3BWvDCl7RcLKKSqwtMmmrr4kI9qfn5E2mAyifwJWx0M bGwPj6DVOfSYE6d6ifG+0jbQcW+vVkE2d+t08imiagbrHjfYy5/l9d342oHKVEwnntnNO476wXb5M ye33QTlppYtWIlro4ZJwnNIyn6qxeuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dBOkq-0002N3-R8; Thu, 18 May 2017 16:58:24 +0000 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dBOkn-0002M4-OU for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2017 16:58:23 +0000 Received: by mail-wr0-x229.google.com with SMTP id l9so40262050wre.1 for ; Thu, 18 May 2017 09:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=20VrcwBheCU4/815O2HKv5XteZyXxhI6V6HLG0q7MXc=; b=Fg2ZEBBzf3Q8KHcA7oVZkagsMIIBkn834vBgoyE58I8n18buK4a2UBpkLV4CZ5yjZr ua/7syJIk46DwwPWSbCzABY+Upyrn/1nUAkdWS95eEa9KlV/FG9UO+Lz4R9dw06TsCaj bFiFXz59GERW4Lk/FKa/1WZ6O3hLsc8jDXHBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=20VrcwBheCU4/815O2HKv5XteZyXxhI6V6HLG0q7MXc=; b=csu2pwqAcsa7qUdvCJF14SNOqbt/6Zt8x9MR3wmXhmpJxCTNcovtnbMW6TI6iSnmTD /cqOJCTBeX6nMZV/kAxuBm0PHeiohg5AWgUta/ij6UJNzL70FLys67f6hrTplnmP3MfP q737MIKbKAjKtnJfJmr/Kh3lAcH3BSzBau1w1LcvSgvpNayqLlsXHDNAN6/QLCDbEzsp sFpwq8Ix4JMX0s7tb8BvZ7R9yWmYBswA71N7Gj3DjkvpyBdboaDVzxuG64iZwVs+A4Ma t8J9Tz5ka0fRXMolMgBq9mdIJMYPFpIJYCxkSznrCAreY2CxaLDIbEa/Q2l1yqVFTYua LDuQ== X-Gm-Message-State: AODbwcA8A/alvFh75OzW3Pm0T/pVFEBxinU9slpiO9xaCCm7offWj7Uq 6bryCrteKim9VSAX X-Received: by 10.223.149.33 with SMTP id 30mr3635366wrs.61.1495126679803; Thu, 18 May 2017 09:57:59 -0700 (PDT) Received: from mannams-OptiPlex-7010.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id v22sm4103795wrd.38.2017.05.18.09.57.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 May 2017 09:57:59 -0700 (PDT) From: Srinath Mannam To: adrian.hunter@intel.com Subject: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read Date: Thu, 18 May 2017 22:27:40 +0530 Message-Id: <1495126660-25044-1-git-send-email-srinath.mannam@broadcom.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170518_095821_980987_7640A1ED X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, sbranden@broadcom.com, jonmason@broadcom.com, rjui@broadcom.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Srinath Mannam , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The stingray SDHCI hardware supports ACMD12 and automatically issues after multi block transfer completed. If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen on multi block read command with below error message: Got data interrupt 0x00000002 even though no data operation was in progress. This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable ACM12 support in SDHCI hardware and suppress spurious interrupt. Signed-off-by: Srinath Mannam Reviewed-by: Ray Jui Reviewed-by: Scott Branden Acked-by: Adrian Hunter diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c index 3275d49..61666d2 100644 --- a/drivers/mmc/host/sdhci-iproc.c +++ b/drivers/mmc/host/sdhci-iproc.c @@ -187,7 +187,8 @@ static const struct sdhci_iproc_data iproc_cygnus_data = { }; static const struct sdhci_pltfm_data sdhci_iproc_pltfm_data = { - .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK, + .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | + SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, .quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN, .ops = &sdhci_iproc_ops, };