| Message ID | 1495553564-19112-2-git-send-email-fabio.estevam@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Fabio Estevam <fabio.estevam@nxp.com> wrote: > Property 'enable-active-low' does not exist. Only 'enable-active-high' is > valid, and when this property is absent the gpio regulator will act as > active low by default. > > So remove the unexisting 'enable-active-low' property. > > Currently the GPIO flag is GPIO_ACTIVE_HIGH. In order to make > the dts description accurate, pass the GPIO_ACTIVE_LOW flag instead. > > This change is safe because the gpio regulator driver does not take the > GPIO flag polarity into account. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> > --- > Changes since v1: > - Improve commit log and explain why this change is safe (Stefan). > > arch/arm/boot/dts/imx6qdl-tx6.dtsi | 3 +-- > arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi > index 1691714..a146fe7 100644 > --- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi > @@ -133,8 +133,7 @@ > regulator-max-microvolt = <3300000>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_flexcan_xcvr>; > - gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>; > - enable-active-low; > + gpio = <&gpio4 21 GPIO_ACTIVE_LOW>; > }; > > reg_lcd0_pwr: regulator-lcd0-pwr { > diff --git a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi > index c784a0b..4ccc9e9 100644 > --- a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi > +++ b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi > @@ -173,8 +173,7 @@ > regulator-max-microvolt = <3300000>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_flexcan_xcvr>; > - gpio = <&gpio3 5 GPIO_ACTIVE_HIGH>; > - enable-active-low; > + gpio = <&gpio3 5 GPIO_ACTIVE_LOW>; > }; > > reg_lcd_pwr: regulator-lcdpwr { Acked-by: Lothar Waßmann <LW@KARO-electronics.de> Thanks for the cleanup, Lothar Waßmann
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi index 1691714..a146fe7 100644 --- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi +++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi @@ -133,8 +133,7 @@ regulator-max-microvolt = <3300000>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_flexcan_xcvr>; - gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>; - enable-active-low; + gpio = <&gpio4 21 GPIO_ACTIVE_LOW>; }; reg_lcd0_pwr: regulator-lcd0-pwr { diff --git a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi index c784a0b..4ccc9e9 100644 --- a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi +++ b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi @@ -173,8 +173,7 @@ regulator-max-microvolt = <3300000>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_flexcan_xcvr>; - gpio = <&gpio3 5 GPIO_ACTIVE_HIGH>; - enable-active-low; + gpio = <&gpio3 5 GPIO_ACTIVE_LOW>; }; reg_lcd_pwr: regulator-lcdpwr {
Property 'enable-active-low' does not exist. Only 'enable-active-high' is valid, and when this property is absent the gpio regulator will act as active low by default. So remove the unexisting 'enable-active-low' property. Currently the GPIO flag is GPIO_ACTIVE_HIGH. In order to make the dts description accurate, pass the GPIO_ACTIVE_LOW flag instead. This change is safe because the gpio regulator driver does not take the GPIO flag polarity into account. Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- Changes since v1: - Improve commit log and explain why this change is safe (Stefan). arch/arm/boot/dts/imx6qdl-tx6.dtsi | 3 +-- arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)