| Message ID | 1497278211-5001-8-git-send-email-suzuki.poulose@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jun 12, 2017 at 03:36:46PM +0100, Suzuki K Poulose wrote: > Expose the idfilter* registers of the programmable replicator. Is this for SoC600 only? If so we need to make sure these are not visible when operating an SoC400 replicator. Otherwise simply disregard my statement. > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > .../hwtracing/coresight/coresight-replicator-qcom.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-replicator-qcom.c b/drivers/hwtracing/coresight/coresight-replicator-qcom.c > index b029a5f..4dd18e0 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator-qcom.c > +++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c > @@ -95,6 +95,26 @@ static const struct coresight_ops replicator_cs_ops = { > .link_ops = &replicator_link_ops, > }; > > +coresight_simple_func(struct replicator_state, NULL, idfilter0, > + REPLICATOR_IDFILTER0); > +coresight_simple_func(struct replicator_state, NULL, idfilter1, > + REPLICATOR_IDFILTER1); > +static struct attribute *replicator_mgmt_attrs[] = { > + &dev_attr_idfilter0.attr, > + &dev_attr_idfilter1.attr, > + NULL, > +}; > + > +static const struct attribute_group replicator_mgmt_group = { > + .attrs = replicator_mgmt_attrs, > + .name = "mgmt", > +}; > + > +static const struct attribute_group *replicator_groups[] = { > + &replicator_mgmt_group, > + NULL, > +}; > + > static int replicator_probe(struct amba_device *adev, const struct amba_id *id) > { > int ret; > @@ -139,6 +159,7 @@ static int replicator_probe(struct amba_device *adev, const struct amba_id *id) > desc.ops = &replicator_cs_ops; > desc.pdata = adev->dev.platform_data; > desc.dev = &adev->dev; > + desc.groups = replicator_groups; > drvdata->csdev = coresight_register(&desc); > if (IS_ERR(drvdata->csdev)) > return PTR_ERR(drvdata->csdev); > -- > 2.7.4 >
On 14/06/17 18:54, Mathieu Poirier wrote: > On Mon, Jun 12, 2017 at 03:36:46PM +0100, Suzuki K Poulose wrote: >> Expose the idfilter* registers of the programmable replicator. > > Is this for SoC600 only? If so we need to make sure these are not visible when > operating an SoC400 replicator. Otherwise simply disregard my statement. No, this is for the existing dynamic replicator, which is also compatible with the one in SoC-600. In the future, we may be able to support multiple trace sessions (i.e, distinct source-sink pairs using a shared dynamic replicator to filter the data based on the trace-id). Right now we simple switch off the other side of the replicator, when we enable the port connected to the sink. I found these useful while debugging trace generation issue on one of the platforms. Suzuki
diff --git a/drivers/hwtracing/coresight/coresight-replicator-qcom.c b/drivers/hwtracing/coresight/coresight-replicator-qcom.c index b029a5f..4dd18e0 100644 --- a/drivers/hwtracing/coresight/coresight-replicator-qcom.c +++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c @@ -95,6 +95,26 @@ static const struct coresight_ops replicator_cs_ops = { .link_ops = &replicator_link_ops, }; +coresight_simple_func(struct replicator_state, NULL, idfilter0, + REPLICATOR_IDFILTER0); +coresight_simple_func(struct replicator_state, NULL, idfilter1, + REPLICATOR_IDFILTER1); +static struct attribute *replicator_mgmt_attrs[] = { + &dev_attr_idfilter0.attr, + &dev_attr_idfilter1.attr, + NULL, +}; + +static const struct attribute_group replicator_mgmt_group = { + .attrs = replicator_mgmt_attrs, + .name = "mgmt", +}; + +static const struct attribute_group *replicator_groups[] = { + &replicator_mgmt_group, + NULL, +}; + static int replicator_probe(struct amba_device *adev, const struct amba_id *id) { int ret; @@ -139,6 +159,7 @@ static int replicator_probe(struct amba_device *adev, const struct amba_id *id) desc.ops = &replicator_cs_ops; desc.pdata = adev->dev.platform_data; desc.dev = &adev->dev; + desc.groups = replicator_groups; drvdata->csdev = coresight_register(&desc); if (IS_ERR(drvdata->csdev)) return PTR_ERR(drvdata->csdev);
Expose the idfilter* registers of the programmable replicator. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- .../hwtracing/coresight/coresight-replicator-qcom.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)