From patchwork Fri Jun 30 17:41:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 9820203 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD75A60224 for ; Fri, 30 Jun 2017 17:43:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A8A5728606 for ; Fri, 30 Jun 2017 17:43:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B808286B6; Fri, 30 Jun 2017 17:43:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 207BA28606 for ; Fri, 30 Jun 2017 17:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=BJFzhf+b0/eXjoCwH0CczoCxAffrqnMP5IMKiIvXoGA=; b=Ry+OjIXFGlMuEbHYd/WTn8puOV jzDDboVtzApVCZ+qnItf7SAfKd1XRixBNO7IxE9l9PHKSS3GauuevUYNkdhYDO5VsH65U0ctjThWu qJa/UPUbZG6ibkgw20IvV3EvyEJ1gZzAljuLrxbv1Rgb4QUBWR4fhBcEKe6wqh0G5Mp8a2104gaSk kxC446V5Jh0+Uw8jAmIUU08yKBZpAs9W65DhOBVyC8vcVBQaKiRdoOmaPTyFJ8yonGUNjqeutL61l DTce/psq0ZnDT8rQigt7zPe6oaM2kkep6RUQxKWGikO/hivC9Ucw5ijzPfZzTCcLTzrZV8R75Y4gS lLxggrvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dQzwl-00013g-KX; Fri, 30 Jun 2017 17:43:11 +0000 Received: from mail-io0-x22e.google.com ([2607:f8b0:4001:c06::22e]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dQzw3-0000BQ-Br for linux-arm-kernel@lists.infradead.org; Fri, 30 Jun 2017 17:42:30 +0000 Received: by mail-io0-x22e.google.com with SMTP id r36so27964600ioi.1 for ; Fri, 30 Jun 2017 10:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pmhkwVdEuAIaGm/mPToB6JoRcAsRGADAFEXdMsqjieA=; b=J0YP3fPmy9wZ8QjaXYnfgvJZlUPqT72AzKcmOft1HudpwejnLwUfPkYA5ACYiT5tXl OtKWkuB4K7UBkO7TVnVJ2+bawio80wrupAxDGB42AOWNi3IN5SPdnisjTcQUGudiVg1s PHm3J2+3C1+UpzBNx79S9PZGY8zYkEI3osyUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pmhkwVdEuAIaGm/mPToB6JoRcAsRGADAFEXdMsqjieA=; b=cMI9chTFNhiBJDGOU7FtSQ3hBh4JYT3/xIroN9UKiFKwThxbyd99SBMRnZ8pWZ+7wO USINUd4DSyFDW9l9uUNyTgAaUevXSZv2UcU7LvqKYy4Gch4DZoRN2aLuwfs/aJFDnw8r fRZZSTYEl+PtLcNFUneqE1IJ+NsJCBrxieyQeyr0/Y//mKyESFjNA16VJksjVVqIKgNw AnB8O9LwMEzIGrSOoUWFbPXylSk2nkDi7SvNUPAOqxpUQzlc1zj3BEHFUWbqpt3h8HFp VDeO3J17m2s4/NNzpVbgLB0NM9WNgSfRNrUiIrRok/VtxMDHcpCMHfr5MDtI7Z7zlOma HUig== X-Gm-Message-State: AKS2vOx/MdIdRgeEJ6CK9+eTah6c8IpgTHXCKl1sWAjulZzqJpq788+I zUjtgI36unxmRLTY1tcHsw== X-Received: by 10.107.56.4 with SMTP id f4mr23707426ioa.86.1498844526333; Fri, 30 Jun 2017 10:42:06 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id d23sm4381451ioj.22.2017.06.30.10.42.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Jun 2017 10:42:05 -0700 (PDT) From: Mathieu Poirier To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] coresight: etb10: Move etb_disable_hw() outside of lock Date: Fri, 30 Jun 2017 11:41:58 -0600 Message-Id: <1498844519-8845-5-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498844519-8845-1-git-send-email-mathieu.poirier@linaro.org> References: <1498844519-8845-1-git-send-email-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170630_104227_440121_FF8A700E X-CRM114-Status: UNSURE ( 9.19 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Function etb_disable_hw() is already taking care of unlocking and locking the coresight access register and as such doesn't need to be placed within the unlock/lock of function etb_update_buffer(). Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etb10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 42360306f049..d0d186575c5d 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -376,8 +376,8 @@ static void etb_update_buffer(struct coresight_device *csdev, capacity = drvdata->buffer_depth * ETB_FRAME_SIZE_WORDS; - CS_UNLOCK(drvdata->base); etb_disable_hw(drvdata); + CS_UNLOCK(drvdata->base); /* unit is in words, not bytes */ read_ptr = readl_relaxed(drvdata->base + ETB_RAM_READ_POINTER);