diff mbox

[1/3] dts: ls2088a: add pcie support

Message ID 1499331330-38362-1-git-send-email-Zhiqiang.Hou@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Z.Q. Hou July 6, 2017, 8:55 a.m. UTC 
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

The physical memory map address and CCSR registers map address are
different between LS2088A and other LS2080A series SoCs.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Shawn Guo July 13, 2017, 8:17 a.m. UTC | #1 
On Thu, Jul 06, 2017 at 04:55:28PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> 
> The physical memory map address and CCSR registers map address are
> different between LS2088A and other LS2080A series SoCs.
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
> index 5c695c6..7d26531 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
> @@ -134,6 +134,7 @@
>  };
>  
>  &pcie1 {
> +	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";

I do not see "fsl,ls2088a-pcie" in either bindings doc or kernel driver.

Shawn

>  	reg = <0x00 0x03400000 0x0 0x00100000   /* controller registers */
>  	       0x20 0x00000000 0x0 0x00002000>; /* configuration space */
>  
> @@ -142,6 +143,7 @@
>  };
>  
>  &pcie2 {
> +	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";
>  	reg = <0x00 0x03500000 0x0 0x00100000   /* controller registers */
>  	       0x28 0x00000000 0x0 0x00002000>; /* configuration space */
>  
> @@ -150,6 +152,7 @@
>  };
>  
>  &pcie3 {
> +	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";
>  	reg = <0x00 0x03600000 0x0 0x00100000   /* controller registers */
>  	       0x30 0x00000000 0x0 0x00002000>; /* configuration space */
>  
> @@ -158,6 +161,7 @@
>  };
>  
>  &pcie4 {
> +	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";
>  	reg = <0x00 0x03700000 0x0 0x00100000   /* controller registers */
>  	       0x38 0x00000000 0x0 0x00002000>; /* configuration space */
>  
> -- 
> 2.1.0.27.g96db324
>
Z.Q. Hou July 13, 2017, 8:27 a.m. UTC | #2 
Hi Shawn,

Thanks for your comments!

> -----Original Message-----

> From: Shawn Guo [mailto:shawnguo@kernel.org]

> Sent: 2017年7月13日 16:18

> To: Z.q. Hou <zhiqiang.hou@nxp.com>

> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;

> robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com;

> will.deacon@arm.com; Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>

> Subject: Re: [PATCH 1/3] dts: ls2088a: add pcie support

> 

> On Thu, Jul 06, 2017 at 04:55:28PM +0800, Zhiqiang Hou wrote:

> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

> >

> > The physical memory map address and CCSR registers map address are

> > different between LS2088A and other LS2080A series SoCs.

> >

> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

> > ---

> >  arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi | 4 ++++

> >  1 file changed, 4 insertions(+)

> >

> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

> > b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

> > index 5c695c6..7d26531 100644

> > --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

> > @@ -134,6 +134,7 @@

> >  };

> >

> >  &pcie1 {

> > +	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";

> 

> I do not see "fsl,ls2088a-pcie" in either bindings doc or kernel driver.

> 


I submitted the DT node patch and driver code patch separately, see the driver patch:
https://patchwork.kernel.org/patch/9827915/

Thanks,
Zhiqiang
Shawn Guo July 13, 2017, 8:31 a.m. UTC | #3 
On Thu, Jul 13, 2017 at 08:27:47AM +0000, Z.q. Hou wrote:
> Hi Shawn,
> 
> Thanks for your comments!
> 
> > -----Original Message-----
> > From: Shawn Guo [mailto:shawnguo@kernel.org]
> > Sent: 2017年7月13日 16:18
> > To: Z.q. Hou <zhiqiang.hou@nxp.com>
> > Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com;
> > will.deacon@arm.com; Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > Subject: Re: [PATCH 1/3] dts: ls2088a: add pcie support
> > 
> > On Thu, Jul 06, 2017 at 04:55:28PM +0800, Zhiqiang Hou wrote:
> > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > >
> > > The physical memory map address and CCSR registers map address are
> > > different between LS2088A and other LS2080A series SoCs.
> > >
> > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
> > > index 5c695c6..7d26531 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
> > > @@ -134,6 +134,7 @@
> > >  };
> > >
> > >  &pcie1 {
> > > +	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";
> > 
> > I do not see "fsl,ls2088a-pcie" in either bindings doc or kernel driver.
> > 
> 
> I submitted the DT node patch and driver code patch separately, see the driver patch:
> https://patchwork.kernel.org/patch/9827915/

Send me the dts changes after bindings and driver patch land on
mainline.

Shawn
Z.Q. Hou July 13, 2017, 8:34 a.m. UTC | #4 
> -----Original Message-----

> From: Shawn Guo [mailto:shawnguo@kernel.org]

> Sent: 2017年7月13日 16:31

> To: Z.q. Hou <zhiqiang.hou@nxp.com>

> Cc: mark.rutland@arm.com; devicetree@vger.kernel.org;

> catalin.marinas@arm.com; Prabhakar Kushwaha

> <prabhakar.kushwaha@nxp.com>; will.deacon@arm.com;

> robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org

> Subject: Re: [PATCH 1/3] dts: ls2088a: add pcie support

> 

> On Thu, Jul 13, 2017 at 08:27:47AM +0000, Z.q. Hou wrote:

> > Hi Shawn,

> >

> > Thanks for your comments!

> >

> > > -----Original Message-----

> > > From: Shawn Guo [mailto:shawnguo@kernel.org]

> > > Sent: 2017年7月13日 16:18

> > > To: Z.q. Hou <zhiqiang.hou@nxp.com>

> > > Cc: linux-arm-kernel@lists.infradead.org;

> > > devicetree@vger.kernel.org;

> > > robh+dt@kernel.org; mark.rutland@arm.com; catalin.marinas@arm.com;

> > > will.deacon@arm.com; Prabhakar Kushwaha

> <prabhakar.kushwaha@nxp.com>

> > > Subject: Re: [PATCH 1/3] dts: ls2088a: add pcie support

> > >

> > > On Thu, Jul 06, 2017 at 04:55:28PM +0800, Zhiqiang Hou wrote:

> > > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

> > > >

> > > > The physical memory map address and CCSR registers map address are

> > > > different between LS2088A and other LS2080A series SoCs.

> > > >

> > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

> > > > ---

> > > >  arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi | 4 ++++

> > > >  1 file changed, 4 insertions(+)

> > > >

> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

> > > > b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

> > > > index 5c695c6..7d26531 100644

> > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

> > > > @@ -134,6 +134,7 @@

> > > >  };

> > > >

> > > >  &pcie1 {

> > > > +	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";

> > >

> > > I do not see "fsl,ls2088a-pcie" in either bindings doc or kernel driver.

> > >

> >

> > I submitted the DT node patch and driver code patch separately, see the

> driver patch:

> > https://patchwork.kernel.org/patch/9827915/

> 

> Send me the dts changes after bindings and driver patch land on mainline.


Sure, thanks a lot!

- Zhiqiang
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
index 5c695c6..7d26531 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi
@@ -134,6 +134,7 @@ 
 };
 
 &pcie1 {
+	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";
 	reg = <0x00 0x03400000 0x0 0x00100000   /* controller registers */
 	       0x20 0x00000000 0x0 0x00002000>; /* configuration space */
 
@@ -142,6 +143,7 @@ 
 };
 
 &pcie2 {
+	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";
 	reg = <0x00 0x03500000 0x0 0x00100000   /* controller registers */
 	       0x28 0x00000000 0x0 0x00002000>; /* configuration space */
 
@@ -150,6 +152,7 @@ 
 };
 
 &pcie3 {
+	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";
 	reg = <0x00 0x03600000 0x0 0x00100000   /* controller registers */
 	       0x30 0x00000000 0x0 0x00002000>; /* configuration space */
 
@@ -158,6 +161,7 @@ 
 };
 
 &pcie4 {
+	compatible = "fsl,ls2088a-pcie", "snps,dw-pcie";
 	reg = <0x00 0x03700000 0x0 0x00100000   /* controller registers */
 	       0x38 0x00000000 0x0 0x00002000>; /* configuration space */