From patchwork Thu Jul 13 19:04:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Shah X-Patchwork-Id: 9839593 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C25A602A0 for ; Thu, 13 Jul 2017 18:23:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A4729287F1 for ; Thu, 13 Jul 2017 21:25:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9809228824; Thu, 13 Jul 2017 21:25:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 247D8287F1 for ; Thu, 13 Jul 2017 21:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=08EmbCrlSL5poaj40soS80PCNxW3A8CPqsEjNZ+p8rE=; b=oLiBXGJkoCpMdh0gs/s2c4iOiz uo5Reol1ziZU4X6mo8AhNN50u9okFhzRRPiUczYnm9muUD2Vvl2YMU+CCdOZQBCw48jUW8Br5UjhS y2sv513j8ZL2LUH0DrKq0bsTiOm8cvvXWs+Dtxq3ogPxZqmS1PTKirfduIF0tULyTJdFlan7derg2 pUjLouUd6e/29947+ACMO8RXuk7yOw4eroopM129nlhscVI7rARB2zEvDSvEfq7p9QDx44Kgq7gzE PvFsNobdPaYcHb951C/5owqQU3VjPdsGFlR/Mvz1qUyKlHKS4IpY5zzNpdRNIUo4O/qSskvHqwrz4 WH+veb+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dVjQL-0007rd-0F; Thu, 13 Jul 2017 19:05:17 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dVjPx-0006sK-Tb for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2017 19:05:00 +0000 Received: by mail-wm0-x22a.google.com with SMTP id w126so1605927wme.0 for ; Thu, 13 Jul 2017 12:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=v0o0nUGmkA0OC9EjEtJW8XqhcuwljR8ZNWq1rEve5ec=; b=gQNIlebBuVpUGP3q2zoDMacxS2v6k/NaXZaUP6kYC7rvA9hYkuCH2NOaZa26KAOGIu VPSz+2Ze5OomE6WKR4i12my446T5Pwd5iIHoxTHGjLOpJbxSqrElK67xjVZICxI+8Eam lzV9sSdwV/yHGz9KMckAVDD/+cSE7jHmuqKiI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=v0o0nUGmkA0OC9EjEtJW8XqhcuwljR8ZNWq1rEve5ec=; b=HL1r6dr8ly+IkAEMZ87t70kZTvWKy2s1T2e6huxTdFOneitnsr5Td4RhoRO1/HRsAb T1/vnPlMR06VCxWiNDu/KuW1Reac9wDEWRTtrK4upxCEHr0xfV1BqoeKUGSU29jm/oet Ctjc33ePCZrbpoZ6vytec8k7tJFlGOFjbbSjwl77A1edkMcNli8NeYqQ0Op1EjPP3jx1 qDaht+L7r3D9RrJFoEFntfyOTeX/+JgQLgRgLjNdIhYOvWkzYY8SCyRUh/tAQm0kJLf2 pbEtYGy9+wKmMSQBq+G8gZtMxOjtD3hrg1J/3Uh3Ck3LtgYi0JinSVI48VJBEO1ChR8C eXjw== X-Gm-Message-State: AIVw113y1LeRi1Y7aOMPaabDTcSNiha8RdPbcBHZRiUWgX7uBJ3KciPa 1apBIMMtFubVCFzB X-Received: by 10.28.142.133 with SMTP id q127mr180178wmd.4.1499972672032; Thu, 13 Jul 2017 12:04:32 -0700 (PDT) Received: from ashah1-OptiPlex-7010.dhcp.avagotech.net ([192.19.237.250]) by smtp.gmail.com with ESMTPSA id e17sm158959wma.19.2017.07.13.12.04.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 13 Jul 2017 12:04:31 -0700 (PDT) From: Abhishek Shah To: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Florian Fainelli , "David S . Miller" , Jon Mason , Rob Herring , Mark Rutland Subject: [PATCH 1/3] net: ethernet: bgmac: Remove unnecessary 'return' from platform_bgmac_idm_write Date: Fri, 14 Jul 2017 00:34:07 +0530 Message-Id: <1499972649-6200-2-git-send-email-abhishek.shah@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1499972649-6200-1-git-send-email-abhishek.shah@broadcom.com> References: <1499972649-6200-1-git-send-email-abhishek.shah@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170713_120454_835678_275278A1 X-CRM114-Status: UNSURE ( 9.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Abhishek Shah , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Return type for idm register write callback should be void as 'writel' API is used for write operation. However, there no need to have 'return' in this function. Signed-off-by: Abhishek Shah Reviewed-by: Oza Oza Reviewed-by: Ray Jui Reviewed-by: Scott Branden --- drivers/net/ethernet/broadcom/bgmac-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bgmac-platform.c b/drivers/net/ethernet/broadcom/bgmac-platform.c index 73aca97..1ca75de 100644 --- a/drivers/net/ethernet/broadcom/bgmac-platform.c +++ b/drivers/net/ethernet/broadcom/bgmac-platform.c @@ -50,7 +50,7 @@ static u32 platform_bgmac_idm_read(struct bgmac *bgmac, u16 offset) static void platform_bgmac_idm_write(struct bgmac *bgmac, u16 offset, u32 value) { - return writel(value, bgmac->plat.idm_base + offset); + writel(value, bgmac->plat.idm_base + offset); } static bool platform_bgmac_clk_enabled(struct bgmac *bgmac)