| Message ID | 1500298768-13262-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 17 Jul 2017 15:39:28 +0200 Geert Uytterhoeven <geert+renesas@glider.be> wrote: > All low-level PM/SMP code using virt_to_phys() should actually use > __pa_symbol() against kernel symbols. Update the documentation to move > away from virt_to_phys(). > > Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of > virt_to_phys with __pa_symbol") I was kind of hoping for an ack from somebody on this, but, four months later, I'll take the absence of complaints as being enough. Applied, thanks. jon
On Mon, Jul 17, 2017 at 01:44:45PM -0600, Jonathan Corbet wrote: > On Mon, 17 Jul 2017 15:39:28 +0200 > Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > > All low-level PM/SMP code using virt_to_phys() should actually use > > __pa_symbol() against kernel symbols. Update the documentation to move > > away from virt_to_phys(). > > > > Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of > > virt_to_phys with __pa_symbol") > > I was kind of hoping for an ack from somebody on this, but, four months > later, I'll take the absence of complaints as being enough. Applied, > thanks. Maybe those who contributed Documentation/arm/firmware.txt should have responded, seems that was Tomasz Figa <t.figa@samsung.com> who isn't even on the Cc list for this... Can't blame people who aren't copied with the patch for not responding.
Hi Russell, On Mon, Jul 17, 2017 at 11:20 PM, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: > On Mon, Jul 17, 2017 at 01:44:45PM -0600, Jonathan Corbet wrote: >> On Mon, 17 Jul 2017 15:39:28 +0200 >> Geert Uytterhoeven <geert+renesas@glider.be> wrote: >> >> > All low-level PM/SMP code using virt_to_phys() should actually use >> > __pa_symbol() against kernel symbols. Update the documentation to move >> > away from virt_to_phys(). >> > >> > Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of >> > virt_to_phys with __pa_symbol") >> >> I was kind of hoping for an ack from somebody on this, but, four months >> later, I'll take the absence of complaints as being enough. Applied, >> thanks. > > Maybe those who contributed Documentation/arm/firmware.txt should > have responded, seems that was Tomasz Figa <t.figa@samsung.com> > who isn't even on the Cc list for this... Ah, get_maintainer.pl didn't report Tomasz' Samsung email address, which bounces for sure ;-) > Can't blame people who aren't copied with the patch for not > responding. I did copy the people responsible for the __pa_symbol conversion. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 07/17/2017 06:39 AM, Geert Uytterhoeven wrote: > All low-level PM/SMP code using virt_to_phys() should actually use > __pa_symbol() against kernel symbols. Update the documentation to move > away from virt_to_phys(). > > Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of > virt_to_phys with __pa_symbol") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Sorry for not noticing earlier. > --- > Documentation/arm/firmware.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/arm/firmware.txt b/Documentation/arm/firmware.txt > index da6713adac8acffc..7f175dbb427e631a 100644 > --- a/Documentation/arm/firmware.txt > +++ b/Documentation/arm/firmware.txt > @@ -60,7 +60,7 @@ Example of using a firmware operation: > > /* some platform code, e.g. SMP initialization */ > > - __raw_writel(virt_to_phys(exynos4_secondary_startup), > + __raw_writel(__pa_symbol(exynos4_secondary_startup), > CPU1_BOOT_REG); > > /* Call Exynos specific smc call */ >
diff --git a/Documentation/arm/firmware.txt b/Documentation/arm/firmware.txt index da6713adac8acffc..7f175dbb427e631a 100644 --- a/Documentation/arm/firmware.txt +++ b/Documentation/arm/firmware.txt @@ -60,7 +60,7 @@ Example of using a firmware operation: /* some platform code, e.g. SMP initialization */ - __raw_writel(virt_to_phys(exynos4_secondary_startup), + __raw_writel(__pa_symbol(exynos4_secondary_startup), CPU1_BOOT_REG); /* Call Exynos specific smc call */
All low-level PM/SMP code using virt_to_phys() should actually use __pa_symbol() against kernel symbols. Update the documentation to move away from virt_to_phys(). Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of virt_to_phys with __pa_symbol") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Documentation/arm/firmware.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)