From patchwork Thu Jul 20 09:42:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J, KEERTHY" X-Patchwork-Id: 9854423 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 88CB9602BA for ; Thu, 20 Jul 2017 09:43:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CB742876B for ; Thu, 20 Jul 2017 09:43:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7147D28776; Thu, 20 Jul 2017 09:43:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 18A3B2875E for ; Thu, 20 Jul 2017 09:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0FQbB5CY1ppplytXGI3P0Z9rHOzQoO/S52h+66obk/A=; b=UoA5JjwhPRzskk IvUK3srUz6ACmaGRiNadOqXKKEMpuXWqd2cr50aQLdxr5MjDyu24ujFkbdElhw7QuApJVY/m9vPmO 4lkFuvOqGBbxsANCsRUSLb9lKVY8MNMCOWRlFHG76ObGMzMARTaInxnudfInZ0K8yEaE+YgeMLo8I /2UnP50IoYvQq86Nt/i54v436qYW6Ql09WsNY+w/Rb602O2Usk5zo81S/M2DMY65VT6//QJFSUgXV dSSgHwapCLtdVCDxu07O5j4qzZSYIlpvwWbFdRz1Qv+NT0QebmmkI6n+fZ8dFhEGlGfclOAwAzHrc oCL3t376T3+CAJV1LUUg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dY7zO-0002Qp-A0; Thu, 20 Jul 2017 09:43:22 +0000 Received: from fllnx210.ext.ti.com ([198.47.19.17]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dY7z8-000291-TT for linux-arm-kernel@lists.infradead.org; Thu, 20 Jul 2017 09:43:15 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id v6K9giNK003895; Thu, 20 Jul 2017 04:42:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1500543764; bh=nI0rojQVphrV4lNJpj5hwchgpyJzaTA1EwH6WtaShTM=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=wlHlvrg1KTiuiz7iTGhb1zg+DHk86CTIYge5QIL/c44yscnZM3eBxZeGHyDrFOSnm d6EK4ElNdr3bSbCPqcRehRl/6Y74CN4HfiCiX5sYuNNIV+B/euuiOE65dCr0NnXvXz /qhtGFJJc3nkB5P9Q6WnkXiYI/QQXF+kA2RZFkYA= Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v6K9gi8X005989; Thu, 20 Jul 2017 04:42:44 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.294.0; Thu, 20 Jul 2017 04:42:44 -0500 Received: from ula0393675.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v6K9gQAM020613; Thu, 20 Jul 2017 04:42:40 -0500 From: Keerthy To: Subject: [PATCH v2 3/3] gpio: davinci: Convert prinkt to dev_err Date: Thu, 20 Jul 2017 15:12:18 +0530 Message-ID: <1500543738-9696-4-git-send-email-j-keerthy@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1500543738-9696-1-git-send-email-j-keerthy@ti.com> References: <1500543738-9696-1-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170720_024307_864501_B6BB5A15 X-CRM114-Status: UNSURE ( 7.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: j-keerthy@ti.com, nsekhar@ti.com, t-kristo@ti.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, fcooper@ti.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In case of devm_clk_get failure use dev_err instead of printk Signed-off-by: Keerthy --- drivers/gpio/gpio-davinci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index d6fb1ce..f75d844 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -490,8 +490,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) clk = devm_clk_get(dev, "gpio"); if (IS_ERR(clk)) { - printk(KERN_ERR "Error %ld getting gpio clock?\n", - PTR_ERR(clk)); + dev_err(dev, "Error %ld getting gpio clock\n", PTR_ERR(clk)); return PTR_ERR(clk); } ret = clk_prepare_enable(clk);