diff mbox

[v3,2/2] ARM: dts: keystone-k2g-evm: Add gpio nodes

Message ID 1501051524-5990-2-git-send-email-j-keerthy@ti.com
State New, archived
Headers show

Commit Message

J, KEERTHY July 26, 2017, 6:45 a.m. UTC
66AK2G has 2 instances of gpio. The first one has all the 144 GPIOs
functional( 9 banks with 16 gpios = 144). The second instance has
only the GPIO0:GPIO67 functional and rest are marked reserved.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---

The patch depends on the below series:

http://marc.info/?l=linux-arm-kernel&m=150034845427555&w=2
http://marc.info/?l=linux-arm-kernel&m=150034856627618&w=2

Driver patches related are already posted:

https://www.spinics.net/lists/arm-kernel/msg594862.html

Changes in v2:

  * Split the documentation part into a separate patch.

 arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

Comments

Suman Anna July 26, 2017, 1:03 p.m. UTC | #1
Hi Keerthy,

On 07/26/2017 01:45 AM, Keerthy wrote:
> 66AK2G has 2 instances of gpio. The first one has all the 144 GPIOs
> functional( 9 banks with 16 gpios = 144). The second instance has

nit, space before ( and not after.

> only the GPIO0:GPIO67 functional and rest are marked reserved.

s/keystone-k2g-evm/keystone-k2g/ on the patch header please, otherwise
this patch looks good.

> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> 
> The patch depends on the below series:
> 
> http://marc.info/?l=linux-arm-kernel&m=150034845427555&w=2
> http://marc.info/?l=linux-arm-kernel&m=150034856627618&w=2

FYI, these are already picked up my Santosh and are part of linux-next.

regards
Suman

> 
> Driver patches related are already posted:
> 
> https://www.spinics.net/lists/arm-kernel/msg594862.html
> 
> Changes in v2:
> 
>   * Split the documentation part into a separate patch.
> 
>  arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
> index bf4d1fa..f9ff299 100644
> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
> @@ -15,6 +15,7 @@
>  
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/pinctrl/keystone.h>
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	compatible = "ti,k2g","ti,keystone";
> @@ -168,5 +169,46 @@
>  				#reset-cells = <2>;
>  			};
>  		};
> +
> +		gpio0: gpio@2603000 {
> +			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
> +			reg = <0x02603000 0x100>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +
> +			interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			ti,ngpio = <144>;
> +			ti,davinci-gpio-unbanked = <0>;
> +			clocks = <&k2g_clks 0x001b 0x0>;
> +			clock-names = "gpio";
> +		};
> +
> +		gpio1: gpio@260a000 {
> +			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
> +			reg = <0x0260a000 0x100>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 443 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 444 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 445 IRQ_TYPE_EDGE_RISING>,
> +					<GIC_SPI 446 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-controller;
> +			#interrupt-cells = <2>;
> +			ti,ngpio = <68>;
> +			ti,davinci-gpio-unbanked = <0>;
> +			clocks = <&k2g_clks 0x001c 0x0>;
> +			clock-names = "gpio";
> +		};
>  	};
>  };
>
J, KEERTHY July 26, 2017, 1:29 p.m. UTC | #2
On Wednesday 26 July 2017 06:33 PM, Suman Anna wrote:
> Hi Keerthy,
> 
> On 07/26/2017 01:45 AM, Keerthy wrote:
>> 66AK2G has 2 instances of gpio. The first one has all the 144 GPIOs
>> functional( 9 banks with 16 gpios = 144). The second instance has
> 
> nit, space before ( and not after.

Sure.

> 
>> only the GPIO0:GPIO67 functional and rest are marked reserved.
> 
> s/keystone-k2g-evm/keystone-k2g/ on the patch header please, otherwise
> this patch looks good.

Okay.

> 
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>
>> The patch depends on the below series:
>>
>> http://marc.info/?l=linux-arm-kernel&m=150034845427555&w=2
>> http://marc.info/?l=linux-arm-kernel&m=150034856627618&w=2
> 
> FYI, these are already picked up my Santosh and are part of linux-next.

Yes saw that now. I will send v4.

> 
> regards
> Suman
> 
>>
>> Driver patches related are already posted:
>>
>> https://www.spinics.net/lists/arm-kernel/msg594862.html
>>
>> Changes in v2:
>>
>>   * Split the documentation part into a separate patch.
>>
>>  arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>> index bf4d1fa..f9ff299 100644
>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>> @@ -15,6 +15,7 @@
>>  
>>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>>  #include <dt-bindings/pinctrl/keystone.h>
>> +#include <dt-bindings/gpio/gpio.h>
>>  
>>  / {
>>  	compatible = "ti,k2g","ti,keystone";
>> @@ -168,5 +169,46 @@
>>  				#reset-cells = <2>;
>>  			};
>>  		};
>> +
>> +		gpio0: gpio@2603000 {
>> +			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
>> +			reg = <0x02603000 0x100>;
>> +			gpio-controller;
>> +			#gpio-cells = <2>;
>> +
>> +			interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
>> +			interrupt-controller;
>> +			#interrupt-cells = <2>;
>> +			ti,ngpio = <144>;
>> +			ti,davinci-gpio-unbanked = <0>;
>> +			clocks = <&k2g_clks 0x001b 0x0>;
>> +			clock-names = "gpio";
>> +		};
>> +
>> +		gpio1: gpio@260a000 {
>> +			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
>> +			reg = <0x0260a000 0x100>;
>> +			gpio-controller;
>> +			#gpio-cells = <2>;
>> +			interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 443 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 444 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 445 IRQ_TYPE_EDGE_RISING>,
>> +					<GIC_SPI 446 IRQ_TYPE_EDGE_RISING>;
>> +			interrupt-controller;
>> +			#interrupt-cells = <2>;
>> +			ti,ngpio = <68>;
>> +			ti,davinci-gpio-unbanked = <0>;
>> +			clocks = <&k2g_clks 0x001c 0x0>;
>> +			clock-names = "gpio";
>> +		};
>>  	};
>>  };
>>
>
Russell King - ARM Linux admin July 26, 2017, 1:33 p.m. UTC | #3
On Wed, Jul 26, 2017 at 06:59:58PM +0530, Keerthy wrote:
> >> +
> >> +		gpio0: gpio@2603000 {
> >> +			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
> >> +			reg = <0x02603000 0x100>;
> >> +			gpio-controller;
> >> +			#gpio-cells = <2>;
> >> +
> >> +			interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
> >> +			interrupt-controller;
> >> +			#interrupt-cells = <2>;
> >> +			ti,ngpio = <144>;
> >> +			ti,davinci-gpio-unbanked = <0>;
> >> +			clocks = <&k2g_clks 0x001b 0x0>;
> >> +			clock-names = "gpio";
> >> +		};
> >> +
> >> +		gpio1: gpio@260a000 {
> >> +			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
> >> +			reg = <0x0260a000 0x100>;
> >> +			gpio-controller;
> >> +			#gpio-cells = <2>;
> >> +			interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 443 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 444 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 445 IRQ_TYPE_EDGE_RISING>,
> >> +					<GIC_SPI 446 IRQ_TYPE_EDGE_RISING>;
> >> +			interrupt-controller;
> >> +			#interrupt-cells = <2>;
> >> +			ti,ngpio = <68>;
> >> +			ti,davinci-gpio-unbanked = <0>;
> >> +			clocks = <&k2g_clks 0x001c 0x0>;
> >> +			clock-names = "gpio";
> >> +		};

With the addition of GPIO support, does that mean there is a chance to
control the noisy fan via the kernel's thermal management?  Do we have
temperature sensor support for Keystone 2 ?
J, KEERTHY July 26, 2017, 1:43 p.m. UTC | #4
On Wednesday 26 July 2017 07:03 PM, Russell King - ARM Linux wrote:
> On Wed, Jul 26, 2017 at 06:59:58PM +0530, Keerthy wrote:
>>>> +
>>>> +		gpio0: gpio@2603000 {
>>>> +			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
>>>> +			reg = <0x02603000 0x100>;
>>>> +			gpio-controller;
>>>> +			#gpio-cells = <2>;
>>>> +
>>>> +			interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
>>>> +			interrupt-controller;
>>>> +			#interrupt-cells = <2>;
>>>> +			ti,ngpio = <144>;
>>>> +			ti,davinci-gpio-unbanked = <0>;
>>>> +			clocks = <&k2g_clks 0x001b 0x0>;
>>>> +			clock-names = "gpio";
>>>> +		};
>>>> +
>>>> +		gpio1: gpio@260a000 {
>>>> +			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
>>>> +			reg = <0x0260a000 0x100>;
>>>> +			gpio-controller;
>>>> +			#gpio-cells = <2>;
>>>> +			interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 443 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 444 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 445 IRQ_TYPE_EDGE_RISING>,
>>>> +					<GIC_SPI 446 IRQ_TYPE_EDGE_RISING>;
>>>> +			interrupt-controller;
>>>> +			#interrupt-cells = <2>;
>>>> +			ti,ngpio = <68>;
>>>> +			ti,davinci-gpio-unbanked = <0>;
>>>> +			clocks = <&k2g_clks 0x001c 0x0>;
>>>> +			clock-names = "gpio";
>>>> +		};
> 
> With the addition of GPIO support, does that mean there is a chance to
> control the noisy fan via the kernel's thermal management?  Do we have
> temperature sensor support for Keystone 2 ?

Russell,

GPIO support using davinci driver for K2HK/L/E was there for a long time
here: arch/arm/boot/dts/keystone.dtsi

commit 970c225636ac4ae98739094d6b6bbf2bdc3694f9
Author: Grygorii Strashko <grygorii.strashko@ti.com>
Date:   Mon Feb 10 18:41:18 2014 +0200

    ARM: dts: keystone: add gpio device entry

I have only added the k2g nodes now as it is different compared to other
keystone 2 platforms.

I believe there is no temperature sensor support for Keystone 2 yet.

Regards,
Keerthy
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index bf4d1fa..f9ff299 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -15,6 +15,7 @@ 
 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/pinctrl/keystone.h>
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	compatible = "ti,k2g","ti,keystone";
@@ -168,5 +169,46 @@ 
 				#reset-cells = <2>;
 			};
 		};
+
+		gpio0: gpio@2603000 {
+			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
+			reg = <0x02603000 0x100>;
+			gpio-controller;
+			#gpio-cells = <2>;
+
+			interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			ti,ngpio = <144>;
+			ti,davinci-gpio-unbanked = <0>;
+			clocks = <&k2g_clks 0x001b 0x0>;
+			clock-names = "gpio";
+		};
+
+		gpio1: gpio@260a000 {
+			compatible = "ti,keystone-k2g-gpio", "ti,keystone-gpio";
+			reg = <0x0260a000 0x100>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 443 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 444 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 445 IRQ_TYPE_EDGE_RISING>,
+					<GIC_SPI 446 IRQ_TYPE_EDGE_RISING>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			ti,ngpio = <68>;
+			ti,davinci-gpio-unbanked = <0>;
+			clocks = <&k2g_clks 0x001c 0x0>;
+			clock-names = "gpio";
+		};
 	};
 };