| Message ID | 1502930102-8648-1-git-send-email-trini@konsulko.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Tom, Some nit picking on the patch comment. :-) On 08/16/17 17:35, Tom Rini wrote: > This introduces the variabe DTC_EXTRA_FLAGS to allow for additional > flags to be passed to dtc. While this can have many uses (such as > easier testing of new warning flags) the use case I wish to spell out > here is passing of -@ to enable __symbols__ to be included in the > resulting dtb and thus 'stacked' overlays to be able to be used. Not just stacked overlays (I'm guessing by that you mean an overlay applied on top of an overlay), but even an overlay on top of the base dtb. > When passing in -@ this will increase the size of the dtb (and resident > memory usage) in exchange for allowing more types of overlays to be > applied to the dtb file prior to passing it to Linux and additional > functionality within the kernel when OF_OVERLAY is enabled and in tools > outside of the kernel. Not so much additional functionality within the kernel. It is basic functionality for any overlay to be applied in the kernel. > > Cc: Jason Kridner <jkridner@beagleboard.org> > Cc: Drew Fustini <drew@beagleboard.org> > Cc: Robert Nelson <robertcnelson@gmail.com> > Cc: Lokesh Vutla <lokeshvutla@ti.com> > Cc: Frank Rowand <frowand.list@gmail.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: Michal Marek <mmarek@suse.com> > CC: linux-kbuild@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > This would be v3 of my attempt to enable __symbols__ more widely (v2, > for people not on the CC, enabled it always, but for some boards). > > To be clear, this version of the patch is more flexible in that it > allows for arbitrary flags to be passed to dtc, which can have other > uses. But, I'm still spelling out -@ being the motivation behind this > for clarity. Thank you, that is very useful info to capture in the commit history. > Both Frank and Rob were uncomfortable with v2, and Frank > suggested this approach to make it easier for users / distributions / > etc to opt-in to this functionality. For clarity, Frank was suggesting > (at least at first) perhaps also a tie-in CONFIG option, which I have > not done here as I feel that's adding extra hurdles to something that > must already be opt-in. Given that today many of the immediate uses are > for "pre-boot" application of overlays (SoM + carrier + add-ons or EVM + > LCD for example), I believe this is an acceptable trade-off to make > currently. If I understand correctly, then you are following Rob's suggestion of passing the DTC_EXTRA_FLAGS value in the dtb make command. That seems to be a reasonable approach for now. Rob did mention that he would like to remove the current hard coding of a base DTC_FLAGS value, where several architectures initialize it with one of: DTC_FLAGS ?= -p 1024 DTC_FLAGS := -p 1024 If those initializations can be removed, then we could just use DTC_FLAGS in the make command, instead of adding DTC_EXTRA_FLAGS. Can you discuss that option with Rob? (Sorry Rob, I'll be off-grid soon.) > --- > scripts/Makefile.lib | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 58c05e5d9870..04434ffe3370 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -293,7 +293,7 @@ DTC_FLAGS += -Wnode_name_chars_strict \ > -Wproperty_name_chars_strict > endif > > -DTC_FLAGS += $(DTC_FLAGS_$(basetarget)) > +DTC_FLAGS += $(DTC_FLAGS_$(basetarget)) $(DTC_EXTRA_FLAGS) > > # Generate an assembly file to wrap the output of the device tree compiler > quiet_cmd_dt_S_dtb= DTB $@ >
On Wed, Aug 16, 2017 at 11:32:08PM -0700, Frank Rowand wrote: > Hi Tom, > > Some nit picking on the patch comment. :-) > > > On 08/16/17 17:35, Tom Rini wrote: > > This introduces the variabe DTC_EXTRA_FLAGS to allow for additional > > flags to be passed to dtc. While this can have many uses (such as > > easier testing of new warning flags) the use case I wish to spell out > > here is passing of -@ to enable __symbols__ to be included in the > > resulting dtb and thus 'stacked' overlays to be able to be used. > > Not just stacked overlays (I'm guessing by that you mean an > overlay applied on top of an overlay), but even an overlay on > top of the base dtb. In the case of outside of the kernel, we can today have some classes of overlays that work today. "Stacked" is how Pantelis has been referring to overlays that make use of __symbols__ so that we can resolve references. I guess this ended up being referenced as plugin support in dtc.git tho? I'm not quite sure how to re-word the above to be clear that it's extending what can be used. > > When passing in -@ this will increase the size of the dtb (and resident > > memory usage) in exchange for allowing more types of overlays to be > > applied to the dtb file prior to passing it to Linux and additional > > functionality within the kernel when OF_OVERLAY is enabled and in tools > > outside of the kernel. > > Not so much additional functionality within the kernel. It is basic > functionality for any overlay to be applied in the kernel. Oh, I thought the kernel already handled using that information. I'll think how to reword the line there then. > > Cc: Jason Kridner <jkridner@beagleboard.org> > > Cc: Drew Fustini <drew@beagleboard.org> > > Cc: Robert Nelson <robertcnelson@gmail.com> > > Cc: Lokesh Vutla <lokeshvutla@ti.com> > > Cc: Frank Rowand <frowand.list@gmail.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Mark Rutland <mark.rutland@arm.com> > > Cc: Russell King <linux@armlinux.org.uk> > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > > Cc: Michal Marek <mmarek@suse.com> > > CC: linux-kbuild@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Tom Rini <trini@konsulko.com> > > --- > > This would be v3 of my attempt to enable __symbols__ more widely (v2, > > for people not on the CC, enabled it always, but for some boards). > > > > To be clear, this version of the patch is more flexible in that it > > allows for arbitrary flags to be passed to dtc, which can have other > > uses. But, I'm still spelling out -@ being the motivation behind this > > for clarity. > > Thank you, that is very useful info to capture in the commit history. > > > > Both Frank and Rob were uncomfortable with v2, and Frank > > suggested this approach to make it easier for users / distributions / > > etc to opt-in to this functionality. For clarity, Frank was suggesting > > (at least at first) perhaps also a tie-in CONFIG option, which I have > > not done here as I feel that's adding extra hurdles to something that > > must already be opt-in. Given that today many of the immediate uses are > > for "pre-boot" application of overlays (SoM + carrier + add-ons or EVM + > > LCD for example), I believe this is an acceptable trade-off to make > > currently. > > If I understand correctly, then you are following Rob's suggestion of > passing the DTC_EXTRA_FLAGS value in the dtb make command. > > That seems to be a reasonable approach for now. Rob did mention that > he would like to remove the current hard coding of a base DTC_FLAGS > value, where several architectures initialize it with one of: > > DTC_FLAGS ?= -p 1024 > DTC_FLAGS := -p 1024 > > If those initializations can be removed, then we could just use > DTC_FLAGS in the make command, instead of adding DTC_EXTRA_FLAGS. > Can you discuss that option with Rob? (Sorry Rob, I'll be off-grid > soon.) With respect to the current users of DTC_FLAGS, we could just change c6x / microblaze / openrisc / powerpc to use '+=' not '?=' or ':=' as one-line patches, from a quick test on microblaze. Or maybe I'm missing something? But we can't only pass DTC_FLAGS on the command-line directly, unless we also pass in all other valid and normal flags (ie -Wno-unit_address_vs_reg). This is in-line with how for example CFLAGS is handled in the kernel, rather than by what, based on some googling, Makefiles can be made to do, in general. Thanks!
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 58c05e5d9870..04434ffe3370 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -293,7 +293,7 @@ DTC_FLAGS += -Wnode_name_chars_strict \ -Wproperty_name_chars_strict endif -DTC_FLAGS += $(DTC_FLAGS_$(basetarget)) +DTC_FLAGS += $(DTC_FLAGS_$(basetarget)) $(DTC_EXTRA_FLAGS) # Generate an assembly file to wrap the output of the device tree compiler quiet_cmd_dt_S_dtb= DTB $@
This introduces the variabe DTC_EXTRA_FLAGS to allow for additional flags to be passed to dtc. While this can have many uses (such as easier testing of new warning flags) the use case I wish to spell out here is passing of -@ to enable __symbols__ to be included in the resulting dtb and thus 'stacked' overlays to be able to be used. When passing in -@ this will increase the size of the dtb (and resident memory usage) in exchange for allowing more types of overlays to be applied to the dtb file prior to passing it to Linux and additional functionality within the kernel when OF_OVERLAY is enabled and in tools outside of the kernel. Cc: Jason Kridner <jkridner@beagleboard.org> Cc: Drew Fustini <drew@beagleboard.org> Cc: Robert Nelson <robertcnelson@gmail.com> Cc: Lokesh Vutla <lokeshvutla@ti.com> Cc: Frank Rowand <frowand.list@gmail.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Michal Marek <mmarek@suse.com> CC: linux-kbuild@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Tom Rini <trini@konsulko.com> --- This would be v3 of my attempt to enable __symbols__ more widely (v2, for people not on the CC, enabled it always, but for some boards). To be clear, this version of the patch is more flexible in that it allows for arbitrary flags to be passed to dtc, which can have other uses. But, I'm still spelling out -@ being the motivation behind this for clarity. Both Frank and Rob were uncomfortable with v2, and Frank suggested this approach to make it easier for users / distributions / etc to opt-in to this functionality. For clarity, Frank was suggesting (at least at first) perhaps also a tie-in CONFIG option, which I have not done here as I feel that's adding extra hurdles to something that must already be opt-in. Given that today many of the immediate uses are for "pre-boot" application of overlays (SoM + carrier + add-ons or EVM + LCD for example), I believe this is an acceptable trade-off to make currently. --- scripts/Makefile.lib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)