From patchwork Sun Aug 20 05:55:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Donglin Peng X-Patchwork-Id: 9910953 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 89A54601D4 for ; Sun, 20 Aug 2017 05:56:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 788B0288DA for ; Sun, 20 Aug 2017 05:56:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D2AE28905; Sun, 20 Aug 2017 05:56:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_HTTP, RCVD_IN_SORBS_SOCKS autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1B32C288DA for ; Sun, 20 Aug 2017 05:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=MOMuZ5p2IsiTm8+u6Cn3jDvIBkzwIuT0UpqzgyC2LzI=; b=hQ0 nX6NDlWKKLY2oL7wq+V+WFp1ZQDZH0eQWP0T+MaVP+8OzanL4mTbrSBuKqi8hTPlI7+Qm6cnCT82S oTY2lw6ThLVHx4uZ/I9dc5GtLfJhYe5Q6+ydHfv3ffLacybSyTtKWJjI1Ud9VjjiUN/oIAdi5ldf4 3kYcQ8XdLzOn/kd6iRG6KGKgXtiE9LWZQ5XoeRf1PB/FVytixQ4qj3Pfv2FC63Dap/aQXGwd8ieEq KynZO3jYnWRGZFIf4OQNwI+gKfYrdE4baHeqO5udy2UFnK/xAnc+NZKbQ8yixrtkFcaFElQIKILwH UAISlRKVFOx+yOct24x95aROMrmXikw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1djJD5-0004FX-01; Sun, 20 Aug 2017 05:55:43 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1djJD1-0004Dr-Kx for linux-arm-kernel@lists.infradead.org; Sun, 20 Aug 2017 05:55:41 +0000 Received: by mail-pf0-x242.google.com with SMTP id h75so3932266pfh.5 for ; Sat, 19 Aug 2017 22:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=9MQ4toGIg5PlBuI36O++PhqzJpXFVRChibNH4/e0CmE=; b=umZC4PZXPzBnD9uSTqn8pgFcDr74wwVBoew6vO7ieH7ZnSPCtbFQ33bZJm+4GsWRYZ lKOvhi3RWBHwJEsdo0oUYWYrJGvJXj7GNru+yRaYtaNOltbcOMYIyjAwRf3UWoubUpHY DXyK9511i9CaTeV/dwTkAxEIjCyEwyAseL0AzxWNACSKP23wZAhrLausrv5fQi958aCp naY4yHpAdnx7d9sXBnT9SYAawbH5RN8djicx4iy9H+89eMbo3ucgUGju6J+pA9nHRGn0 DPsKyHO6+X+reQEHY9DPFdj66fq94h5TfC7f3p+LNkFHcEbEyqlemOnNVzVZqBQWr3k+ 9w/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9MQ4toGIg5PlBuI36O++PhqzJpXFVRChibNH4/e0CmE=; b=B7WY0AtUFJtr8u9HvPWKfxdQGQgTsgcI0+l6O50VxJp15lU943ya4ybbdVcCzBL6ul 4lBKR6zWTUD4gMFnd2I+U8jWhC8ifAjezqzGz+cscQDpO5JR6gcrBUKRszMK2WUUm+9h 32YGQvOvngjfiMk2WUCoBaERQNun4U/v7bkMhw1ClBfr8DUOA4zRUu2ZJomndybG/XYt hSixbWpMW3LndNERWqmHaPniRSDWSHTqcvtGP1O9WSm6OgSyf4Up2jA5oxOOwvRzr0tz p1cD7aqzcBisJmhlmSRd2jh3OD2u0qC2zdDRatEe0MkjjpDaV+okfYrW3sPUL1w1HhJx 5WOQ== X-Gm-Message-State: AHYfb5gCaeKUMPzrRdpjdFw3d1M79LZf8IXSU2kNtJWgbuqBqFRu7es4 uO3PCpqN7epntw== X-Received: by 10.84.210.171 with SMTP id a40mr14928682pli.443.1503208518906; Sat, 19 Aug 2017 22:55:18 -0700 (PDT) Received: from localhost ([221.217.218.132]) by smtp.gmail.com with ESMTPSA id w63sm17713755pfw.28.2017.08.19.22.55.17 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 19 Aug 2017 22:55:18 -0700 (PDT) From: Peng Donglin To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, maxime.ripard@free-electrons.com Subject: [PATCH 10/12] ASoC: sun4i-codec: Remove unnecessary function call Date: Sun, 20 Aug 2017 13:55:13 +0800 Message-Id: <1503208513-4015-1-git-send-email-dolinux.peng@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170819_225539_744961_6B0C7422 X-CRM114-Status: UNSURE ( 8.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Donglin MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP First of all,the address of pdev->dev is assigned to card->dev in create_card,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed. Signed-off-by: Peng Donglin --- sound/soc/sunxi/sun4i-codec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index 1500699..82beeae 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -1655,7 +1655,6 @@ static int sun4i_codec_probe(struct platform_device *pdev) goto err_unregister_codec; } - platform_set_drvdata(pdev, card); snd_soc_card_set_drvdata(card, scodec); ret = snd_soc_register_card(card);