From patchwork Wed Aug 23 04:56:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 9916583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0E11B60327 for ; Wed, 23 Aug 2017 04:58:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2C7328864 for ; Wed, 23 Aug 2017 04:58:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E78DA28954; Wed, 23 Aug 2017 04:58:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6D77B28864 for ; Wed, 23 Aug 2017 04:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=NPZdv7bTwGjiE0OVFnK8vEFrkT7QcLDNDT7Jrg2y4Jc=; b=dG7So+LSA8EoyiXYQjeUJWSHc/ 8iZ3/gWi+kBtiGsD79196wjtn1cyrhg5zVMIe9gVCaRfLdDZCIiTUpUXzTDcPuJYbxj1W1Y9VZMEI f+rqHpNAypRBsH7lSI6b9Zc9Uhobh+IqRMMpr4BLxM9EHEgxWWKFo9PE2jIISyPpHR3YdKjs71X2h 782g8axsXxs5aVz5qYvdlp128OEKsO9QdikMHoN6EWuEUSZdvxC7UI0hym4SIc5F3iD/ML1BQlCNW ptU6Ro03XuCvrNQ/7nBpju+Kk/1+pr77BhRyQP4nsMNV1e/U8KCETWo8UXe+wnDLZ/FT0LkcdWACx EkE2lF0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dkNk0-0003oV-Rv; Wed, 23 Aug 2017 04:58:08 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dkNiX-0002HN-Ea for linux-arm-kernel@lists.infradead.org; Wed, 23 Aug 2017 04:56:42 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A5F6F60712; Wed, 23 Aug 2017 04:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503464179; bh=EkSQrPrJfWIbM7IEsRU9zoEO8mN40PLlCT8rmYfe65w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fjz7jZDme9/dH+4JSyXV2ECHQka4ys9BFu03uoIVbNXIQXD92L/aoToPzMPknPxmT nD+CdsKHdgAeIAEWJZQzrZvynt0psv1gI1Abfb9Ybz5wByryMUi82ZIoEIqmsHcO5y MAJZLkq7iTMArkJiijT/PQblCAm5n4wYLjKwG/u8= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 09F2C6070B; Wed, 23 Aug 2017 04:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503464178; bh=EkSQrPrJfWIbM7IEsRU9zoEO8mN40PLlCT8rmYfe65w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YUvnAnIIGt+zJDHBfy/ByvMJNwnApE1+Jyb6lUWFNC24FkXxiEql6fVc2zaZBfLcn OP7ChU8ky8uGuZJDo3sZ1O120sYUkMg/O0DuEol/wN1szk91kpmH4/4t5RyrynCm8B aKC4dJ2pFJm68k/uaYrLG25c2y2nmNAkFd+jz3Jk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 09F2C6070B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org, timur@codeaurora.org, alex.williamson@redhat.com Subject: [PATCH V12 3/5] PCI: Factor out pci_bus_wait_crs() Date: Wed, 23 Aug 2017 00:56:09 -0400 Message-Id: <1503464171-6471-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1503464171-6471-1-git-send-email-okaya@codeaurora.org> References: <1503464171-6471-1-git-send-email-okaya@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170822_215637_698418_FB7E8458 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sinan Kaya , linux-arm-msm@vger.kernel.org, Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Configuration Request Retry Status (CRS) was previously hidden inside pci_bus_read_dev_vendor_id(). We want to add support for CRS in other situations, such as waiting for a device to become ready after a Function Level Reset. Move CRS handling into pci_bus_wait_crs() so it can be called from other places. Signed-off-by: Sinan Kaya --- drivers/pci/pci.h | 1 + drivers/pci/probe.c | 46 ++++++++++++++++++++++++++++------------------ 2 files changed, 29 insertions(+), 18 deletions(-) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 7fa583a..56d2515 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -239,6 +239,7 @@ static inline bool pci_bus_crs_visibility_pending(u32 l) { return (l & 0xffff) == 0x0001; } +bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 l, int timeout); bool pci_bus_read_dev_vendor_id(struct pci_bus *bus, int devfn, u32 *pl, int crs_timeout); int pci_setup_device(struct pci_dev *dev); diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 2849e0e..93b89dd 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1824,30 +1824,23 @@ struct pci_dev *pci_alloc_dev(struct pci_bus *bus) } EXPORT_SYMBOL(pci_alloc_dev); -bool pci_bus_read_dev_vendor_id(struct pci_bus *bus, int devfn, u32 *l, - int crs_timeout) +bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 l, int timeout) { int delay = 1; - if (pci_bus_read_config_dword(bus, devfn, PCI_VENDOR_ID, l)) - return false; + if ((l & 0xffff) != 0x0001) + return true; /* not a CRS completion */ - /* some broken boards return 0 or ~0 if a slot is empty: */ - if (*l == 0xffffffff || *l == 0x00000000 || - *l == 0x0000ffff || *l == 0xffff0000) - return false; + if (!timeout) + return false; /* CRS, but caller doesn't want to wait */ /* - * Configuration Request Retry Status. Some root ports return the - * actual device ID instead of the synthetic ID (0xFFFF) required - * by the PCIe spec. Ignore the device ID and only check for - * (vendor id == 1). + * We got the reserved Vendor ID that indicates a completion with + * Configuration Request Retry Status (CRS). Retry until we get a + * valid Vendor ID or we time out. */ - while ((*l & 0xffff) == 0x0001) { - if (!crs_timeout) - return false; - - if (delay > crs_timeout) { + while ((l & 0xffff) == 0x0001) { + if (delay > timeout) { printk(KERN_WARNING "pci %04x:%02x:%02x.%d: not responding\n", pci_domain_nr(bus), bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn)); @@ -1857,12 +1850,29 @@ bool pci_bus_read_dev_vendor_id(struct pci_bus *bus, int devfn, u32 *l, msleep(delay); delay *= 2; - if (pci_bus_read_config_dword(bus, devfn, PCI_VENDOR_ID, l)) + if (pci_bus_read_config_dword(bus, devfn, PCI_VENDOR_ID, &l)) return false; } return true; } + +bool pci_bus_read_dev_vendor_id(struct pci_bus *bus, int devfn, u32 *l, + int timeout) +{ + if (pci_bus_read_config_dword(bus, devfn, PCI_VENDOR_ID, l)) + return false; + + /* some broken boards return 0 or ~0 if a slot is empty: */ + if (*l == 0xffffffff || *l == 0x00000000 || + *l == 0x0000ffff || *l == 0xffff0000) + return false; + + if (pci_bus_crs_visibility_pending(*l)) + return pci_bus_wait_crs(bus, devfn, *l, timeout); + + return true; +} EXPORT_SYMBOL(pci_bus_read_dev_vendor_id); /*