From patchwork Thu Aug 24 07:21:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan Ramabadhran X-Patchwork-Id: 9919241 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 370C660353 for ; Thu, 24 Aug 2017 07:25:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 285F62885B for ; Thu, 24 Aug 2017 07:25:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1CFDA28A48; Thu, 24 Aug 2017 07:25:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7EEAD2885B for ; Thu, 24 Aug 2017 07:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=K/B1VXphPexYZDfjQP2Hs8zsiP/yvYe2F0QvLIUaekQ=; b=q2UR5/g3nIutWwyg7RRRA0cGr7 9GdbgGXcp47D47Jm2uaqcOwBu+SsikazD5G+UUyP2kJ0yrAFIG6+FK5PNrxoDafMI4nuHYpeFnYqD x6JOwbNJflHT/rkb/aH4XUCe1ri+iBCwxdHsZpBkNn3GlYQgvIvcG41Ru8gne9UUK6KJ2rxaSRS1/ gHTgpCzQA4ZAPVz7qt3+yaoIqZzi05vrKM5U1vJGeAjPjufMYJA0fZbifgZ//xAW6uPjlThmdB3fX DjckfWAUAy9bmN/wdGHpFpW6jzDVdAspMFb8oVMVaS7cfR3+0ZAArRvgiq/Uatk3yCs5lgiAPKn5t DTB6OTyw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dkmWI-0003in-7V; Thu, 24 Aug 2017 07:25:38 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dkmU1-0000EU-MQ for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2017 07:24:14 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7AEE860729; Thu, 24 Aug 2017 07:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503559381; bh=YrGKZo2jZ+2aZwRAxmY8XypfIKNeS/xVjYFd9yrg+vE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NvuNAnYEz0tnisP7gm62E7xc7DqwHoUOv+QPZR0dSsxCpFf1uA0M+MioTg81/Pgy7 S2z9f7NkejPrpj+5cO/9RYZSfoqX9+Maz9yi85LHk2+bVmWMUPccmRioNxUE9FeG3I OhFcdtMgj91ZU2lrPX3K7Gt7197zkWGq161Ezm+Y= Received: from srichara-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5321B6080A; Thu, 24 Aug 2017 07:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503559373; bh=YrGKZo2jZ+2aZwRAxmY8XypfIKNeS/xVjYFd9yrg+vE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mO9hOCvIhvk8ZHrp8pLFm2WmVkg3z7sowZ2i69IW3sMn3kEoK1hsPqqR8i0stmlQ8 0JwQLbQdoRkCLX7vPEJLca3yh5HdoWaWVYdRqAcAuuNRSxlLPCekMnqe2bUFEZwDD4 Qjpk0niDdUCr6c5d4St59e0djeBbBeEso60c81hU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5321B6080A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org From: Sricharan R To: ohad@wizery.com, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 19/20] rpmsg: glink: Request for intents when unavailable Date: Thu, 24 Aug 2017 12:51:41 +0530 Message-Id: <1503559302-3744-20-git-send-email-sricharan@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1503559302-3744-1-git-send-email-sricharan@codeaurora.org> References: <1503559302-3744-1-git-send-email-sricharan@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170824_002318_493656_BA1FCDDC X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sricharan@codeaurora.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP While sending data, we search for suitable sized intent to map and simply fail if a intent is not found. Instead request for a intent of required size and wait till one is alloted. Signed-off-by: Sricharan R Signed-off-by: Bjorn Andersson --- drivers/rpmsg/qcom_glink_native.c | 76 +++++++++++++++++++++++++++++++++++++-- 1 file changed, 74 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 163c082..54ddb66 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -149,6 +149,9 @@ enum { * @buf_size: size of current @buf * @open_ack: completed once remote has acked the open-request * @open_req: completed once open-request has been received + * @intent_req_lock: Synchronises multiple intent requests + * @intent_req_result: Result of intent request + * @intent_req_comp: Completion for intent_req signalling */ struct glink_channel { struct rpmsg_endpoint ept; @@ -176,6 +179,10 @@ struct glink_channel { struct completion open_ack; struct completion open_req; + + struct mutex intent_req_lock; + bool intent_req_result; + struct completion intent_req_comp; }; #define to_glink_channel(_ept) container_of(_ept, struct glink_channel, ept) @@ -342,6 +349,24 @@ static void qcom_glink_send_open_ack(struct qcom_glink *glink, qcom_glink_tx(glink, &msg, sizeof(msg), NULL, 0, true); } +static void qcom_glink_handle_intent_req_ack(struct qcom_glink *glink, + unsigned int cid, bool granted) +{ + struct glink_channel *channel; + unsigned long flags; + + spin_lock_irqsave(&glink->idr_lock, flags); + channel = idr_find(&glink->rcids, cid); + spin_unlock_irqrestore(&glink->idr_lock, flags); + if (!channel) { + dev_err(glink->dev, "unable to find channel\n"); + return; + } + + channel->intent_req_result = granted; + complete(&channel->intent_req_comp); +} + /** * qcom_glink_send_open_req() - send a RPM_CMD_OPEN request to the remote * @glink: Ptr to the glink edge @@ -940,6 +965,10 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data) case RPM_CMD_INTENT: qcom_glink_handle_intent(glink, param1, param2, avail); break; + case RPM_CMD_RX_INTENT_REQ_ACK: + qcom_glink_handle_intent_req_ack(glink, param1, param2); + qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); + break; default: qcom_glink_rx_advance(glink, ALIGN(sizeof(msg), 8)); dev_err(glink->dev, "unhandled rx cmd: %d\n", cmd); @@ -1106,6 +1135,42 @@ static void qcom_glink_destroy_ept(struct rpmsg_endpoint *ept) qcom_glink_send_close_req(glink, channel); } +static int qcom_glink_request_intent(struct qcom_glink *glink, + struct glink_channel *channel, + size_t size) +{ + struct { + u16 id; + u16 cid; + u32 size; + } __packed cmd; + + int ret; + + mutex_lock(&channel->intent_req_lock); + + reinit_completion(&channel->intent_req_comp); + + cmd.id = RPM_CMD_RX_INTENT_REQ; + cmd.cid = channel->lcid; + cmd.size = size; + + ret = qcom_glink_tx(glink, &cmd, sizeof(cmd), NULL, 0, true); + if (ret) + return ret; + + ret = wait_for_completion_timeout(&channel->intent_req_comp, 10 * HZ); + if (!ret) { + dev_err(glink->dev, "intent request timed out\n"); + ret = -ETIMEDOUT; + } else { + ret = channel->intent_req_result ? 0 : -ECANCELED; + } + + mutex_unlock(&channel->intent_req_lock); + return ret; +} + static int __qcom_glink_send(struct glink_channel *channel, void *data, int len, bool wait) { @@ -1122,7 +1187,7 @@ static int __qcom_glink_send(struct glink_channel *channel, unsigned long flags; if (!glink->intentless) { - if (!intent) { + while (!intent) { spin_lock_irqsave(&channel->intent_lock, flags); idr_for_each_entry(&channel->riids, tmp, iid) { if (tmp->size >= len && !tmp->in_use) { @@ -1134,8 +1199,15 @@ static int __qcom_glink_send(struct glink_channel *channel, spin_unlock_irqrestore(&channel->intent_lock, flags); /* We found an available intent */ - if (!intent) + if (intent) + break; + + if (!wait) return -EBUSY; + + ret = qcom_glink_request_intent(glink, channel, len); + if (ret < 0) + return ret; } iid = intent->id;