diff mbox

arm: omap: dra7xx: Set OPT_CLKS_IN_RESET flag for gpio1

Message ID 1504694038-32159-1-git-send-email-j-keerthy@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

J, KEERTHY Sept. 6, 2017, 10:33 a.m. UTC
gpio1 soft reset fails in the kexec path as the optional clock
is not enabled hence enable the HWMOD_CONTROL_OPT_CLKS_IN_RESET
flag for gpio1 hwmod.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 1 +
 1 file changed, 1 insertion(+)

Comments

J, KEERTHY Sept. 18, 2017, 11:39 a.m. UTC | #1
On Wednesday 06 September 2017 04:03 PM, Keerthy wrote:
> gpio1 soft reset fails in the kexec path as the optional clock
> is not enabled hence enable the HWMOD_CONTROL_OPT_CLKS_IN_RESET
> flag for gpio1 hwmod.

A gentle ping on this as well.

> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 7cc3247..6ae729a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1037,6 +1037,7 @@ struct omap_hwmod dra7xx_sha0_hwmod = {
>  	.name		= "gpio1",
>  	.class		= &dra7xx_gpio_hwmod_class,
>  	.clkdm_name	= "wkupaon_clkdm",
> +	.flags		= HWMOD_CONTROL_OPT_CLKS_IN_RESET,
>  	.main_clk	= "wkupaon_iclk_mux",
>  	.prcm = {
>  		.omap4 = {
>
Tony Lindgren Sept. 19, 2017, 5:44 p.m. UTC | #2
* Keerthy <j-keerthy@ti.com> [170918 04:40]:
> 
> 
> On Wednesday 06 September 2017 04:03 PM, Keerthy wrote:
> > gpio1 soft reset fails in the kexec path as the optional clock
> > is not enabled hence enable the HWMOD_CONTROL_OPT_CLKS_IN_RESET
> > flag for gpio1 hwmod.
> 
> A gentle ping on this as well.

With v4.14-rc1 now out, applying into omap-for-v4.14/fixes.
I usually don't start applying fixes during the merge window
unless really needed.

Regards,

Tony


> > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > ---
> >  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > index 7cc3247..6ae729a 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > @@ -1037,6 +1037,7 @@ struct omap_hwmod dra7xx_sha0_hwmod = {
> >  	.name		= "gpio1",
> >  	.class		= &dra7xx_gpio_hwmod_class,
> >  	.clkdm_name	= "wkupaon_clkdm",
> > +	.flags		= HWMOD_CONTROL_OPT_CLKS_IN_RESET,
> >  	.main_clk	= "wkupaon_iclk_mux",
> >  	.prcm = {
> >  		.omap4 = {
> >
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 7cc3247..6ae729a 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -1037,6 +1037,7 @@  struct omap_hwmod dra7xx_sha0_hwmod = {
 	.name		= "gpio1",
 	.class		= &dra7xx_gpio_hwmod_class,
 	.clkdm_name	= "wkupaon_clkdm",
+	.flags		= HWMOD_CONTROL_OPT_CLKS_IN_RESET,
 	.main_clk	= "wkupaon_iclk_mux",
 	.prcm = {
 		.omap4 = {