| Message ID | 1504729681-3504-5-git-send-email-deller@gmx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 20:27-20170906, Helge Deller wrote: > Use the %pS printk format for printing symbols from direct addresses. > This is important for the ia64, ppc64 and parisc64 architectures, while on > other architectures there is no difference between %pS and %pF. > Fix it for consistency across the kernel. > > Signed-off-by: Helge Deller <deller@gmx.de> > Cc: Nishanth Menon <nm@ti.com> > Cc: Tero Kristo <t-kristo@ti.com> > Cc: Santosh Shilimkar <ssantosh@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org OK with me. Thanks for doing the patch. Acked-by: Nishanth Menon <nm@ti.com> Santosh, Tero: maybe queue for an rc or later cycle, I think? [...]
On 9/8/2017 4:30 PM, Nishanth Menon wrote: > On 20:27-20170906, Helge Deller wrote: >> Use the %pS printk format for printing symbols from direct addresses. >> This is important for the ia64, ppc64 and parisc64 architectures, while on >> other architectures there is no difference between %pS and %pF. >> Fix it for consistency across the kernel. >> >> Signed-off-by: Helge Deller <deller@gmx.de> >> Cc: Nishanth Menon <nm@ti.com> >> Cc: Tero Kristo <t-kristo@ti.com> >> Cc: Santosh Shilimkar <ssantosh@kernel.org> >> Cc: linux-arm-kernel@lists.infradead.org > > OK with me. Thanks for doing the patch. > Acked-by: Nishanth Menon <nm@ti.com> > > Santosh, Tero: maybe queue for an rc or later cycle, I think? > Doesn't look a rc type fix so can wait for next one.
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index 00cfed3..23b12d9 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -439,7 +439,7 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info, /* And we wait for the response. */ timeout = msecs_to_jiffies(info->desc->max_rx_timeout_ms); if (!wait_for_completion_timeout(&xfer->done, timeout)) { - dev_err(dev, "Mbox timedout in resp(caller: %pF)\n", + dev_err(dev, "Mbox timedout in resp(caller: %pS)\n", (void *)_RET_IP_); ret = -ETIMEDOUT; }
Use the %pS printk format for printing symbols from direct addresses. This is important for the ia64, ppc64 and parisc64 architectures, while on other architectures there is no difference between %pS and %pF. Fix it for consistency across the kernel. Signed-off-by: Helge Deller <deller@gmx.de> Cc: Nishanth Menon <nm@ti.com> Cc: Tero Kristo <t-kristo@ti.com> Cc: Santosh Shilimkar <ssantosh@kernel.org> Cc: linux-arm-kernel@lists.infradead.org --- drivers/firmware/ti_sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)