From patchwork Fri Sep 8 14:52:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 9944435 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 900526034B for ; Fri, 8 Sep 2017 14:53:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BDF2287B5 for ; Fri, 8 Sep 2017 14:53:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80A0F287C0; Fri, 8 Sep 2017 14:53:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 12443287B5 for ; Fri, 8 Sep 2017 14:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PCebfr1yIMsqhXY6DZz0pSEDCMhA8x+3Z8X4bJl0TB0=; b=UWbxd9bay7DAAxouvrNfYSuFs4 jUUl4SkwawPUo9Q4/iUBfUnt5aSwi94295Z8L5PvHryHwYw4OWML6bJgT3vmcxCxaavxrs2JS2yyd MDwSrVggHZJHh0K8iqtr7KzFEemLhft+ms4Nq1/Kxe2HV81poShifjhQop3F3xSnC9xGNyJ4inJ0k +0WjoGii1sut6X/neLG+mwAFI865MRlxpscWAVW7YykCliVAa5m7FOhwRe2W9ygOAUthPCQqZzlkY hs9mlCqcIuHf0/xaNPOA5s+buoDxUIxqHv9prP1UBM//EkuQDwyvLmkqgTNpxmuZdjT3j2qZm38rL yVKgpU7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dqKf2-0001se-Lt; Fri, 08 Sep 2017 14:53:36 +0000 Received: from mail-pg0-x230.google.com ([2607:f8b0:400e:c05::230]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dqKeq-0001aj-OI for linux-arm-kernel@lists.infradead.org; Fri, 08 Sep 2017 14:53:29 +0000 Received: by mail-pg0-x230.google.com with SMTP id t3so5258982pgt.0 for ; Fri, 08 Sep 2017 07:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1Jvt3nCV8oCdNhAbqAoxe0IFV9buoRpBtQfqpcn/iBY=; b=V2IC8AnXZiXuXNkz3eCAebscAqCId05mBLQBZ3xzRURQVAkLOvBujHFECMrBc86w8H c/aOTPn1m9/10JoSIn/OCnM5snmiuvXrDzEakI6LuWU+RRxLvLf1iMEI9aRh67+IZJMI Tz65FCYTZoayFko1TNGgAItdfI0c58untLqyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1Jvt3nCV8oCdNhAbqAoxe0IFV9buoRpBtQfqpcn/iBY=; b=iOh//ye0vZCvoJFhxPoqqFqFbk/5rn1VgnsF6odEwt78A5bz45bLTJXOyGAwnCbres JIZ6ZhCdIK77jPk3PFg6VpCrGJUz1axU/394K7bscbtcxhZ85Kna7FRYILKVW4HzG66R O8BTwcFuRGljj0E2IMPPwmEmoNvAZExf6Zq5iC4vWpR9qEufj6Z2OlLQ+DFGydnfxA7G G9NU0yMc6hY6mvohCIoW3d9VJvzOZkTET36owx7qiCrjXHmsowWuuYP5h19mDKJTU3I6 D+c5TJ84vy/34mETGJ9CvD4nzXfzcRfPOvDKxcAl85WGgRCFIxichARpvrLsct2ljKLc 0MTA== X-Gm-Message-State: AHPjjUhkgBg74Zx5OtD7B8m7FCgpKzSPvGq3F/EMgfT4sNkr/l7miF9U x07YpFMfug1aewmG X-Google-Smtp-Source: ADKCNb7pwPO1UVpCcRb+qlZcBbrPXtx8Mkb0LPFYZ5BsEswjVdhDCA0dPPEMMhrMtUwHOyegVNzxng== X-Received: by 10.99.117.30 with SMTP id q30mr3485053pgc.106.1504882383953; Fri, 08 Sep 2017 07:53:03 -0700 (PDT) Received: from localhost.localdomain ([104.153.224.169]) by smtp.gmail.com with ESMTPSA id x189sm4258160pfx.188.2017.09.08.07.52.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Sep 2017 07:53:03 -0700 (PDT) From: Christoffer Dall To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] KVM: arm/arm64: Remove redundant preemptible checks Date: Fri, 8 Sep 2017 07:52:18 -0700 Message-Id: <1504882339-42520-2-git-send-email-christoffer.dall@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504882339-42520-1-git-send-email-christoffer.dall@linaro.org> References: <1504882339-42520-1-git-send-email-christoffer.dall@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170908_075325_394312_BB7E1336 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Christoffer Dall , hemk976@gmail.com, Jintack Lim , kvm@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Christoffer Dall The __this_cpu_read() and __this_cpu_write() functions already implement checks for the required preemption levels when using CONFIG_DEBUG_PREEMPT which gives you nice error messages and such. Therefore there is no need to explicitly check this using a BUG_ON() in the code (which we don't do for other uses of per cpu variables either). Signed-off-by: Christoffer Dall --- virt/kvm/arm/arm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index a39a1e1..04313a2 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -69,7 +69,6 @@ static DEFINE_PER_CPU(unsigned char, kvm_arm_hardware_enabled); static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu) { - BUG_ON(preemptible()); __this_cpu_write(kvm_arm_running_vcpu, vcpu); } @@ -79,7 +78,6 @@ static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu) */ struct kvm_vcpu *kvm_arm_get_running_vcpu(void) { - BUG_ON(preemptible()); return __this_cpu_read(kvm_arm_running_vcpu); }