From patchwork Tue Oct 3 03:11:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jintack Lim X-Patchwork-Id: 9981601 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9F701602B8 for ; Tue, 3 Oct 2017 03:28:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FE33285EE for ; Tue, 3 Oct 2017 03:28:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8485D28798; Tue, 3 Oct 2017 03:28:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 01362285EE for ; Tue, 3 Oct 2017 03:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=r+beYuAWprIBVYshALMJatIkihl1hI4o3ZlF+PFTbd0=; b=hxjU4CO4X632urWl+in/Xx0JIc ne+eeQwa3poGWSiTCR8VGmRGXPGuV4hiur3RcO2KeaWbD8PfA33iWp2wK2yR+b6niJWDIIoZEPesb ajUmWEvBIQJeTkvgYhz/9aIYQ78vCse5AJpx38SvRSgDSxbECYFNbh0p+D/Ck/zc3c5Kcu2YSOJZC FzqU49FeLEvlOXRyUCQppOW2diMpSiLr0qSwRYKMFOhgsAVxxBVxz+0OJkLwYzq21n2KXDq7FnnBR 8l0u1bL42RyBZ3buTkX74x0rS04C3arI1PUABVauKDTtYNWjIF7hlBlh+nlNw3sxVK5wkb1QAinS1 mGI4iatQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dzDsq-0006zn-QX; Tue, 03 Oct 2017 03:28:36 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dzDrd-0005U0-Pb for linux-arm-kernel@bombadil.infradead.org; Tue, 03 Oct 2017 03:27:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GwIjgmGyYytntsQMjHz3GfddpVQgMG9v/6siaXcoTCM=; b=Ur0bLtKgn8H2Vf8jyZzbuckQR azjMI9MiDtU7rbdLDFEC+wlLcPlG897qP/wOTQygUJuQJIRHNyx/9zz9x4rKt+2WexDktFnVqEtvZ D7YPskfRenUTXB+biGUGl3BPCbzUe/5cnjHVSFLlTpgAgsIkrU7M6Y+YDX7amc2d+QfUj2XEMQbL3 kK9kzze7NipdYNhwgQkxnKc4no/lrjOn5deIL9v84s68nc4TmDf4uK8zmZQmMOx04cwIJqqZFDAF6 Ms8j7TYDQa40JsVjUCfRe5onmPhEEj8u2f34ZhwrSm2+quHum9Uk+uXKwl9qwyHcmYB1O5ZrddHat zJyla3Z3g==; Received: from mail-it0-x22c.google.com ([2607:f8b0:4001:c0b::22c]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dzDdH-0001vq-7k for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2017 03:12:33 +0000 Received: by mail-it0-x22c.google.com with SMTP id m123so10019049ita.3 for ; Mon, 02 Oct 2017 20:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GwIjgmGyYytntsQMjHz3GfddpVQgMG9v/6siaXcoTCM=; b=CzoltiCdDm/aeN0Vvl9lBSUUwW9Oqtk3oEWMIbeLXEXPDchlaZ+nHJ4ao4HLaN+pJQ HmTKQZL1OX+4RMSCn8KtSk7xU+1aJTH/QjDm8TH7RCVE4DJt4Xgq9dRLWTCSQcH3SGGR IvqOf0c5SFBwiWybpJYS4YXgJrA9xwEU6sAZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GwIjgmGyYytntsQMjHz3GfddpVQgMG9v/6siaXcoTCM=; b=QDEMy8kaDciC7TrECUmqz5CDkFjNznQGfyIsF95Q4RTWqh4kzd8AcdZW85VyE6X6Np /UlQdPe0mH9b7D9MgY0rdOpeE/SCQ1lFCBvMIQCrdmE3qoJVRQcqOsk/+SP7PNrGFfMl PFy7e5m6rNThFHKlEwsI8OYHXH9bk6Oq+uE28Y4HXfDyGrrkOL8DG/7HE0MFVGL+LH46 igQAOX5RCGoc8AZ0vl7/2aHQrXkgydSL5FKRlE0/qPVELa5/GyrhUadc7z2OUfKmdUVh DJ7KUGf0vWvAzUIywjEnq0oxz9wwGweSxUMqJjVRJ6di1Vav5LzYxr5qsUnmiAa+pI6O 99pw== X-Gm-Message-State: AHPjjUgRud3oAZwOid8TEqLqTiGgRHb4tKefxOYqkKo0mv7HvgqrQDxa 43HchlqoIBqICa+JJBWT7pL1NA== X-Google-Smtp-Source: AOwi7QChTBR5scZ6ObkIGr5hmPRlHv8iySR1OZE7/9RR155JVLk2bQhY3K3S5V0DMDYejP7WNGisow== X-Received: by 10.36.83.20 with SMTP id n20mr23810404itb.120.1507000327823; Mon, 02 Oct 2017 20:12:07 -0700 (PDT) Received: from node.jintackl-qv28633.kvmarm-pg0.wisc.cloudlab.us (c220g1-031126.wisc.cloudlab.us. [128.104.222.76]) by smtp.gmail.com with ESMTPSA id h84sm5367193iod.72.2017.10.02.20.12.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Oct 2017 20:12:07 -0700 (PDT) From: Jintack Lim To: christoffer.dall@linaro.org, marc.zyngier@arm.com, kvmarm@lists.cs.columbia.edu Subject: [RFC PATCH v2 26/31] KVM: arm64: Emulate TLBI ALLE1(IS) Date: Mon, 2 Oct 2017 22:11:08 -0500 Message-Id: <1507000273-3735-24-git-send-email-jintack.lim@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1507000273-3735-1-git-send-email-jintack.lim@linaro.org> References: <1507000273-3735-1-git-send-email-jintack.lim@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171003_041231_387151_B806351E X-CRM114-Status: GOOD ( 15.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, kvm@vger.kernel.org, rkrcmar@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, Jintack Lim , pbonzini@redhat.com, jintack@cs.columbia.edu, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP TLBI ALLE1(IS) instruction invalidates all EL1&0 regime stage 1 and 2 TLB entries (on all PEs in the same Inner Shareable domain). To emulate these instructions, we first need to clear all the mappings in the shadow page tables since executing those instructions implies the change of mappings in the stage 2 page tables maintained by the guest hypervisor. We then need to invalidate all EL1&0 regime stage 1 and 2 TLB entries of all VMIDs, which are assigned by the host hypervisor, for this VM. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index a1ae8fb..5a82de9 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch/arm64/kvm/sys_regs.c @@ -1795,6 +1795,31 @@ static bool handle_vae2(struct kvm_vcpu *vcpu, struct sys_reg_params *p, return true; } +static bool handle_alle1is(struct kvm_vcpu *vcpu, struct sys_reg_params *p, + const struct sys_reg_desc *r) +{ + struct kvm_s2_mmu *mmu = &vcpu->kvm->arch.mmu; + u64 vttbr = kvm_get_vttbr(&mmu->vmid, mmu); + + if (vcpu->kvm->arch.mmu.vmid.vmid_gen) { + /* + * Invalidate the stage 1 and 2 TLB entries for the host OS + * in a VM only if there is one. + */ + kvm_call_hyp(__kvm_tlb_flush_vmid, vttbr); + } + + spin_lock(&vcpu->kvm->mmu_lock); + /* + * Clear all mappings in the shadow page tables and invalidate the stage + * 1 and 2 TLB entries via kvm_tlb_flush_vmid_ipa(). + */ + kvm_nested_s2_clear(vcpu->kvm); + spin_unlock(&vcpu->kvm->mmu_lock); + + return true; +} + /* * AT instruction emulation * @@ -1880,14 +1905,14 @@ static bool handle_vae2(struct kvm_vcpu *vcpu, struct sys_reg_params *p, SYS_INSN_TO_DESC(TLBI_IPAS2LE1IS, NULL, NULL), SYS_INSN_TO_DESC(TLBI_ALLE2IS, handle_alle2is, NULL), SYS_INSN_TO_DESC(TLBI_VAE2IS, handle_vae2, NULL), - SYS_INSN_TO_DESC(TLBI_ALLE1IS, NULL, NULL), + SYS_INSN_TO_DESC(TLBI_ALLE1IS, handle_alle1is, NULL), SYS_INSN_TO_DESC(TLBI_VALE2IS, handle_vae2, NULL), SYS_INSN_TO_DESC(TLBI_VMALLS12E1IS, NULL, NULL), SYS_INSN_TO_DESC(TLBI_IPAS2E1, NULL, NULL), SYS_INSN_TO_DESC(TLBI_IPAS2LE1, NULL, NULL), SYS_INSN_TO_DESC(TLBI_ALLE2, handle_alle2, NULL), SYS_INSN_TO_DESC(TLBI_VAE2, handle_vae2, NULL), - SYS_INSN_TO_DESC(TLBI_ALLE1, NULL, NULL), + SYS_INSN_TO_DESC(TLBI_ALLE1, handle_alle1is, NULL), SYS_INSN_TO_DESC(TLBI_VALE2, handle_vae2, NULL), SYS_INSN_TO_DESC(TLBI_VMALLS12E1, NULL, NULL), };