From patchwork Fri Oct 6 04:36:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 9988345 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2FC8D6029B for ; Fri, 6 Oct 2017 04:46:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 18F2C28D68 for ; Fri, 6 Oct 2017 04:46:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0BCFD28D6B; Fri, 6 Oct 2017 04:46:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7865928D68 for ; Fri, 6 Oct 2017 04:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=p/NgqxdP/isy5xrBuygn3eDj3BdPGtkvODsYXiEpoLg=; b=bhiLN0KTsumJAVg6Dme+6KJsZO bLXpWxt4woWbORqBSHzsnLMNJ/ywNMyFgnOyvfS5MrO4Y2ADoqHsU9KUK7ZNQDNVVrFzNAw/vNsiJ d3b4RzK2bQGCtbJ6jaL5Q9uDhA8qZHkI55E2c+5jPNi0/deR2anNYmAxzAF12GdjNL1bstyakSrRC bheHFknb6mJqlZ/PoPFitrBPwE+p+t5CJMd0GlQTuM1t4HDOIkQ9bIB7t0RAcgaRZ2IkoLluMHh75 16aZEdEhlA6n4A/Y0IDleRJT7vvsDz0YK/A4mGq2Izs7equlK6P7aA8O6pV/3AdbRWUHKVUqbueAl fpAVLMtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1e0KWM-00023H-N6; Fri, 06 Oct 2017 04:45:58 +0000 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e0KNp-0005R7-6c for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2017 04:37:10 +0000 Received: by mail-pg0-x243.google.com with SMTP id b11so8175096pgn.0 for ; Thu, 05 Oct 2017 21:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pGJ1AQ1TZ2QaEOW0XikBS7gXVwAJw8WW1gkbKBk7SMA=; b=sHZjE6RQVpTT41fLfp3lMsfl7t1p9wzWj/1BpEy2xJ/XfqRJGpFujmnwvoMYq4+nyA MADFUt3cYWSj70nhP2lM0SBsjTyNRDo3kZ1JifVY6HFPUU1c9F8+Mnl2gn15dolxw8n/ BQa32zEbm04dOLvLH3bQOI3UuEvigjzCesnz/kHkY7bp1OHKkIjmNy85i2HTWWCiV7H7 Ph45RdT5LqA1aso2dpF26zNrimXXOFHON3FrslIV6l0ReqM58Ycuz66qWbN/R7eeDIu+ soPKnUx6HqwLn8hh8Ebqlqyyn43PePjN9fHi8vhv1HgT73rzhQVB5VR9Bx14BnBaAdLr aEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pGJ1AQ1TZ2QaEOW0XikBS7gXVwAJw8WW1gkbKBk7SMA=; b=Q9BMBpG4IFsKb/FQH9URwxJ0tgHc3ik1KykBfUPPwU1A0ipIpsRADyfV2Gn1tbvBfQ 5OK1/XB3HDP6Wp/M+31n7IC38gsF4wuWMau5fqUUvh5AB65bmKB/1arwS2fgLuJzJTmP o2wkIYw6ub1S+rLCdlzkqxp1bqU/7GzyIWk8Uf0oqbqE325oUFfgd1REJrnH7kOg/3Fy Hz/sC68Kml3ZkB6i/inrzyONAJRH0m4CaS24rz16PspHFblB6aLm8P0f4wL/rawltAzm SyJrq2mMIPFM88gwh7NMnqmpfeusZAe8pQrMX/exoI14HzwjrA/FPRMk8hWet5E5p7AT 2Mdg== X-Gm-Message-State: AMCzsaVyHfw+h9FUfxWkyed7XWaWYRwZwOCXDBVUopMTdV5rWmgSt6ex os2VRuvSzHlLPLBvTIFt8UA= X-Google-Smtp-Source: AOwi7QAyjDUhtr7A2UXI7+KTmbuS/c2KhdZ/GFTZX/ccSsvKJQk1Vj1RWtRwjv/R6FRjWpRRcKmvog== X-Received: by 10.98.204.69 with SMTP id a66mr937691pfg.132.1507264608564; Thu, 05 Oct 2017 21:36:48 -0700 (PDT) Received: from localhost.localdomain ([103.51.74.113]) by smtp.gmail.com with ESMTPSA id k126sm860111pfc.45.2017.10.05.21.36.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Oct 2017 21:36:48 -0700 (PDT) From: Anand Moon To: Rob Herring , Mark Rutland , Russell King , Kukjin Kim , Krzysztof Kozlowski , Kishon Vijay Abraham I , Bartlomiej Zolnierkiewicz , Lee Jones , Chunfeng Yun , Vivek Gautam , Anand Moon , Andrzej Pietrasiewicz Subject: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk Date: Fri, 6 Oct 2017 04:36:35 +0000 Message-Id: <1507264595-3565-2-git-send-email-linux.amoon@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1507264595-3565-1-git-send-email-linux.amoon@gmail.com> References: <1507264595-3565-1-git-send-email-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171005_213709_353573_94391C6F X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP remove the disable and enable of phy clk. phy clk is needed to tune the phy controller. Before: mout_usbd300 1 1 24000000 0 0 dout_usbd300 0 0 24000000 0 0 sclk_usbd300 0 0 24000000 0 0 dout_usbphy300 1 1 24000000 0 0 sclk_usbphy300 3 3 24000000 0 0 mout_usbd301 1 1 24000000 0 0 dout_usbd301 0 0 24000000 0 0 sclk_usbd301 0 0 24000000 0 0 dout_usbphy301 1 1 24000000 0 0 sclk_usbphy301 2 2 24000000 0 0 After: mout_usbd300 2 2 24000000 0 0 dout_usbd300 1 1 24000000 0 0 sclk_usbd300 2 2 24000000 0 0 dout_usbphy300 1 1 24000000 0 0 sclk_usbphy300 3 3 24000000 0 0 mout_usbd301 2 2 24000000 0 0 dout_usbd301 1 1 24000000 0 0 sclk_usbd301 2 2 24000000 0 0 dout_usbphy301 1 1 24000000 0 0 sclk_usbphy301 2 2 24000000 0 0 Signed-off-by: Anand Moon --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 22c68f5..5e8054c 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -409,22 +409,15 @@ static int exynos5_usbdrd_phy_init(struct phy *phy) reg &= ~PHYCLKRST_PORTRESET; writel(reg, phy_drd->reg_phy + EXYNOS5_DRD_PHYCLKRST); - clk_disable_unprepare(phy_drd->clk); - return 0; } static int exynos5_usbdrd_phy_exit(struct phy *phy) { - int ret; u32 reg; struct phy_usb_instance *inst = phy_get_drvdata(phy); struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); - ret = clk_prepare_enable(phy_drd->clk); - if (ret) - return ret; - reg = PHYUTMI_OTGDISABLE | PHYUTMI_FORCESUSPEND | PHYUTMI_FORCESLEEP;