From patchwork Tue Oct 17 10:19:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 10011649 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AF26C60567 for ; Tue, 17 Oct 2017 10:50:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A261E2883F for ; Tue, 17 Oct 2017 10:50:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 974E728849; Tue, 17 Oct 2017 10:50:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 128BD28847 for ; Tue, 17 Oct 2017 10:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=0ETZCmBiPIgRXUwAReBfjwWziFBL8u02zVjN0g/rxaw=; b=QGF 1VF96eP0rRMdpHHgLo5PJ6t0pizjDcrXWitmfJslNM0pW+io/1ms1XZfd7R+6bdmLCLpf5J6GmXZ7 +xl4Ydp0Oe2EgaPXUsZkMDQv6SttdHnu+g9GzH9AmvASf37bli0GVhdlYFSP8pOLRgtmx04BaXM/w j9+QtY5EHvUF9DuXkK1I+LUvXGXn4m/vKJDTr8v6CrrPBuvRmASj4pUSK7zJj1UyFKHOz3kRz4H5d XZ14CXQ2kaiJ/+gDLXBQ+bKpDZEHuGAmTiPmjFkUN/5zlFqRIuYrIk5Fc2R5TXZSv1nfFYb1SxWF9 w2iSu/1x+sf7QfMnkspJMEEjbvFjKgw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1e4PRs-0005MO-8N; Tue, 17 Oct 2017 10:50:12 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e4PQz-00043O-0t for linux-arm-kernel@bombadil.infradead.org; Tue, 17 Oct 2017 10:49:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Z1YGJvRNb2SOq1TMyPlsVGvT1aXnFlqYDxGh7eAc/Tw=; b=is54PTAQ9HYRg/+yoIbakCoPx c0/4zttX63cTWehd/axGzIEszEY2Cxl1ycugxczQmURkuMP3zY05/uO3w5DVFjNkSKv3SMa0pOskb j0s3lyN+UB5dIN1EyfqB7uN5X5CynTi3XRxdtA1cc0V2shAT+hK80Hdao9CG3TnnP/MZUSNe8JMD6 NZW5B7p2rGbcF/6E88tM2Ctv9ewTrPnxUWUY7S6ZeCCX+mZ90tyUFlTRIiLXKbA1DqBneCYVHOLS9 maHHucReG7ZpuuZumnOIkfksxv9/7jCIWwG9nEOGDLiVDaq2EGppGyd0e8kSCeqzC6dDdZzv2VOId DWxCuoy9w==; Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]) by merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e4Oyf-0007Nj-Rz for linux-arm-kernel@lists.infradead.org; Tue, 17 Oct 2017 10:20:07 +0000 Received: by mail-wr0-x22c.google.com with SMTP id 22so1074961wrb.12 for ; Tue, 17 Oct 2017 03:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Z1YGJvRNb2SOq1TMyPlsVGvT1aXnFlqYDxGh7eAc/Tw=; b=wtL03ezBWG7UCilMby/RTgIxh+SA4RHxqmKYEeH0Tr4sznaq2sVjNifNWfJQ1elpVg n9bU0e2EIMFuI2zCramavH3kkqE55Zo9s/zhI8jZ15jhJUjyJzXqyCZK2ONhaDzAvYVE pqpekbc9H5iIG4kkP1y7sB5AZdKuWU3SFqMzsHP+O4Qpt1L67BB0WCuZTXEzmCNk3dUb 7EXe+mbVgb1Vib/3gcFM01Jj5NpE9vKbP6pkOWkWOL6GOIvTr6a0EoMTF7xNoz5ouvjh ZG+FxrVHq8onsvR93TYS8grF/KoKdN5H06AwRmK6f6BZ/uXXfwyJl2cY519R0+Z3xvNo Y6Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Z1YGJvRNb2SOq1TMyPlsVGvT1aXnFlqYDxGh7eAc/Tw=; b=FEHQ9VZ60OkwR7b4Xd1idfooKPwnIRrWlU4FiyyShr3x9KGGLVHblRr5NSPUNni73n OkYrEtjM1nl31GOp1NeeG9v8Imq7eARfG5rLl5F9dZyD2CxWV5bzn9DwfK0IPf/789gs WiwSAX5a6NvuLxSxH89iFpwlYR+GbZ3d1BlIn288wyluJsk6PyDzPGYmI3wTV/YvC5IQ 5RXborYp+lfcsWLMvEoj5ad1OVYVVXUGZqWUXLgLJB+WAyy3gAluqSgafttW/UO7/Aj5 Ms+qL0fE2CNPqBgzSoIwJgqarSDkg5FbbdlBe2bkW6IpPKB/hmxV7y2vkfyR1LfAgwDE RDVQ== X-Gm-Message-State: AMCzsaVTcJztQc/L3wPZkfhBwGbfOHfzEpuM4Zzn4RrphNhEptCjCnr+ azM4YmRkLs5MJMnOwMyiq4Xn7A== X-Google-Smtp-Source: ABhQp+SJ/5WIb6X5ox2cm1VjesVbuNmed+qeAGpB27DdE/LzAcQOFg7DmEqA9dfXo7iwPC6578Zd4A== X-Received: by 10.223.186.202 with SMTP id w10mr3450868wrg.132.1508235578471; Tue, 17 Oct 2017 03:19:38 -0700 (PDT) Received: from localhost.localdomain ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id e77sm14652502wmi.16.2017.10.17.03.19.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Oct 2017 03:19:38 -0700 (PDT) From: Neil Armstrong To: p.zabel@pengutronix.de Subject: [PATCH] reset: meson: remove unneeded check in meson_reset_reset Date: Tue, 17 Oct 2017 12:19:34 +0200 Message-Id: <1508235574-24929-1-git-send-email-narmstrong@baylibre.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The if (bank >= REG_COUNT) is not need since already checked by the default rcdev->of_xlate implementation which guarantees that id < rcdev->nr_resets. Suggested-by: Philipp Zabel Signed-off-by: Neil Armstrong --- drivers/reset/reset-meson.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c index f3b9d69..c419a37 100644 --- a/drivers/reset/reset-meson.c +++ b/drivers/reset/reset-meson.c @@ -83,9 +83,6 @@ static int meson_reset_reset(struct reset_controller_dev *rcdev, unsigned int offset = id % BITS_PER_REG; void __iomem *reg_addr = data->reg_base + (bank << 2); - if (bank >= REG_COUNT) - return -EINVAL; - writel(BIT(offset), reg_addr); return 0;