From patchwork Fri Nov 10 02:32:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10052289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E151F6032D for ; Fri, 10 Nov 2017 02:33:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9E482B28B for ; Fri, 10 Nov 2017 02:33:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BCC652B28F; Fri, 10 Nov 2017 02:33:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C87382B28B for ; Fri, 10 Nov 2017 02:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=R9oWDWQj2/MaBkEh1stDkD+S4gFNt8werb+/7ctRysA=; b=nXsA7hHcf4HeoTYx45g59n15wb 02FXgZtQjfsp9E7O1mn4qdq/eRwNwokwtjugDV6rpoiyBKwUjbauFszJJq4x62YgRT8dGGTzqpWCZ QS2TeHubSNqC6k1x+vKvYYnS1sSwpsyhZ4uyVCcTUz+1aqpAJrC2uKwmTge5Y7kf7VHZI5VXrQHHK ISeWYvrj4g3BOJwhxuU9dRD6Q81ejMFXT1ucGqCdWbA0AkxtvPiV7RwlB6J5iIyGPTEINqm4mHnO/ kXhYY6sQSdr0Dx4ngX0QAoJAZt6byEtduMCMT0sgmtK+gaKzUnemjFmkjIvBtnUtiX9gr0wowCjPW ZbM7Sb0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eCz8X-0001pj-OS; Fri, 10 Nov 2017 02:33:41 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eCz8E-0001Wt-Hp for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2017 02:33:24 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DC68C60807; Fri, 10 Nov 2017 02:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1510281183; bh=D3jFzHwx8V0Lyx0VdL8HVq18xg1ZwDFj5cJcTg8f4Jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LSL16pyIRQDNpWDPuFEZtasHXxCbbAtAj/FRGAzZussoIgg7g9vt3GJGYol1+ZzAa FCbnFZmy0xtKEdGg2EEg0mcEFQtOzx3IgxMbBJt7GY92hR1wVPtvOzYJ0SN/D5wfGT jhX/oqKg0Ed4ZIqGG4AlaCZu4pdmH7X93iWfTs+8= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B9EB8607A1; Fri, 10 Nov 2017 02:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1510281183; bh=D3jFzHwx8V0Lyx0VdL8HVq18xg1ZwDFj5cJcTg8f4Jc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LSL16pyIRQDNpWDPuFEZtasHXxCbbAtAj/FRGAzZussoIgg7g9vt3GJGYol1+ZzAa FCbnFZmy0xtKEdGg2EEg0mcEFQtOzx3IgxMbBJt7GY92hR1wVPtvOzYJ0SN/D5wfGT jhX/oqKg0Ed4ZIqGG4AlaCZu4pdmH7X93iWfTs+8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B9EB8607A1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: dmaengine@vger.kernel.org, timur@codeaurora.org Subject: [PATCH V3 3/4] dmaengine: qcom_hidma: add support for the new revision Date: Thu, 9 Nov 2017 21:32:54 -0500 Message-Id: <1510281175-27173-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1510281175-27173-1-git-send-email-okaya@codeaurora.org> References: <1510281175-27173-1-git-send-email-okaya@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171109_183322_680489_7A32B461 X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sinan Kaya , linux-arm-msm@vger.kernel.org, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Add support for probing the newer HW and also organize MSI capable hardware into an array for maintenance reasons. Signed-off-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index e366985..d9d8071 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -50,6 +50,7 @@ #include #include #include +#include #include #include #include @@ -104,6 +105,9 @@ static void hidma_free(struct hidma_dev *dmadev) module_param(nr_desc_prm, uint, 0644); MODULE_PARM_DESC(nr_desc_prm, "number of descriptors (default: 0)"); +enum hidma_cap { + HIDMA_MSI_CAP = 1, +}; /* process completed descriptors */ static void hidma_process_completed(struct hidma_chan *mchan) @@ -736,25 +740,17 @@ static int hidma_request_msi(struct hidma_dev *dmadev, #endif } -static bool hidma_msi_capable(struct device *dev) +static bool hidma_test_capability(struct device *dev, enum hidma_cap test_cap) { struct acpi_device *adev = ACPI_COMPANION(dev); - const char *of_compat; - int ret = -EINVAL; + enum hidma_cap cap; - if (!adev || acpi_disabled) { - ret = device_property_read_string(dev, "compatible", - &of_compat); - if (ret) - return false; + if (!adev || acpi_disabled) + cap = (enum hidma_cap) of_device_get_match_data(dev); + else + cap = (enum hidma_cap) acpi_device_get_match_data(dev); - ret = strcmp(of_compat, "qcom,hidma-1.1"); - } else { -#ifdef CONFIG_ACPI - ret = strcmp(acpi_device_hid(adev), "QCOM8062"); -#endif - } - return ret == 0; + return cap ? ((cap & test_cap) > 0) : 0; } static int hidma_probe(struct platform_device *pdev) @@ -834,8 +830,7 @@ static int hidma_probe(struct platform_device *pdev) * Determine the MSI capability of the platform. Old HW doesn't * support MSI. */ - msi = hidma_msi_capable(&pdev->dev); - + msi = hidma_test_capability(&pdev->dev, HIDMA_MSI_CAP); device_property_read_u32(&pdev->dev, "desc-count", &dmadev->nr_descriptors); @@ -953,7 +948,8 @@ static int hidma_remove(struct platform_device *pdev) #if IS_ENABLED(CONFIG_ACPI) static const struct acpi_device_id hidma_acpi_ids[] = { {"QCOM8061"}, - {"QCOM8062"}, + {"QCOM8062", HIDMA_MSI_CAP}, + {"QCOM8063", HIDMA_MSI_CAP}, {}, }; MODULE_DEVICE_TABLE(acpi, hidma_acpi_ids); @@ -961,7 +957,8 @@ static int hidma_remove(struct platform_device *pdev) static const struct of_device_id hidma_match[] = { {.compatible = "qcom,hidma-1.0",}, - {.compatible = "qcom,hidma-1.1",}, + {.compatible = "qcom,hidma-1.1", .data = (void *)(HIDMA_MSI_CAP),}, + {.compatible = "qcom,hidma-1.2", .data = (void *)(HIDMA_MSI_CAP),}, {}, }; MODULE_DEVICE_TABLE(of, hidma_match);