| Message ID | 1510750608-8697-2-git-send-email-eugen.hristev@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 15, 2017 at 02:56:45PM +0200, Eugen Hristev wrote: > Added property for DMA configuration of the device. > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> > --- > Changes in v3: > None, but we discussed on the ML about whether we should have "dma-names" > present in the binding even if it's only one. > The helpers in the kernel to retrieve the channel info rely on the > presence of this property, so I am resending the patch based on this. > If another solution is better, please advise and I can try it and > resend the patch. Really the kernel APIs should accept a NULL name and return the DMA channel when there is only one. This is how the clk_get API works for example. > Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 7 +++++++ > 1 file changed, 7 insertions(+) In any case, not really a big deal. Acked-by: Rob Herring <robh@kernel.org>
On Wed, 15 Nov 2017 09:27:46 -0600 Rob Herring <robh@kernel.org> wrote: > On Wed, Nov 15, 2017 at 02:56:45PM +0200, Eugen Hristev wrote: > > Added property for DMA configuration of the device. > > > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> > > --- > > Changes in v3: > > None, but we discussed on the ML about whether we should have "dma-names" > > present in the binding even if it's only one. > > The helpers in the kernel to retrieve the channel info rely on the > > presence of this property, so I am resending the patch based on this. > > If another solution is better, please advise and I can try it and > > resend the patch. > > Really the kernel APIs should accept a NULL name and return the DMA > channel when there is only one. This is how the clk_get API works for > example. > > > Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > In any case, not really a big deal. > > Acked-by: Rob Herring <robh@kernel.org> Applied to the togreg branch of iio.git and pushed out as testing. Thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt index 552e7a8..6469a4c 100644 --- a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt +++ b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt @@ -17,6 +17,11 @@ Required properties: This property uses the IRQ edge types values: IRQ_TYPE_EDGE_RISING , IRQ_TYPE_EDGE_FALLING or IRQ_TYPE_EDGE_BOTH +Optional properties: + - dmas: Phandle to dma channel for the ADC. + - dma-names: Must be "rx" when dmas property is being used. + See ../../dma/dma.txt for details. + Example: adc: adc@fc030000 { @@ -31,4 +36,6 @@ adc: adc@fc030000 { vddana-supply = <&vdd_3v3_lp_reg>; vref-supply = <&vdd_3v3_lp_reg>; atmel,trigger-edge-type = <IRQ_TYPE_EDGE_BOTH>; + dmas = <&dma0 (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) | AT91_XDMAC_DT_PERID(25))>; + dma-names = "rx"; }
Added property for DMA configuration of the device. Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- Changes in v3: None, but we discussed on the ML about whether we should have "dma-names" present in the binding even if it's only one. The helpers in the kernel to retrieve the channel info rely on the presence of this property, so I am resending the patch based on this. If another solution is better, please advise and I can try it and resend the patch. Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 7 +++++++ 1 file changed, 7 insertions(+)