From patchwork Fri Nov 17 20:28:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10063731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 18AB1601D3 for ; Fri, 17 Nov 2017 20:29:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07E352A18D for ; Fri, 17 Nov 2017 20:29:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F0EE72A211; Fri, 17 Nov 2017 20:29:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9B02A2A18D for ; Fri, 17 Nov 2017 20:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=C+ccgnKUmLct1UwgalzsV3p1x+XSKKCgMcANLcisDu0=; b=HXWFEzmnAIVPJAvs8NtVVuDKR6 /778vrtH5/9WLEnl6HAUw3JysGYpRAs2LacdIAhemIMHIMrz6h4cSckvDlDpXtko/cTLw3YAdloEu 8Pnj4h9YFdyrry+lNkkYe2WRSsKamaAidDYo17IPqaJMccUIeOHOoPYPpFWKQICqNL9R+RTpw/cz5 WDJ2l3hKY1jm9qoWbGue3SGZkhAfa4c+EhxmCa2lU3lbvduxtcRAu92BzgnGVf/LkCPr6VkpfeQKK kJmAIcoLpApQG/SpKA+ZRZD1Tp2dbKVKjG8VzH1ecg5ik111XWdEvUanKXrBswGy6f0RrwKBnAw9U c/mh7Qgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eFnGX-0006S4-3M; Fri, 17 Nov 2017 20:29:33 +0000 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFnG8-0005zr-N9; Fri, 17 Nov 2017 20:29:29 +0000 Received: by mail-pf0-x244.google.com with SMTP id m88so2712561pfi.9; Fri, 17 Nov 2017 12:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=v6xwwTmjG/o9phNXruoJ0RWSoK91W1jFeJbVHPUQ4xw=; b=BAtZuADv8Ty8UXtQ5f8Z87K5ar+bLRGFS1/nnqYO2+epTOdccfRUPqwuz+c8b9qB7N J4gtMYOxokt28JZKqDIIWGGfoHM9roDsyki0PvS+8p0y3mjjWOCEhoZxpAV1LKgrbtDL D2T2/rYzhH2yR1fcfZztFsh3x/84mFREISBf2TUE/iW0rZNpucKhfLuBkMC8c8/L234p G/HTVHoq30XtFHRuXkumcmuP9PDy6ywa3i8tRn4NZcBd++iesjLzMcJLwEw1r2gX9566 BzCkxsZJLvlc47xTbPr7jv1qJP7L3IBdZwV60WMgkWf/lC/Wj+4KkuKiOLsQb4lFsY2P aGSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=v6xwwTmjG/o9phNXruoJ0RWSoK91W1jFeJbVHPUQ4xw=; b=kDQm1na89Ri/oeBf7nhV3L5m4Hd7OB2uB+nN6d1JCH/8QRrgiy848RH/PetsR5S/SH Q/rgedHpGxGHeAYX0t9gh5caemGwCWbdHZqmTSmkUorb3WnvMcuF3rkneoXM7z6PxqfK 4t4hCz83HJw+o6wwKxapOOKj5m0balEoAYfDB7M4+2dnZulyusnLfpCOO/Z9ppG9zP6U NfCJ/2YFsxil2EefZqdew4hhaG0BEjMyua1eVDNlEZzk+Cxc0IkPEm/MAFc9bhJcM2PV ZO1vbVxCyF3PeE8zm14p689GsRvmQEupnHcKGIIyW7GmKfgjAJf1e91gBPcdTO/B+955 9JqQ== X-Gm-Message-State: AJaThX4J7tTour1PwnSH6azM8dXu2WAFtOX4OThyMg69VesyFhXvAuHK ejIYcxwt1oCJJKueSaBl83Q= X-Google-Smtp-Source: AGs4zMa8H8DlkvdMIyNwxlESK1Q6O9R8LmWPUSDxPsOKhkVdWLnVxKKNrVfNayhM38K6ydkQrVrYlw== X-Received: by 10.98.134.65 with SMTP id x62mr3267263pfd.81.1510950528206; Fri, 17 Nov 2017 12:28:48 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id n72sm9382740pfg.109.2017.11.17.12.28.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 12:28:47 -0800 (PST) From: Arvind Yadav To: ulf.hansson@linaro.org, carlo@caione.org, khilman@baylibre.com, ben-linux@fluff.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org Subject: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq Date: Sat, 18 Nov 2017 01:58:20 +0530 Message-Id: <1510950502-22565-5-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171117_122909_146322_EDEA1A5B X-CRM114-Status: UNSURE ( 7.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav Acked-by: Viresh Kumar --- drivers/mmc/host/sdhci-spear.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index 8c0f884..900838b 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev) host->hw_name = "sdhci"; host->ops = &sdhci_pltfm_ops; host->irq = platform_get_irq(pdev, 0); + if (host->irq < 0) { + ret = host->irq; + goto err_host; + } host->quirks = SDHCI_QUIRK_BROKEN_ADMA; sdhci = sdhci_priv(host);