From patchwork Sat Nov 18 05:44:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10064369 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0F1FE60230 for ; Sat, 18 Nov 2017 05:45:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 008BE2ADA0 for ; Sat, 18 Nov 2017 05:45:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6DA02AECA; Sat, 18 Nov 2017 05:45:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 85B4A2ADA0 for ; Sat, 18 Nov 2017 05:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Vka4qDLas7WMARif8G7lC8wzzrpYlJJH2jQL5XbzSLs=; b=WW3LP+kBXwFFdqMFWaLBGK6avd zUQSo9VDjqWER2K1ZbsgIDPe0044/rINUDlVfpIlhqfcp+vwQdKpbZZvLODjpLRzk3uexCdvTSEw0 UxasG99kcceCRDc58ZmZMyCbxnMh+uvlZ5P2eVafU6d/DcPQYDDf3FYwsRMNJrPCtoPdbCJ6IwjHr RCfJyoLhkeU8vKhudi4xAiMAZJ5qdcAC+LSdVVKcIUHLGOGXYRDUPoR67QN8R1z5zplfdHdLEgBi3 /PYf8wEZzZQVfhGx19P6a/fBlpfjs9LLhpCI/qbpQOVY1s0qDlhmLfylr7p1An62ykDhERI7LZ9NY tgRlx6bA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eFvwR-0004dU-27; Sat, 18 Nov 2017 05:45:23 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFvw4-00033H-BK for linux-arm-kernel@lists.infradead.org; Sat, 18 Nov 2017 05:45:03 +0000 Received: by mail-pf0-x242.google.com with SMTP id u70so3481786pfa.7 for ; Fri, 17 Nov 2017 21:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+pKQaodwpDUSVhGhx3pHDx9zJpxNo+K3tn5i4m+dNrU=; b=pSZQCeMkBgFCWXUimbqSFEsjrbrf9EcHen5bW6UXCOdcg9UERssXp2Hqm0QEoxElET 68Ih4sM1i+E5iwjyIxoHRq0juRRxynvR9iN8n5d0QCd21cD9sZd2dYXvC2pWl9WjyIh3 uKsj2yCZ/ZRfnOZzIB/WF95ehijUKO/pDqvehe9uYR8nPb8eY6L1Pw+4Dz24ja+FeMaU 3ZhnrXkFVLyt+j+dUgP2RyPql5osYBojRL/6vLok5pBbZRVaeaxZD0zKWbIUjsCnBPPZ pvfQ3GhrxSRsG4/OFd2C5YO7IwsPzkcZr4RNDFJQsIQpkLJJ14Nt30ai7JdGyCVooMzf zO6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+pKQaodwpDUSVhGhx3pHDx9zJpxNo+K3tn5i4m+dNrU=; b=YBf8J0oPKydfLIH0GwVEQ0Mx2a4996zeQpwhVe8AhHgTI5lfu24ZcuiIn+i+r31R+q WEIr4w0w4/MAUi/Tgdk+Objk01RbUi+oWpZHabHRUAxNBnSsf4MWZrRih6ZldRSqXRbd UuO7AX0z19JtOUV93jpZbxF2ICvj5pmzpO0Cd/41AjthWaXoaQfaJ8Fg5kyfOZ8dduvt 1zNL6t+6hXdt87oh3BwWKn7jr3mWuixZ6sz4Hwxai1BG8OO+j7R5e1HCbVQlurA44O8C 9wf8PumpKt+NH5v1gTRutYGn4iLz5zVwdTR8dgEdm5obCOPtKCMppn9/i80SsjtpUr1O pkVw== X-Gm-Message-State: AJaThX4af+64XzYbxFATezIMxUYBOMrKf43uz5VTBAMOfji6I/6B3lu6 /rL6RvlzNCHp42VBtginQUQ= X-Google-Smtp-Source: AGs4zMa6cEPUIyACbubhiw/Ym1uj2BK7u3RTHzDjM/JmGcNbD8r/R3HRL+/zlp4WZjH3x9jDo8M36Q== X-Received: by 10.98.32.206 with SMTP id m75mr4419040pfj.231.1510983879797; Fri, 17 Nov 2017 21:44:39 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id h1sm8923492pgf.37.2017.11.17.21.44.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 21:44:39 -0800 (PST) From: Arvind Yadav To: arnd@arndb.de, gregkh@linuxfoundation.org, joel@jms.id.au, nicolas.ferre@microchip.com, alexandre.belloni@free-electrons.com Subject: [PATCH 1/2] misc: aspeed-lpc-snoop: Fix platform_get_irq's error checking Date: Sat, 18 Nov 2017 11:14:26 +0530 Message-Id: <1510983867-2344-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510983867-2344-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510983867-2344-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171117_214500_755339_983CEFE2 X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/misc/aspeed-lpc-snoop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/aspeed-lpc-snoop.c b/drivers/misc/aspeed-lpc-snoop.c index cb78c98..14c3c90 100644 --- a/drivers/misc/aspeed-lpc-snoop.c +++ b/drivers/misc/aspeed-lpc-snoop.c @@ -115,8 +115,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop, int rc; lpc_snoop->irq = platform_get_irq(pdev, 0); - if (!lpc_snoop->irq) - return -ENODEV; + if (lpc_snoop->irq < 0) + return lpc_snoop->irq; rc = devm_request_irq(dev, lpc_snoop->irq, aspeed_lpc_snoop_irq, IRQF_SHARED,