| Message ID | 1511303493-14897-1-git-send-email-gomonovych@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2017-11-21 at 23:31 +0100, Vasyl Gomonovych wrote: > Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). > > drivers/gpu/drm/mediatek/mtk_drm_gem.c:223:9-16: WARNING: ERR_CAST can be used with mtk_gem > Generated by: scripts/coccinelle/api/err_cast.cocci > > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> > --- > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > index f595ac816b55..5766b42fc174 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > @@ -220,7 +220,7 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev, > mtk_gem = mtk_drm_gem_init(dev, attach->dmabuf->size); > > if (IS_ERR(mtk_gem)) > - return ERR_PTR(PTR_ERR(mtk_gem)); > + return ERR_CAST(mtk_gem)); > > expected = sg_dma_address(sg->sgl); > for_each_sg(sg->sgl, s, sg->nents, i) { Acked-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
Hi, Vasyl: Sorry for the late reply. I've applied this to my branch mediatek-drm-next-4.18 Regards, CK On Thu, 2017-11-23 at 17:31 +0800, Philipp Zabel wrote: > On Tue, 2017-11-21 at 23:31 +0100, Vasyl Gomonovych wrote: > > Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). > > > > drivers/gpu/drm/mediatek/mtk_drm_gem.c:223:9-16: WARNING: ERR_CAST can be used with mtk_gem > > Generated by: scripts/coccinelle/api/err_cast.cocci > > > > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> > > --- > > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > > index f595ac816b55..5766b42fc174 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > > @@ -220,7 +220,7 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev, > > mtk_gem = mtk_drm_gem_init(dev, attach->dmabuf->size); > > > > if (IS_ERR(mtk_gem)) > > - return ERR_PTR(PTR_ERR(mtk_gem)); > > + return ERR_CAST(mtk_gem)); > > > > expected = sg_dma_address(sg->sgl); > > for_each_sg(sg->sgl, s, sg->nents, i) { > > Acked-by: Philipp Zabel <p.zabel@pengutronix.de> > > regards > Philipp >
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c index f595ac816b55..5766b42fc174 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c @@ -220,7 +220,7 @@ struct drm_gem_object *mtk_gem_prime_import_sg_table(struct drm_device *dev, mtk_gem = mtk_drm_gem_init(dev, attach->dmabuf->size); if (IS_ERR(mtk_gem)) - return ERR_PTR(PTR_ERR(mtk_gem)); + return ERR_CAST(mtk_gem)); expected = sg_dma_address(sg->sgl); for_each_sg(sg->sgl, s, sg->nents, i) {
Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). drivers/gpu/drm/mediatek/mtk_drm_gem.c:223:9-16: WARNING: ERR_CAST can be used with mtk_gem Generated by: scripts/coccinelle/api/err_cast.cocci Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)