From patchwork Wed Nov 22 22:49:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10071657 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4938C60353 for ; Wed, 22 Nov 2017 22:52:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AB1D29A65 for ; Wed, 22 Nov 2017 22:52:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2EA1129E20; Wed, 22 Nov 2017 22:52:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D4D3D29A65 for ; Wed, 22 Nov 2017 22:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uOQxfJc4nEOtUurwo9kH4kPVS13pmXLCuW+E7Ie3oqE=; b=Jphy40e14D1kajjp1R4/FjwMeB pRy+P3v3Ohb/fnz1BqsNsD29oQYp0A2D+wB5vc+WwOFPjQV+mRIZYHnc5h4gkFepPaUwwzdONkprC HCisxuNbXGEnNiiVoPrsze6kv2wlf3rjVdVI7pFbuoBOKiwxb4m8XQDxw2LopNb46pep2wXwWh6Hz ddzQWWIY0aDwCTcJaIC0OlD59owwg8wChMPqRTLj8Pnc/xcpAvbPpX5Z9JuFfFSKK6PbJFCQnthDJ P3zFbH94loyIj0kdce41dOZVoTCcw1KB2bhy6tDrwDZRrb4lwD7641rV/4UHtKdA+CAggvKWXz7GC 6wd+bESQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eHdsR-0008Vx-5T; Wed, 22 Nov 2017 22:52:19 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eHdqN-0004wT-OR for linux-arm-kernel@lists.infradead.org; Wed, 22 Nov 2017 22:50:21 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 658096089E; Wed, 22 Nov 2017 22:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511390988; bh=vzRk/vFUyKIwR9RbnrMjGqKKmLzdxl5LPLKu0CSEh9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R87Rujo4JmSWv1wE2a5W5nLZpFfK3TfB3qS+85gSVdXHTqsTkLFtXAwlAnxmPyNly AXuP1/yNZ4/b82VNE64W0g37185v/yFtvJ2lAnS/mxcHXGvkrwH3ZVpxh3oj0gVZn7 bA9Nx2MUQTalG436jcgQlIJdt9FF9T7tRP4jF2h8= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8DCB960886; Wed, 22 Nov 2017 22:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511390986; bh=vzRk/vFUyKIwR9RbnrMjGqKKmLzdxl5LPLKu0CSEh9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HgQlaj7FUZLceD4TZSPOW0f8jmXZwfXcoHj/oYXxd4MJYod54FXgA7N+f7sUqBkvF I7lLMMDTwQJ3T8NVr+TLPiHlXvSybj+gz2h3snFQlOaovCDkngyn48CUtA7m4GKQOz hs+bkRdWEK4awFWdiya10gO2W8dwwZ4fDqLi8xbM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8DCB960886 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org, timur@codeaurora.org Subject: [PATCH V2 07/29] ibft: deprecate pci_get_bus_and_slot() Date: Wed, 22 Nov 2017 17:49:02 -0500 Message-Id: <1511390964-9979-8-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1511390964-9979-1-git-send-email-okaya@codeaurora.org> References: <1511390964-9979-1-git-send-email-okaya@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171122_145012_084876_54144AE1 X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, open list , Sinan Kaya , Konrad Rzeszutek Wilk , Peter Jones , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). We don't search for the device in other domains than zero. This is because on x86 platforms the BIOS executes only devices which are in domain 0. Furthermore, the iBFT spec doesn't have a domain id field. Signed-off-by: Sinan Kaya Acked-by: Konrad Rzeszutek Wilk --- drivers/firmware/iscsi_ibft.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 14042a6..6bc8e66 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -719,8 +719,9 @@ static int __init ibft_create_kobject(struct acpi_table_ibft *header, * executes only devices which are in domain 0. Furthermore, the * iBFT spec doesn't have a domain id field :-( */ - pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8, - (nic->pci_bdf & 0xff)); + pci_dev = pci_get_domain_bus_and_slot(0, + (nic->pci_bdf & 0xff00) >> 8, + (nic->pci_bdf & 0xff)); if (pci_dev) { rc = sysfs_create_link(&boot_kobj->kobj, &pci_dev->dev.kobj, "device");