From patchwork Mon Nov 27 16:57:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10077481 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D7B766028E for ; Mon, 27 Nov 2017 17:02:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C69D028F3A for ; Mon, 27 Nov 2017 17:02:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB4A228F5C; Mon, 27 Nov 2017 17:02:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4CC3728F3A for ; Mon, 27 Nov 2017 17:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ij9s/pJNgXNvsvQkl8xLGNAR+3qn65WhL61VS2c7TIM=; b=bOCIDzluUrXlKajh6OHdvizmBs WVE10vLIvD5wE9fr8LQv7dj5FHMs4rI8edj1zVNo2isMxZKEJuoompDiJtXd95LrHYSG9Dcp9BkuS x4PqVo+UzszIq1atxwCcx/mfXluy/R3ySCWl+9OVopefMbSzhFau95epW/LgJvqb5BZj6yTgtEky7 UJhMlVh3aSMWdUo4OmJc4NpAobtz1mcdkB3Brz/EaH/rpE3V3jHc0fY0A80X6XrviOLU13rz20Cvn +TJKXA4zcLqN1sTZhMAxCJ6Gy4MjmqfgchRQbyaqkKlCA57pYryj+RSxWTEphsG9eShnAF5qvk/0n rHNUHTLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eJMno-0001kg-Dr; Mon, 27 Nov 2017 17:02:40 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eJMkM-0005rR-5O for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2017 16:59:14 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 043186A59D; Mon, 27 Nov 2017 16:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511801917; bh=txAkRG7vqZ800mDcVcHRurbi3guc+vcWFdDqKEWcue0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L5VDYf7N0pgLUH+r1V0U6alU5mMorTruUqoHs2rYjDNltToAdWwc6ZK3OJmJ9q+c5 AyMSZmn1h0YmQdc4W3wOq7MkdR+1X4I14wIsYGWdVn6ZDQ4ZY/2BlJZiDRoI7MKEWv zD58CRx3Z6j3TjWDow0xqYfR4yNfZ8+nCbs6opVQ= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 010766A596; Mon, 27 Nov 2017 16:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511801915; bh=txAkRG7vqZ800mDcVcHRurbi3guc+vcWFdDqKEWcue0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gpm9iPZef4zzOQ0WGFAQr5et8iRYfjPSYUWKGHFUZ86IJJngADcwT1ekCKajr9m9z pvUG1Nq8peLlF3KZp6Glv2gnlzjZsMutGvio3iRkroQDv/tcfsSe/nLZf6Si1NqIaV UGOjCKMktpxWIHXpxdcW2TUDGOQEGwS9sQ+N10dk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 010766A596 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org, timur@codeaurora.org Subject: [PATCH V3 07/29] ibft: deprecate pci_get_bus_and_slot() Date: Mon, 27 Nov 2017 11:57:44 -0500 Message-Id: <1511801886-6753-8-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1511801886-6753-1-git-send-email-okaya@codeaurora.org> References: <1511801886-6753-1-git-send-email-okaya@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171127_085906_402802_25786372 X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, open list , Sinan Kaya , Konrad Rzeszutek Wilk , Peter Jones , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). We don't search for the device in other domains than zero. This is because on x86 platforms the BIOS executes only devices which are in domain 0. Furthermore, the iBFT spec doesn't have a domain id field. Acked-by: Konrad Rzeszutek Wilk Signed-off-by: Sinan Kaya --- drivers/firmware/iscsi_ibft.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 14042a6..6bc8e66 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -719,8 +719,9 @@ static int __init ibft_create_kobject(struct acpi_table_ibft *header, * executes only devices which are in domain 0. Furthermore, the * iBFT spec doesn't have a domain id field :-( */ - pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8, - (nic->pci_bdf & 0xff)); + pci_dev = pci_get_domain_bus_and_slot(0, + (nic->pci_bdf & 0xff00) >> 8, + (nic->pci_bdf & 0xff)); if (pci_dev) { rc = sysfs_create_link(&boot_kobj->kobj, &pci_dev->dev.kobj, "device");