Message ID | 1512242782-7134-2-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 608CD60380 for <patchwork-linux-arm@patchwork.kernel.org>; Sat, 2 Dec 2017 19:27:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 515702934A for <patchwork-linux-arm@patchwork.kernel.org>; Sat, 2 Dec 2017 19:27:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 45DBA2935B; Sat, 2 Dec 2017 19:27:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AB9192934A for <patchwork-linux-arm@patchwork.kernel.org>; Sat, 2 Dec 2017 19:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=jF5wVxn/+K9EGSWff/13Rq8bscby6mcysgmGIbIWuUk=; b=fW2lDsEQPGRXwZbGTz34kOXZSZ grL0/tCgvrIey5qU/el+LA3tdv9R7RsreGt5K6xJ7RW4y9m0I+WqCbWH2krOqIC1JV7N3ZjFLopFj Df4ka2wxThT9wFHDdvvqPd5LXakwh4rQae4BJRQ7YP3Pm6+x3g2joV+sX7J+6UCX0gy0I2Q0o36Gr uOsEPxvyDKU29KrN7hyLYYOCCaNuXVjasfpk73VQqZSnA+aTy1fba2IMgNudlYCQAgIldJwnzztMT u9Zv/6R42EaxidRshs9+oekXMWW8ASH894tH0VmUghfy5SVb7wrjNWQbDoERmjEIEhbo0fNkQyrto vidxGo4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eLDRp-0000p8-JS; Sat, 02 Dec 2017 19:27:37 +0000 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eLDRD-0008S6-0B for linux-arm-kernel@lists.infradead.org; Sat, 02 Dec 2017 19:27:00 +0000 Received: by mail-pl0-x243.google.com with SMTP id q7so8165461plk.0 for <linux-arm-kernel@lists.infradead.org>; Sat, 02 Dec 2017 11:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JfiabAyDisYZJU+0y91+jP3o+8uMbeI+e2BtLwuDaxg=; b=V9hrVbBhKOmKdIMWxi+QWUjAOIIclI663Sw3A2k2o/zRzPNkmUMrkRbM+p95Fb++9m in5TWoE0pnWrjWyg6NI+blisoPDbyrVG0bet/zQrtuegIDY3Jg4Wj+y3IOR0ZykcHDDW m2mmMwo3f5rOPIaYIerlFzpveUgLl88hW+7eDz9i4MonYmFQN+0LouLDucteZihsGrAG SLImtjECEhRlrhOGWyBy5p+PnSfZxvUA8A46dDgTAGmANYs6Fd9XuZhsqARjCCrOpGMh Yuo4EIJSmsfO3tQUkcj9A+AWLKuXO8xW5Cp6hXn7APOY55cUU1DUJdUkWmaE1i2tIUv4 wVdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JfiabAyDisYZJU+0y91+jP3o+8uMbeI+e2BtLwuDaxg=; b=S71ctZyX8FwZzlfFV0lqBINdvVcbScnyakGeaHRJVlzlTbJRq3XEasHefj+5ywWbi1 dbn5VxB4pKW9Mh+oVRl0aaBmvr+u2NjVbQjt2RaMsOhGG8BW+VL43kajRtfhonhK26WD 6U1I712tUagTuUy5o/xoGIK27V2xHRqGRY3s7v0q6ZEMA+m/1pIcphO4STuw7HjJ4GpS 9TeJczmcAAVn1wmyIKxJM5v1W+msGTcSTO/BthBUir6vbrYtvJg9aDHHK7Hf0/Vy4Klj oOe7RH+uc4sTE4Xh3rBgBVOD0mJtExO5yPxcAm0hDHZxv+Efy9cYYhm/3HbEJ0pv47KY dcVA== X-Gm-Message-State: AJaThX5FUYGCati4hqqVPLBR/86wYm3gVgwzeQrgMloEeLznJ9pMNaNA vKxQUnhQRlK6AId2cUs+B/Y= X-Google-Smtp-Source: AGs4zMZA6bi7hGE6AUlwQar4VzbVl8LF0NNpA/lUMmoDvjK4UehYFE03PmCze9HlQC4ovFa7hBIIZA== X-Received: by 10.84.136.135 with SMTP id 7mr10025913pll.21.1512242796829; Sat, 02 Dec 2017 11:26:36 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:36 -0800 (PST) From: Arvind Yadav <arvind.yadav.cs@gmail.com> To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Subject: [PATCH 01/10] net: bcmgenet: Fix platform_get_irq's error checking Date: Sun, 3 Dec 2017 00:56:13 +0530 Message-Id: <1512242782-7134-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171202_112659_091704_6ABFC48B X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 24b4f4c..e2f1268 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3371,7 +3371,7 @@ static int bcmgenet_probe(struct platform_device *pdev) priv->irq0 = platform_get_irq(pdev, 0); priv->irq1 = platform_get_irq(pdev, 1); priv->wol_irq = platform_get_irq(pdev, 2); - if (!priv->irq0 || !priv->irq1) { + if (priv->irq0 <= 0 || priv->irq1 <= 0 || priv->wol_irq <= 0) { dev_err(&pdev->dev, "can't find IRQs\n"); err = -EINVAL; goto err;
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)