From patchwork Sat Dec 2 19:26:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10088999 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8AA160380 for ; Sat, 2 Dec 2017 19:28:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA5162934A for ; Sat, 2 Dec 2017 19:28:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CF2812935B; Sat, 2 Dec 2017 19:28:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 683122934A for ; Sat, 2 Dec 2017 19:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=jOwD3ONmHLDIgDydS2oEsjtrQ8S/FxTTtcCdl8yoUkI=; b=aR8Lq4Dv/2KpLb3aHq5x5lo5q6 zmG0rFZCE+RKG/lDYUtnD+G57szv3HcAbmFcyYtb6IkTK3HMJ6Vrgfc0w5i50WKr0mqJc01z/xVir JorbxDelJcVD6QRD1hjq/LN1hxUk4uqYom9na2IUVb6KuSdFktyNcaBfviDNS46A4L/rf9x6q7Bsb q5Gx8cjX+BO6imoZEeEZa/pHifykDrMkMCicoksNtlqhvtxT6YPjOy/ykz+TfRAGudJtIdSli1gvN DBGPAU8SOgJPiqAGlfi35U0h1JJJsVXuZrphjwdWAlsa2QTUkGwLKqqc9LOvci+jRWXHNxzWlMaI4 bkPoGgTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eLDSs-0001lR-Io; Sat, 02 Dec 2017 19:28:42 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eLDRO-0008Th-Kn for linux-arm-kernel@lists.infradead.org; Sat, 02 Dec 2017 19:27:17 +0000 Received: by mail-pf0-x242.google.com with SMTP id n6so6093462pfa.4 for ; Sat, 02 Dec 2017 11:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3N9N+1VLcUW/4uQzg/7SimUBvcthJGhtRDiEuoqOQ+E=; b=ffGQi4zvMNEkXraUjnnrlmDAiUUJAQh7s1JlSoaU9b2AiKKl881oNaniBDzHIvry6H 6ul5Hy+qCkJP8oi3hFn3PryJtvfAuAkNgmD1jw+ce76r0EgCh0rRALDWoINz+UdlIWMV 1jv3u72nZHdgV65Ajpxqa17nnpWl607MwZLSPprkx2pyxn2qX+GfKNQL/IRkJDEkoD9i e8tKn+lvdHAI4of+d5R5oArtIFWm+qXIQDk5K59HjNWdpqeiTUeYRpXbsgUP0zIoykXW bOVVtgelk0GIctTD4dK5UIoayFzzeOaYUMnDm4w4k/y3+ihdFllHKAN4gqqpHpzoJWRj Lonw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3N9N+1VLcUW/4uQzg/7SimUBvcthJGhtRDiEuoqOQ+E=; b=WQV17iaVGAT+TFNprS5m+PL2uFceW6VeE5ozmOR5JDGxSwlmgwtzTJ8+ar/fbD4DJM q0wZOJMdoTUnUZHRsTo0NNfAx3QpzCW/22M5qkbylT0fn92Cnt2kBKa7LWrP3cOP7hE8 DuWEeEEuDwaEOrB8qPZKGvTUG0s1PwJLbl9/z2DgxQ0siHYfW5pUm0lDinNxOcL5HjoG djtmkYpMFu+QTJsk5gITQZ/CuDE19jwE+MYFK3zWJGn9x5mVAK33CPzrEt3YTOy5ZTIZ FUTTOjZJAZ7VuUZrinVNHUQIj3396bXltCT3jfUlWsBLzXMpHRkPEVPS3Ny3jAEaXaS1 wO7Q== X-Gm-Message-State: AJaThX4KKNUdlOhjWWzCOsr3VwxopNeM54Yc4VNJLankAo5cod0aCYUl gi1PmPpocVbCOuErf6tElIvs8A== X-Google-Smtp-Source: AGs4zMZH+yfsH5A0rLofzkpBM9nbHH32HE61/qd/Le69O0CYuQCNxRMXo9H5HasAy8VOjr/fbkIrqA== X-Received: by 10.101.77.210 with SMTP id q18mr5459356pgt.145.1512242809702; Sat, 02 Dec 2017 11:26:49 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:49 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Subject: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking Date: Sun, 3 Dec 2017 00:56:17 +0530 Message-Id: <1512242782-7134-6-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171202_112710_920401_CAD742DF X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/i825xx/sni_82596.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/sni_82596.c b/drivers/net/ethernet/i825xx/sni_82596.c index b2c04a7..a6d56f5 100644 --- a/drivers/net/ethernet/i825xx/sni_82596.c +++ b/drivers/net/ethernet/i825xx/sni_82596.c @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev) netdevice->dev_addr[5] = readb(eth_addr + 0x06); iounmap(eth_addr); - if (!netdevice->irq) { + if (netdevice->irq <= 0) { printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n", __FILE__, netdevice->base_addr); + retval = netdevice->irq ? netdevice->irq : -ENODEV; goto probe_failed; }