Message ID | 1512409703-20881-7-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A35686035E for <patchwork-linux-arm@patchwork.kernel.org>; Mon, 4 Dec 2017 17:51:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9535223B24 for <patchwork-linux-arm@patchwork.kernel.org>; Mon, 4 Dec 2017 17:51:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 896F128917; Mon, 4 Dec 2017 17:51:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2AAB123B24 for <patchwork-linux-arm@patchwork.kernel.org>; Mon, 4 Dec 2017 17:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hXfzeyqX0oF+vegLvQ2hlbapVDZw0XubsCLcCgSA7LM=; b=P4sHB3WRpYjmKM1bEmawKJqaQo A+f3mGm0rgQDsLiEWBg5yoWjXgEYmhP4xOb8f6q/FKY86Gan1gEXcCrxxCz06XAxY4izYr4Yz/hi4 k1UUw2DOWVBBtOcxApdNbqIy0VJW1SBBJQdlyxZP0Z4GZvTB2Qt/ez5f6PfFQTYYXAoEPUMTsxPxr 88l/qL5FtMtD1yU7RQXG9MXeU4CLhYcUcAoiNv/lq51zRW8PvcQr/rfUVTtLRhjhVVCA/DRxV1Xzc q4KgSoyUx34SBw2cJI/A2zmr3UMybrRbBwbtbn864QVocsqv14KpXX30QChHNgK76LS6F5mOEfxjZ 1Vb5FSfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eLutj-0004X4-6K; Mon, 04 Dec 2017 17:51:19 +0000 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eLurn-0000rW-Mu for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2017 17:49:31 +0000 Received: by mail-pf0-x244.google.com with SMTP id j28so9062577pfk.8 for <linux-arm-kernel@lists.infradead.org>; Mon, 04 Dec 2017 09:49:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LWu3LD/6qgRdIa3DnmTL6kI3hmvkfcjPZM7Zc5irb+U=; b=WCgxRhPfgd7dwtzpk9EA8f+N2M2IIjJI3JI6sxW7W+2/kYr/BMD+e05Clm6o4uP42m Uh8N6RXzGSbenqqx9S5KvJ0F5WFmq4lvc1CetFlfvN1i3ynHfPbwehzjbR6xeijCjiZ5 IwK3BnodAC04EUH3UOGlFZ31rCmiij4JnC+02W42Tvyycr5edUabVmSPg8CKdRDO6+Ve YGVYGMRgv/QvKASkVuj6UssQz7MFVIfglHySsA/fG9eKDpSJO3z5Df8FrjDZ7rPnqf5a BrxcVksj82lGjdUoVzP7hK6kqhiV/pCWTFaqW0qfBY0z570LQhWB2CwEm7aRUrnDxQAi F92w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LWu3LD/6qgRdIa3DnmTL6kI3hmvkfcjPZM7Zc5irb+U=; b=C4EIH45uFqxiv32IRIXX5WHf2JdKbbv1NAaQjAP8qJOjj3oZ+7dMTo0UQrAyDkCOee IwLUUn/A9vuAJs1rHSryeFpkN/evroujKrQ9U2uO0dH+HifvHS6/7Rbv6G+RExAkt/uR 4hxSB4d+RTJifidtY8yTPh+yd6K9oy0mAdAZY9as2g/dVDw4rhCX4qen0DdrAJ5QZL9M lPxXCf7KYf5E3DE9ND2onyXVbludKrbZtCQcX3KBwVAz/LQ7PQDJm57EMzzBHrfhDSvd ChHYIsybxs6pHTXy7DxAfkAMkXozV3HRQ6ZrQFTmJCduPyVN5cbu4tSmNMTQNzi/1Hjm PIww== X-Gm-Message-State: AJaThX59TAR7LVs018R86Z4f/qLoXJ9wjD2csyUNf2/Pdl2zrSYIk3vb +iZEK5pfI7LJxXQh1UQ7XhU= X-Google-Smtp-Source: AGs4zMZc9Gn8ec5J5uVcdlrDA9/ZQQyVc3uOioJPDp30b5kJIsSHvwWB6oH3SJZkbnrUziaWUiDf4g== X-Received: by 10.101.70.11 with SMTP id v11mr14545199pgq.306.1512409739791; Mon, 04 Dec 2017 09:48:59 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:59 -0800 (PST) From: Arvind Yadav <arvind.yadav.cs@gmail.com> To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Subject: [PATCH 6/7 v2] net: ethernet: smsc: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:22 +0530 Message-Id: <1512409703-20881-7-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171204_094920_580162_6250103D X-CRM114-Status: UNSURE ( 9.19 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 0515744..5e3c7af 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -2088,6 +2088,11 @@ static int smc911x_drv_probe(struct platform_device *pdev) ndev->dma = (unsigned char)-1; ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto release_both; + } + lp = netdev_priv(ndev); lp->netdev = ndev; #ifdef SMC_DYNAMIC_BUS_CONFIG
platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2: commit message was not correct. drivers/net/ethernet/smsc/smc911x.c | 5 +++++ 1 file changed, 5 insertions(+)