Message ID | 1512409703-20881-8-git-send-email-arvind.yadav.cs@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8C2316035E for <patchwork-linux-arm@patchwork.kernel.org>; Mon, 4 Dec 2017 17:51:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A412290F5 for <patchwork-linux-arm@patchwork.kernel.org>; Mon, 4 Dec 2017 17:51:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6C87A29275; Mon, 4 Dec 2017 17:51:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E8E702926C for <patchwork-linux-arm@patchwork.kernel.org>; Mon, 4 Dec 2017 17:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=e5xl7m9CtLQXuXCTEVccroVpR0lYJeuhIYHJ0TH0NwQ=; b=Oryfnhi8BKlyzvyuJBjQ61eHgi gV6QRkLjssMg6aEiqJLjc+RUAySoQvXPA5ZXOe14MtZVHzFzSzR9eCjg/uH3kaIasJXmIi/QZKaYL 7FRfXs0VVXP/1XeFB3Lc/kv/cYAVAVLTJgjqGz2PGjX2afszguRoiHohP47rB+ctJrg4cqCdc/j9R CZe+50H7sxQ0Y5cAPC/VUHWZoyUd0Gh4CV87Ydnanx19+JTVzhsrWb6l7nogCLVy0Ul/1bsa0APXF 18/eQYr4GU/TsY54BqzSkTmL+7MJCy0ju8G6sLe9coDjwST0+Im+LrsAyCoghLVjZwX5asBw7hBvw j9ciBmwA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eLutQ-0004Bx-VO; Mon, 04 Dec 2017 17:51:00 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eLurn-0000v2-Bi for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2017 17:49:25 +0000 Received: by mail-pf0-x243.google.com with SMTP id d23so9058902pfe.9 for <linux-arm-kernel@lists.infradead.org>; Mon, 04 Dec 2017 09:49:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8rqQr8sXhlG0r+Vj07MdtxMVsMkG4hAOsts65oR12C4=; b=EMNoFKMG3WxChuquar0MmhTNFWu46+DVDFMiadVUIOWyoPA7RCNWSB/HKEDoa8hSDW pWarcjjYNdvBqCdqxe585lbzFNuhX0GyF/C4n5wEBwBvd/BgG6s9PiruTzXOJRmitGIa dZyN46VqOZXNBMe5cReqoO4DGwQckLQd+7BUBhJaPfZBt+R+zo3HA48rH/80VWb3Poh4 5OXZu1n/i0sVxiZVA+XaiG+wa2C3Hxl8aAc+CcRLCjRq5oc5VtyBJqHacxYW82YgIamJ PQm/exkT72ILnyeu8CLboZYkjnVfpQ6/Qhl5qL9U3C06jjsJUh9SZe5h1jcBOHWr3ckO Z5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8rqQr8sXhlG0r+Vj07MdtxMVsMkG4hAOsts65oR12C4=; b=AdLtVHKk3omLSZT3h50cvbTwG+Yq4N/2XgS1EJ0LDTsLFb9w2w6L4e+R9j/WGHJhD0 bbmGUTa5TfwFBqShGrAGsPZtHyhgijJ+szLmJUBpBGPFjY4NZtvGH7sXYbZ06je1VBK0 sp4Nvs7Zm7PdlAq+y2EkqF8sBANeQwkAeERW9GIs5HvwJ7XXVrwE+RCsxGsDttRg8EXV lovPj+k5ocpFHybN6kz6jbqN5z1gWe/Bc9TSyFhINjEqtLLIGvzEY12/iqj6G28L4qz2 9qhu1oJZWwGjlJVxDkZoQh07AkRkvxye7nIgAfcx6Msog7XkSBLtMBy4qQhzEYUhTpzG fkmA== X-Gm-Message-State: AJaThX44jw5tbZHUz4Nud9gJFQPyW4PKPLEgTliQ7X1mpmP2raequT57 JP9BNwoT+4yRbHuJmtXbtGw= X-Google-Smtp-Source: AGs4zMZiiiXmWsIZWwjeYh1Eedo+YhWsaub3K2CwEpG3A9i6CyA27QTLAypFOQ4CMiJfzB8HQwUi9w== X-Received: by 10.98.150.221 with SMTP id s90mr19957679pfk.151.1512409742857; Mon, 04 Dec 2017 09:49:02 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.49.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:49:02 -0800 (PST) From: Arvind Yadav <arvind.yadav.cs@gmail.com> To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Subject: [PATCH 7/7 v2] net: fjes: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:23 +0530 Message-Id: <1512409703-20881-8-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171204_094919_913943_07D92733 X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 750954b..af7204b 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1268,6 +1268,11 @@ static int fjes_probe(struct platform_device *plat_dev) hw->hw_res.start = res->start; hw->hw_res.size = resource_size(res); hw->hw_res.irq = platform_get_irq(plat_dev, 0); + if (hw->hw_res.irq <= 0) { + err = hw->hw_res.irq ? hw->hw_res.irq : -ENODEV; + goto err_free_netdev; + } + err = fjes_hw_init(&adapter->hw); if (err) goto err_free_netdev;
platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2: commit message was not correct. drivers/net/fjes/fjes_main.c | 5 +++++ 1 file changed, 5 insertions(+)