From patchwork Mon Jan 1 19:34:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10139377 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B723B60362 for ; Mon, 1 Jan 2018 19:42:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1B5928676 for ; Mon, 1 Jan 2018 19:42:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F26028649; Mon, 1 Jan 2018 19:42:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3CC1028649 for ; Mon, 1 Jan 2018 19:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=UiUi5gkHVHZYqmL4H/TqcterZ6jcXOqoiRNaj2sRQDE=; b=hEO09ybFoX1oLeXZLm5MEHKCHr xTWd+6rB2JjVl3RD4c3oIGBk2vHb98tiYP99G46cC69rwKU9UyW2zWdIteVP71glta4/bSwVa6QPU fWdF2O271FcZ2LMJTZU6kL0OqcZANvvQCkTMMgGkTKA9pPeh5RGUBUg86epkKtCHqdAiFL9LMn7kz 0cf7nbk7ms/ZlJERxrpMMjt0RZBVfs4h4jmxJbmnnPBnaY3JTpCY0RwKQZMUU2WHmZOxIor9L8Ban EZxM0tWrMd+MzbnqMesKqOLc8LvbkXHcD1VZbu2JTWBtxc7vJ/6c91zoNiTzb6wFM04eSfau9biOw Jkk50WeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eW5yI-0002mN-W0; Mon, 01 Jan 2018 19:42:07 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eW5rv-0007r9-Qm for linux-arm-kernel@lists.infradead.org; Mon, 01 Jan 2018 19:35:44 +0000 Received: by mail-wm0-x244.google.com with SMTP id b76so58234797wmg.1 for ; Mon, 01 Jan 2018 11:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dR18/oejCALiWSgbOvjO7r98++P30n5JOrS/EjAfWjE=; b=rCpzHttZ7mtDvqTOl7XxQaYFTFjlS+CTrj92yyOf7OfQDIjb5fjzwjiAwaHZiCZdHN neUktjO1oqCSRE3ZUEM2xmDUNL3Pw1xd2BrZgDWO++2aNzVp5PvDg7UMRuRehmIfhTqq roJLEnhx9K8ALsOKkoCrsmu0l7/mfFxZm16CUw0VHYPs6OFH2vKcztrUbHzHfSYX6Paw KGgU9lzDqtSfB8WiWxDkiAofBQ0zFetWc5P5coZwDqBHYJxF1P/DPwZ8/ZHtJ0JjwM00 4mQfcHz6vBSZQTEfs07CUfGtUCnA20Bv/OgdhEYzJvpargjIr5rnxZgM/2+I5U20hS0z iTiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dR18/oejCALiWSgbOvjO7r98++P30n5JOrS/EjAfWjE=; b=JX3RFHUdVNkjxOByZk2kqBLaJKfSLsgnffQDsRSIJ74TJ9h9b7Fo9Qgpw5fblnvlBH fMT2heqN5e1OAEhVQ2asD/X9d129/d4JMyp6YEP6HyCHgLRC9VPjAkE6Uc7g6DIuU7yV qR5otvoi+fjcQRb8XhPSCKzf/pf4hkcgCV5kCwV3iFT4oueh9SjMpGYy7FjOljOqFbba fqz1lO97Cskiz16aSNvYLojiQpkHj4ic/wlFk1LUL/7dyn5Fp1Glwgo5jBwA8q0QPrc0 LjGFNN5ZIh46bwUiAuvCyWEfOAyrnzatWdGh/bh/WerSrpvIKW+IB6kxemLPF9C7rYy0 Jkfg== X-Gm-Message-State: AKGB3mLIEz3pguT5eNV4Jqc3yEE38S65Vu7knZyXJqLmYptK7vScvNja E8E5udsPSIkMaAV8KNRQbua4WQ== X-Google-Smtp-Source: ACJfBouPPhXWAXp8pB7Lp/x/8BlNY5U1JEspBUkgmpMBA/6XZLt7bLrnVfToyDinwNGbt0pTfBD9zg== X-Received: by 10.80.204.197 with SMTP id b5mr58908752edj.249.1514835320147; Mon, 01 Jan 2018 11:35:20 -0800 (PST) Received: from localhost.localdomain (D4CCACC7.cm-2.dynamic.ziggo.nl. [212.204.172.199]) by smtp.gmail.com with ESMTPSA id r8sm29086992edm.22.2018.01.01.11.35.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Jan 2018 11:35:19 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH v2 33/34] clk: lpc32xx: change round_rate() return logic Date: Mon, 1 Jan 2018 19:34:59 +0000 Message-Id: <1514835300-381-19-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514835300-381-1-git-send-email-pure.logic@nexus-software.ie> References: <1514835300-381-1-git-send-email-pure.logic@nexus-software.ie> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180101_113532_470301_B0EF9057 X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bryan O'Donoghue , Sylvain Lemieux , Gabriel Fernandez , linux-arm-kernel@lists.infradead.org, Vladimir Zapolskiy MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Michael Turquette Cc: Stephen Boyd Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Gabriel Fernandez Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/nxp/clk-lpc32xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c index 76c17f4..0e0d258 100644 --- a/drivers/clk/nxp/clk-lpc32xx.c +++ b/drivers/clk/nxp/clk-lpc32xx.c @@ -664,17 +664,17 @@ static unsigned long clk_usb_pll_round_rate(struct clk_hw *hw, * USB divider, USB PLL N and M parameters. */ if (rate != 48000000) - return -EINVAL; + return 0; /* USB divider clock */ usb_div_hw = clk_hw_get_parent_by_index(hw, 0); if (!usb_div_hw) - return -EINVAL; + return 0; /* Main oscillator clock */ osc_hw = clk_hw_get_parent_by_index(usb_div_hw, 0); if (!osc_hw) - return -EINVAL; + return 0; o = clk_hw_get_rate(osc_hw); /* must be in range 1..20 MHz */ /* Check if valid USB divider and USB PLL parameters exists */ @@ -697,7 +697,7 @@ static unsigned long clk_usb_pll_round_rate(struct clk_hw *hw, } } - return -EINVAL; + return 0; } #define LPC32XX_DEFINE_PLL_OPS(_name, _rc, _sr, _rr) \