From patchwork Mon Jan 1 19:43:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 10139485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 857E060596 for ; Mon, 1 Jan 2018 19:48:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76B7F286FD for ; Mon, 1 Jan 2018 19:48:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6BC34286FB; Mon, 1 Jan 2018 19:48:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CE788286FF for ; Mon, 1 Jan 2018 19:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=18fic4fLwoiI8KUithvImLsqNTEXozaDJ9VXuLtnJ9Y=; b=fkIU+gUoa1N6Ap6AzKvT9InoM7 kauS78S1YSTF2CqvgqDegluqj0k+7iANnwOG4rVI7toUeaSOWzT2sBdt9OF/BM8B5On4y7AfBWG39 8K/8q76X4w6sASe80W44uCrWlP7V3TSTqh00sjZJN0vhwXDCyNG0sINkpf/FWHNtNDOlc8ZRsxUxz HHwG/4dqCtdED89vuiXVi1fpZczFXvapryUh+Ysxtcw4/NOFV/0gSx4QIRMfo4zRYulaRFAqETulg NJ7pd4RfnytK6nHCdrmqI1yLWZvUs0Nf1/SFGmJxiK/4XRtM9foh98txaeDmJwNBAiyTa/tw1SlLL LY2SCuEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eW63t-0006l4-Rc; Mon, 01 Jan 2018 19:47:53 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eW5zv-0003CO-Gc for linux-arm-kernel@lists.infradead.org; Mon, 01 Jan 2018 19:44:55 +0000 Received: by mail-wm0-x242.google.com with SMTP id t8so58263166wmc.3 for ; Mon, 01 Jan 2018 11:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xpd3kXaXigbGNzIi+9t6Q4zL9FYAiazRrWc0MtR9zps=; b=l+RJCMciY6Rx/Pe+jlsjXJqNnxjNpge9CfPhxXLvE/IYog4M+ix3IEOiqqMuwmwSED 4Ik6gsp52846eCIgSWf1o/UHMUYO2Wg1k38C4BGIF0KNUsjH+0DHAmQWgGzZTrtroIx+ 2HFHjzis+5132YUD/paRHR+Rnep0TggqM0psrI6ZuFSBJGymPlulhJQqsdbfW9qevtWI ihFdmtXhDVCn/DkLyl87dptrWbTi0rzLbSmDp35EEzbtfLu2qzr8cDjNZkpODLdItY4X /AR5wZbjik8aX2SyIDolHrriuGKaBT146qEQQ3QM7nIWjeEyLckwY+te6LwMQdySZvVB xvaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xpd3kXaXigbGNzIi+9t6Q4zL9FYAiazRrWc0MtR9zps=; b=VJXW4IVcHmgQZSI9Z3DYChgeprd9WuJMsOHziIgg10KDPb9rMJB00ozBLasLdN3T9L HNc7QnQlLb38Bv6R/lkHyf7Wk7+fNiS9pmrb6IabDw+Cez0/r5MKp0omhJHzkYxf9Ivo x7sJK0XIwVcnM/RMHC6Qsl5pmHpihNAEnGL92icJmQLAhg3pvG/TKakK6gimGMcE6FWj WXfM3XcycnO1V/uJmBxsg2N/E2SEAZqzHik/g3JePeqMjBOydhmKBv7JrFgEdalwLCZf CBfCmqxWKF6jBMTIq5AXZQbc4Q2wsmFErjNp3oA0uadUGdsc6sO/k/pzcHl9JrK8J1nC 0Qyg== X-Gm-Message-State: AKGB3mJPxR9vhxhcrtRzW+pxGGACXARBxU2Qn1Iv2seVImWUboAr9JGW NqWHVQIUn0+0mnLP6pEvrFgCGQ== X-Google-Smtp-Source: ACJfBovq3WGfrjPN1ITDqnGnRuTcCBq9ucW+YMIucc5C/RSTkj3gMI/JZislmRptiH6SRmMKR+zWWA== X-Received: by 10.80.137.9 with SMTP id e9mr59086629ede.199.1514835817110; Mon, 01 Jan 2018 11:43:37 -0800 (PST) Received: from localhost.localdomain (D4CCACC7.cm-2.dynamic.ziggo.nl. [212.204.172.199]) by smtp.gmail.com with ESMTPSA id w2sm39361075edb.4.2018.01.01.11.43.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 01 Jan 2018 11:43:36 -0800 (PST) From: Bryan O'Donoghue To: mturquette@baylibre.com, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH v3 21/34] clk: lpc32xx: change clk_hclk_pll_round_rate() return logic Date: Mon, 1 Jan 2018 19:43:00 +0000 Message-Id: <1514835793-1104-22-git-send-email-pure.logic@nexus-software.ie> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> References: <1514835793-1104-1-git-send-email-pure.logic@nexus-software.ie> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180101_114348_714410_A4FA4B2F X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bryan O'Donoghue , Sylvain Lemieux , Gabriel Fernandez , linux-arm-kernel@lists.infradead.org, Vladimir Zapolskiy MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch updates the round_rate() logic here to return zero instead of a negative number on error. In conjunction with higher-level changes associated with acting on the return value of clk_ops->round_rate() it is then possible to have clk_ops->round_rate() return values from 1 Hz to ULONG_MAX Hz instead of the current limitation of 1 Hz to LONG_MAX Hz. Signed-off-by: Bryan O'Donoghue Cc: Michael Turquette Cc: Stephen Boyd Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Gabriel Fernandez Cc: linux-clk@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/nxp/clk-lpc32xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c index 81ab57d..76c17f4 100644 --- a/drivers/clk/nxp/clk-lpc32xx.c +++ b/drivers/clk/nxp/clk-lpc32xx.c @@ -595,7 +595,7 @@ static unsigned long clk_hclk_pll_round_rate(struct clk_hw *hw, pr_debug("%s: %lu/%lu\n", clk_hw_get_name(hw), *parent_rate, rate); if (rate > 266500000) - return -EINVAL; + return 0; /* Have to check all 20 possibilities to find the minimal M */ for (p_i = 4; p_i >= 0; p_i--) { @@ -622,7 +622,7 @@ static unsigned long clk_hclk_pll_round_rate(struct clk_hw *hw, if (d == (u64)rate << 6) { pr_err("%s: %lu: no valid PLL parameters are found\n", clk_hw_get_name(hw), rate); - return -EINVAL; + return 0; } clk->m_div = m;