From patchwork Wed Jan 17 11:40:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 10169161 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 58181603B5 for ; Wed, 17 Jan 2018 11:36:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 43C932856E for ; Wed, 17 Jan 2018 11:36:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 37C9328574; Wed, 17 Jan 2018 11:36:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B2D4F2856E for ; Wed, 17 Jan 2018 11:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=P4eUVUFcd7LxhSWrkElfcQP6Hggt67DvX5oRdFydwSk=; b=UrtE2BbV8Ojj4E Mh+Hg4TLrCEI/BNDWVj5jcke2716+Fz6AQ5TP9r2s/tAiSrFldGjTih0jS4o5GPnOfIDeUq0Idh7I QLoIJYntx1jLt+8hQI92PDftezhL91DvoeU8/snutOVvsTdSCLt38qe92VcBX5O6MGfLIRAv8odxa SjTKJYBJ1UTKOecgvsuLznLkpDjdyS1YfXqjcJuiCJKJn41myq7wsGz8sjKEWXxk5EA/luoWzLuiS qS8T77905bPwe2PtViA2S6ESX/dCztrGWowjhfkqX989aYmoaBfLGFTS+9rLhCMHw5LB6oSiFp0Am KO8cLv80MZ18KGwu6VxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ebm13-0001PG-4k; Wed, 17 Jan 2018 11:36:25 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eblz2-000615-Bs for linux-arm-kernel@lists.infradead.org; Wed, 17 Jan 2018 11:34:22 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 30E4F7BD5775D; Wed, 17 Jan 2018 19:33:57 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.361.1; Wed, 17 Jan 2018 19:33:48 +0800 From: Wei Yongjun To: Herbert Xu , Maxime Coquelin , Alexandre Torgue , Fabien DESSENNE , Corentin LABBE Subject: [PATCH -next] crypto: stm32 - remove redundant dev_err call in stm32_cryp_probe() Date: Wed, 17 Jan 2018 11:40:24 +0000 Message-ID: <1516189224-11877-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, Wei Yongjun , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Reviewed-by: Fabien Dessenne --- drivers/crypto/stm32/stm32-cryp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c index cf1dddb..4a06a7a 100644 --- a/drivers/crypto/stm32/stm32-cryp.c +++ b/drivers/crypto/stm32/stm32-cryp.c @@ -1052,10 +1052,8 @@ static int stm32_cryp_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); cryp->regs = devm_ioremap_resource(dev, res); - if (IS_ERR(cryp->regs)) { - dev_err(dev, "Cannot map CRYP IO\n"); + if (IS_ERR(cryp->regs)) return PTR_ERR(cryp->regs); - } irq = platform_get_irq(pdev, 0); if (irq < 0) {