| Message ID | 1517333637-17331-3-git-send-email-yogeshnarayan.gaur@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 30, 2018 at 11:33 AM, Yogesh Gaur <yogeshnarayan.gaur@nxp.com> wrote: > Added usage example by adding support for spi-rx-bus-width > and spi-tx-bus-width binding. Why not just add to existing example? Is there something unclear about adding these properties to warrant an example? We don't need every possible option enumerated. Rob
> -----Original Message----- > From: devicetree-owner@vger.kernel.org [mailto:devicetree- > owner@vger.kernel.org] On Behalf Of Rob Herring > Sent: Wednesday, January 31, 2018 12:24 AM > To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> > Cc: linux-mtd@lists.infradead.org; open list:OPEN FIRMWARE AND FLATTENED > DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Mark Rutland > <mark.rutland@arm.com>; Shawn Guo <shawnguo@kernel.org>; moderated > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm- > kernel@lists.infradead.org>; Boris BREZILLON <boris.brezillon@free- > electrons.com>; Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>; Brian Norris > <computersforpeace@gmail.com>; Han Xu <han.xu@nxp.com>; Fabio Estevam > <festevam@gmail.com>; Prabhakar Kushwaha > <prabhakar.kushwaha@nxp.com>; Suresh Gupta <suresh.gupta@nxp.com> > Subject: Re: [PATCH 2/2] dt-bindings: fsl-quadspi: spi-rx/tx-bus-width usage > example > > On Tue, Jan 30, 2018 at 11:33 AM, Yogesh Gaur > <yogeshnarayan.gaur@nxp.com> wrote: > > Added usage example by adding support for spi-rx-bus-width and > > spi-tx-bus-width binding. > > Why not just add to existing example? Is there something unclear about adding > these properties to warrant an example? We don't need every possible option > enumerated. > Ok, would drop this patch and send another patch having usage of properties spi-rx-bus-width and spi-tx-bus-width in existing example under binding file 'spi-bus.txt'. Thanks > Rob > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in the body > of a message to majordomo@vger.kernel.org More majordomo info at > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.ke > rnel.org%2Fmajordomo- > info.html&data=02%7C01%7Cyogeshnarayan.gaur%40nxp.com%7C72a7e99bdd > 6d4d3b645d08d56812d0b2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C > 0%7C636529352384519879&sdata=nux9xbgzSjz7bFAFXOFEzt%2BzEnUPVh5f6A > mkXK1Pwyk%3D&reserved=0
diff --git a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt index 63d4d626..811da0e 100644 --- a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt +++ b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt @@ -39,3 +39,33 @@ qspi0: quadspi@40044000 { .... }; }; + +qspi1: quadspi@20c0000 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0x0 0x20c0000 0x0 0x10000>, + <0x0 0x20000000 0x0 0x10000000>; + reg-names = "QuadSPI", "QuadSPI-memory"; + interrupts = <0 25 0x4>; /* Level high type */ + clocks = <&clockgen 4 3>, <&clockgen 4 3>; + clock-names = "qspi_en", "qspi"; + status = "okay"; + + qflash0: s25fs512s@0 { + #address-cells = <1>; + #size-cells = <1>; + spi-max-frequency = <20000000>; + reg = <0>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <4>; + }; + + qflash1: s25fs512s@1 { + #address-cells = <1>; + #size-cells = <1>; + spi-max-frequency = <20000000>; + reg = <1>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <4>; + }; +};
Added usage example by adding support for spi-rx-bus-width and spi-tx-bus-width binding. Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> --- .../devicetree/bindings/mtd/fsl-quadspi.txt | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+)