From patchwork Thu Feb 1 00:03:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shanker Donthineni X-Patchwork-Id: 10194945 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7C2EC60380 for ; Thu, 1 Feb 2018 00:04:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6624E2888B for ; Thu, 1 Feb 2018 00:04:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 590C428895; Thu, 1 Feb 2018 00:04:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D4AA52888B for ; Thu, 1 Feb 2018 00:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=+gU6uUpfOLcxdXulct5jI8cRYV6Zt5ILuj1tfm07jcA=; b=SXs +nGstzeVqRQXISaeBTfLDSV94hiPX13RpWUCcDbJcUpJvd/YUHaEoXX6aMNbHCPn9yrCHLS3bMFQP juDxNAkiuBt4tryRSELEfnD0YNSxUC+GjHKAEeQK6gvau0mgI54J2uGVG2JDbLOYVd5TPGS51jGEk saiYitUjIRob1II2M64xJGf4LXiI1Q9swyfpj/CznvmfcZXzJHTw8YJCD6lM+NGPmEsdS2EOv2atW IUkEFBIm3ejUWM2nuMrDi46DU33HmbWoOWBqFUPrvBO+yVnn9lRqxymklo8L1UFpzoJT15pyvEaVz aebybAWZGEeg0YTEKBL8lUel65kfOsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eh2MZ-0005du-M0; Thu, 01 Feb 2018 00:04:23 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eh2MV-0005c7-Ny for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2018 00:04:21 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D2EDB6085F; Thu, 1 Feb 2018 00:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1517443447; bh=68fbvf8sjsg9Yl716qKsmTJGGhA6FZo24QS3vD7BM4U=; h=From:To:Cc:Subject:Date:From; b=PcV2r2EQ7+mcib/Pu1TULBPPtm6CkuuFCaT2jcA+xdB42Bk4RCj9EFXZ75Qh09XwA n1TlvoVb2Kq4FsBD4CnrjnFeTFU5iQI7k7GnGUB6gGXTvdHEkONgO08v7jugtv05Q3 SX8Xpd2C3hYE6mHqsHOdvNajyZhO6eOdPpV/jYUg= Received: from shankerd-ubuntu.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: shankerd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E214C6079C; Thu, 1 Feb 2018 00:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1517443446; bh=68fbvf8sjsg9Yl716qKsmTJGGhA6FZo24QS3vD7BM4U=; h=From:To:Cc:Subject:Date:From; b=Hgo6ujVVgge6SZXvMPRJI6L3UaQCaNYifU0U2ndBygfkhIKHtlREGZ3C9m47pixBV iWeXDDZCBI+cD/MRPyVmHnDHCxXYsrw5zK12truGA8msawUbPSsnY0U5hmRepSRRk7 fPeVLbtGWqmKcS/DxuRGGbfMK2HkZeXXcXUaQWis= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E214C6079C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shankerd@codeaurora.org From: Shanker Donthineni To: Marc Zyngier , linux-kernel , linux-arm-kernel , kvmarm Subject: [PATCH] irqchip/gic-v3: Use wmb() instead of smb_wmb() in gic_raise_softirq() Date: Wed, 31 Jan 2018 18:03:42 -0600 Message-Id: <1517443422-30693-1-git-send-email-shankerd@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Speier , Vikram Sethi , Sean Campbell , Will Deacon , Thomas Gleixner , Shanker Donthineni MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP A DMB instruction can be used to ensure the relative order of only memory accesses before and after the barrier. Since writes to system registers are not memory operations, barrier DMB is not sufficient for observability of memory accesses that occur before ICC_SGI1R_EL1 writes. A DSB instruction ensures that no instructions that appear in program order after the DSB instruction, can execute until the DSB instruction has completed. Signed-off-by: Shanker Donthineni Acked-by: Will Deacon Tested-by: Adam Wallis --- drivers/irqchip/irq-gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index b56c3e2..980ae8e 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -688,7 +688,7 @@ static void gic_raise_softirq(const struct cpumask *mask, unsigned int irq) * Ensure that stores to Normal memory are visible to the * other CPUs before issuing the IPI. */ - smp_wmb(); + wmb(); for_each_cpu(cpu, mask) { u64 cluster_id = MPIDR_TO_SGI_CLUSTER_ID(cpu_logical_map(cpu));