| Message ID | 1518446590-16800-11-git-send-email-patrice.chotard@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 12, 2018 at 8:43 AM, <patrice.chotard@st.com> wrote: > From: Patrice Chotard <patrice.chotard@st.com> > > For all clock's element inside SoC, add a fake reg property, > this allows to fix the following warnings when compiling > dtb with W=1 option : > > arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg): > Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property > arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg): > Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property > arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg): > Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property > > arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg): > Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property > arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg): > Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property > arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg): > Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property > > arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg): > Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property > arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg): > Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property > arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg): > Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property > > Signed-off-by: Patrice Chotard <patrice.chotard@st.com> > --- > > v2: _ add a fake reg property to node without reg property. > > arch/arm/boot/dts/stih407-clock.dtsi | 9 ++++++--- > arch/arm/boot/dts/stih410-clock.dtsi | 9 ++++++--- > arch/arm/boot/dts/stih418-clock.dtsi | 9 ++++++--- > 3 files changed, 18 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi > index b882dcf3a649..1bba47e06ebe 100644 > --- a/arch/arm/boot/dts/stih407-clock.dtsi > +++ b/arch/arm/boot/dts/stih407-clock.dtsi > @@ -24,9 +24,10 @@ > /* > * ARM Peripheral clock for timers > */ > - arm_periph_clk: clk-m-a9-periphs { > + arm_periph_clk: clk-m-a9-periphs@0 { > #clock-cells = <0>; > compatible = "fixed-factor-clock"; > + reg = <0 0>; Don't do this. The correct fix is change the location of these nodes to be under whatever controls them. Rob
Hi Rob On 02/12/2018 04:22 PM, Rob Herring wrote: > On Mon, Feb 12, 2018 at 8:43 AM, <patrice.chotard@st.com> wrote: >> From: Patrice Chotard <patrice.chotard@st.com> >> >> For all clock's element inside SoC, add a fake reg property, >> this allows to fix the following warnings when compiling >> dtb with W=1 option : >> >> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property >> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property >> arch/arm/boot/dts/stih410-b2120.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property >> >> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property >> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property >> arch/arm/boot/dts/stih410-b2260.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property >> >> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-m-a9-periphs missing or empty reg/ranges property >> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-m-a9-ext2f-div2s missing or empty reg/ranges property >> arch/arm/boot/dts/stih418-b2199.dtb: Warning (simple_bus_reg): >> Node /clocks/clk-tmdsout-hdmi missing or empty reg/ranges property >> >> Signed-off-by: Patrice Chotard <patrice.chotard@st.com> >> --- >> >> v2: _ add a fake reg property to node without reg property. >> >> arch/arm/boot/dts/stih407-clock.dtsi | 9 ++++++--- >> arch/arm/boot/dts/stih410-clock.dtsi | 9 ++++++--- >> arch/arm/boot/dts/stih418-clock.dtsi | 9 ++++++--- >> 3 files changed, 18 insertions(+), 9 deletions(-) >> >> diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi >> index b882dcf3a649..1bba47e06ebe 100644 >> --- a/arch/arm/boot/dts/stih407-clock.dtsi >> +++ b/arch/arm/boot/dts/stih407-clock.dtsi >> @@ -24,9 +24,10 @@ >> /* >> * ARM Peripheral clock for timers >> */ >> - arm_periph_clk: clk-m-a9-periphs { >> + arm_periph_clk: clk-m-a9-periphs@0 { >> #clock-cells = <0>; >> compatible = "fixed-factor-clock"; >> + reg = <0 0>; > > Don't do this. The correct fix is change the location of these nodes > to be under whatever controls them. > Ok i will put this node as a child of clockgen-a9@92b0000 Thanks Patrice > Rob >
diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b/arch/arm/boot/dts/stih407-clock.dtsi index b882dcf3a649..1bba47e06ebe 100644 --- a/arch/arm/boot/dts/stih407-clock.dtsi +++ b/arch/arm/boot/dts/stih407-clock.dtsi @@ -24,9 +24,10 @@ /* * ARM Peripheral clock for timers */ - arm_periph_clk: clk-m-a9-periphs { + arm_periph_clk: clk-m-a9-periphs@0 { #clock-cells = <0>; compatible = "fixed-factor-clock"; + reg = <0 0>; clocks = <&clk_m_a9>; clock-div = <2>; @@ -67,9 +68,10 @@ /* * ARM Peripheral clock for timers */ - clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s { + clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s@0 { #clock-cells = <0>; compatible = "fixed-factor-clock"; + reg = <0 0>; clocks = <&clk_s_c0_flexgen 13>; @@ -254,9 +256,10 @@ "clk-s-d2-fs0-ch3"; }; - clk_tmdsout_hdmi: clk-tmdsout-hdmi { + clk_tmdsout_hdmi: clk-tmdsout-hdmi@0 { #clock-cells = <0>; compatible = "fixed-clock"; + reg = <0 0>; clock-frequency = <0>; }; diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b/arch/arm/boot/dts/stih410-clock.dtsi index 4df1b2187aa2..41fb1a910d49 100644 --- a/arch/arm/boot/dts/stih410-clock.dtsi +++ b/arch/arm/boot/dts/stih410-clock.dtsi @@ -27,9 +27,10 @@ /* * ARM Peripheral clock for timers */ - arm_periph_clk: clk-m-a9-periphs { + arm_periph_clk: clk-m-a9-periphs@0 { #clock-cells = <0>; compatible = "fixed-factor-clock"; + reg = <0 0>; clocks = <&clk_m_a9>; clock-div = <2>; clock-mult = <1>; @@ -69,9 +70,10 @@ /* * ARM Peripheral clock for timers */ - clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s { + clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s@0 { #clock-cells = <0>; compatible = "fixed-factor-clock"; + reg = <0 0>; clocks = <&clk_s_c0_flexgen 13>; @@ -266,9 +268,10 @@ "clk-s-d2-fs0-ch3"; }; - clk_tmdsout_hdmi: clk-tmdsout-hdmi { + clk_tmdsout_hdmi: clk-tmdsout-hdmi@0 { #clock-cells = <0>; compatible = "fixed-clock"; + reg = <0 0>; clock-frequency = <0>; }; diff --git a/arch/arm/boot/dts/stih418-clock.dtsi b/arch/arm/boot/dts/stih418-clock.dtsi index e68bf28bd038..50413eabe73a 100644 --- a/arch/arm/boot/dts/stih418-clock.dtsi +++ b/arch/arm/boot/dts/stih418-clock.dtsi @@ -27,9 +27,10 @@ /* * ARM Peripheral clock for timers */ - arm_periph_clk: clk-m-a9-periphs { + arm_periph_clk: clk-m-a9-periphs@0 { #clock-cells = <0>; compatible = "fixed-factor-clock"; + reg = <0 0>; clocks = <&clk_m_a9>; clock-div = <2>; clock-mult = <1>; @@ -69,9 +70,10 @@ /* * ARM Peripheral clock for timers */ - clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s { + clk_m_a9_ext2f_div2: clk-m-a9-ext2f-div2s@0 { #clock-cells = <0>; compatible = "fixed-factor-clock"; + reg = <0 0>; clocks = <&clk_s_c0_flexgen 13>; @@ -259,9 +261,10 @@ "clk-s-d2-fs0-ch3"; }; - clk_tmdsout_hdmi: clk-tmdsout-hdmi { + clk_tmdsout_hdmi: clk-tmdsout-hdmi@0 { #clock-cells = <0>; compatible = "fixed-clock"; + reg = <0 0>; clock-frequency = <0>; };