diff mbox

[v4,3/3] driver: clocksource: add gpt timer for imx6sll

Message ID 1520501697-22202-3-git-send-email-ping.bai@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jacky Bai March 8, 2018, 9:34 a.m. UTC 
Add gpt timer support for i.MX6SLL.

Signed-off-by: Bai Ping <ping.bai@nxp.com>
---
change v1->v2:
 - no
change v2->v3:
 - no
change v3->v4:
 - no
---
 drivers/clocksource/timer-imx-gpt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Shawn Guo March 9, 2018, 1:29 a.m. UTC | #1 
On Thu, Mar 08, 2018 at 05:34:57PM +0800, Bai Ping wrote:
> Add gpt timer support for i.MX6SLL.
> 
> Signed-off-by: Bai Ping <ping.bai@nxp.com>

The patch should be sent to clocksource maintainer.

> ---
> change v1->v2:
>  - no
> change v2->v3:
>  - no
> change v3->v4:
>  - no
> ---
>  drivers/clocksource/timer-imx-gpt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c
> index 6ec6d79..57b7eab 100644
> --- a/drivers/clocksource/timer-imx-gpt.c
> +++ b/drivers/clocksource/timer-imx-gpt.c
> @@ -557,3 +557,4 @@ static int __init imx6dl_timer_init_dt(struct device_node *np)
>  TIMER_OF_DECLARE(imx6dl_timer, "fsl,imx6dl-gpt", imx6dl_timer_init_dt);
>  TIMER_OF_DECLARE(imx6sl_timer, "fsl,imx6sl-gpt", imx6dl_timer_init_dt);
>  TIMER_OF_DECLARE(imx6sx_timer, "fsl,imx6sx-gpt", imx6dl_timer_init_dt);
> +TIMER_OF_DECLARE(imx6sll_timer, "fsl,imx6sll-gpt", imx6dl_timer_init_dt);

I'm wondering if we can save this change by letting the compatible of
imx6sll-gpt fall on "fsl,imx6dl-gpt" in DT.

Shawn
Jacky Bai March 9, 2018, 5:10 a.m. UTC | #2 
> Subject: Re: [PATCH v4 3/3] driver: clocksource: add gpt timer for imx6sll
> 
> On Thu, Mar 08, 2018 at 05:34:57PM +0800, Bai Ping wrote:
> > Add gpt timer support for i.MX6SLL.
> >
> > Signed-off-by: Bai Ping <ping.bai@nxp.com>
> 
> The patch should be sent to clocksource maintainer.
> 
> > ---
> > change v1->v2:
> >  - no
> > change v2->v3:
> >  - no
> > change v3->v4:
> >  - no
> > ---
> >  drivers/clocksource/timer-imx-gpt.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clocksource/timer-imx-gpt.c
> > b/drivers/clocksource/timer-imx-gpt.c
> > index 6ec6d79..57b7eab 100644
> > --- a/drivers/clocksource/timer-imx-gpt.c
> > +++ b/drivers/clocksource/timer-imx-gpt.c
> > @@ -557,3 +557,4 @@ static int __init imx6dl_timer_init_dt(struct
> > device_node *np)  TIMER_OF_DECLARE(imx6dl_timer, "fsl,imx6dl-gpt",
> > imx6dl_timer_init_dt);  TIMER_OF_DECLARE(imx6sl_timer,
> > "fsl,imx6sl-gpt", imx6dl_timer_init_dt);
> > TIMER_OF_DECLARE(imx6sx_timer, "fsl,imx6sx-gpt",
> > imx6dl_timer_init_dt);
> > +TIMER_OF_DECLARE(imx6sll_timer, "fsl,imx6sll-gpt",
> > +imx6dl_timer_init_dt);
> 
> I'm wondering if we can save this change by letting the compatible of imx6sll-gpt
> fall on "fsl,imx6dl-gpt" in DT.
> 

Sure, this patch can be dropped. I will update the dts compatible string accordingly.

Jacky

> Shawn
diff mbox

Patch

diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c
index 6ec6d79..57b7eab 100644
--- a/drivers/clocksource/timer-imx-gpt.c
+++ b/drivers/clocksource/timer-imx-gpt.c
@@ -557,3 +557,4 @@  static int __init imx6dl_timer_init_dt(struct device_node *np)
 TIMER_OF_DECLARE(imx6dl_timer, "fsl,imx6dl-gpt", imx6dl_timer_init_dt);
 TIMER_OF_DECLARE(imx6sl_timer, "fsl,imx6sl-gpt", imx6dl_timer_init_dt);
 TIMER_OF_DECLARE(imx6sx_timer, "fsl,imx6sx-gpt", imx6dl_timer_init_dt);
+TIMER_OF_DECLARE(imx6sll_timer, "fsl,imx6sll-gpt", imx6dl_timer_init_dt);