From patchwork Wed Mar 14 03:20:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10281419 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2F338602BD for ; Wed, 14 Mar 2018 03:24:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1EDE628689 for ; Wed, 14 Mar 2018 03:24:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 128E628691; Wed, 14 Mar 2018 03:24:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 84F9428689 for ; Wed, 14 Mar 2018 03:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AsP8kTKBsSuV0VtUbE3sKv5VIMV0mtzVXUTIBjYaqVY=; b=ljTDIeTerkO9CW u7k8qiMYGB1k5oM9bDAXbfjudSF3DXkz0v6evZpdNRfcoz7wm3q1nCTD/+aMRJ57jIJ5DVjxsb4TY wWA77TXcM5rmfYj5xynRevab2qrap7NN+idudqmbRkjoeFLd+dcArEegeV6xEA6m+Nt73gOb2Uj0c tfZwinxwsa2KnECVFp1eb677i5rKvImyus3DsunADiJ9m40x34rMe4bblFQr1zjXHl+n2lQEc7BPT ZYQ6g73thk47Gsoz3XCTJ+lBtRxiCNhwIsGdOuz5bIQOm4IsYyHUnOAWIlXl1tkj6Vd3U9ezMt+5g umz1re5PndQZtEAkWX7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1evx1e-000660-CU; Wed, 14 Mar 2018 03:24:26 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1evwy8-0003t1-4o for linux-arm-kernel@lists.infradead.org; Wed, 14 Mar 2018 03:20:54 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AADA06095F; Wed, 14 Mar 2018 03:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520997637; bh=wb9xtlCktc5g3rJH4kmsb3V4Ftg8s5ceqodGJJolQjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C2FM2NSj8sh+zKlqfcIzdm5ZQD2wgxtOCUpzldh49OMY/0KG73A8FjVyVlmnJByt7 c/2uPQfCcFDlM8ftiqryEghbugZlQZUI3T/j9E8yU964omceTMboS9dfQbfwIh2dO+ IZuI6ihm/QvfWFqST8GX1qh1IG49IfY2+N4YvFiY= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 27EE0607A2; Wed, 14 Mar 2018 03:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520997637; bh=wb9xtlCktc5g3rJH4kmsb3V4Ftg8s5ceqodGJJolQjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C2FM2NSj8sh+zKlqfcIzdm5ZQD2wgxtOCUpzldh49OMY/0KG73A8FjVyVlmnJByt7 c/2uPQfCcFDlM8ftiqryEghbugZlQZUI3T/j9E8yU964omceTMboS9dfQbfwIh2dO+ IZuI6ihm/QvfWFqST8GX1qh1IG49IfY2+N4YvFiY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 27EE0607A2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH 2/7] ixgbe: eliminate duplicate barriers on weakly-ordered archs Date: Tue, 13 Mar 2018 23:20:23 -0400 Message-Id: <1520997629-17361-2-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1520997629-17361-1-git-send-email-okaya@codeaurora.org> References: <1520997629-17361-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180313_202048_943648_3E1C68D7 X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 0da5aa2..35ca1d8 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -1692,7 +1692,7 @@ void ixgbe_alloc_rx_buffers(struct ixgbe_ring *rx_ring, u16 cleaned_count) * such as IA-64). */ wmb(); - writel(i, rx_ring->tail); + writel_relaxed(i, rx_ring->tail); } } @@ -2453,7 +2453,7 @@ static int ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector, * know there are new descriptors to fetch. */ wmb(); - writel(ring->next_to_use, ring->tail); + writel_relaxed(ring->next_to_use, ring->tail); xdp_do_flush_map(); } @@ -10014,7 +10014,7 @@ static void ixgbe_xdp_flush(struct net_device *dev) * are new descriptors to fetch. */ wmb(); - writel(ring->next_to_use, ring->tail); + writel_relaxed(ring->next_to_use, ring->tail); return; }