From patchwork Wed Mar 14 16:58:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 10283219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2B55D602C2 for ; Wed, 14 Mar 2018 18:14:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1B2D42858F for ; Wed, 14 Mar 2018 18:14:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0EF6A285A4; Wed, 14 Mar 2018 18:14:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 961452858F for ; Wed, 14 Mar 2018 18:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=lXvI8HAqblofAaf8fK/kFgKtqTfu55cFt9j1foBqNLo=; b=f2LMyIyzHjcQuyoXK7Lnqxlfht UqR5OgEbUR5raqUBDhRWdYKfNxdt0f7iGWcgn5mY+0Oo0oct9WaZqoKe6nt7UF3NIJwX5L+d1sYvz SpCpXKNR962QaK6Ntf7DgbonBg/VJZAuu64TdQ3zLRRK+UO82/5w9BRjGjX1ERFFlmb2y0I6kBV3M kRoUXDz3QqinHBeefqveONR1tL/uymo/g7/QC1t7V64AYJexUIP9Jf9omdskdUvKICNGU69qEf+Tf MsXTxckbbH/5KS2u5oFauC57mRFwVs/KLvmyeSc7cnMnjkh9TJibNPP/qbYtqFTmio/kAABFAB9O1 FhIJI1Yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewAvB-00025v-1I; Wed, 14 Mar 2018 18:14:41 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewAqf-00064J-7Z for linux-arm-kernel@bombadil.infradead.org; Wed, 14 Mar 2018 18:10:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hSa1vuv7p5LGnqIFGONCS9906USFez9Y+cts+oPVryk=; b=14CmY+B0G6+C6T5so6YlcVJB1 12g1ra9Xf2KjfbXfa/pylM3NJ62inh+qbpY3iTrW5QaULiZseL3JSJLMfP8i231yI2n2eSmS9ehLD ZU1wrHV9v7WZn3PB4b3I1rgw+2kvoQPMju0DT+WYbX39rnu9wu4bDSj5r3aunP5zWFxwl8KzUf6ld gBwaFvDIu75iEjyfq46r7DHHCqo20zCd3XoT2EjzVYw6fj8zqwPg/3NqMYVfvsmlcDIRCQS3sTHKa cdwO81uzr2tlm2DaOZ8ZKL5bsUq3PQwu6ryO1wussQG8YTJ8mVK6WJwW3P05MkDLFJnAxtdPaoJcH ENJDvm19Q==; Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ew9kH-0003Pz-8b for linux-arm-kernel@lists.infradead.org; Wed, 14 Mar 2018 16:59:21 +0000 Received: by mail-lf0-x243.google.com with SMTP id m69-v6so5850418lfe.8 for ; Wed, 14 Mar 2018 09:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hSa1vuv7p5LGnqIFGONCS9906USFez9Y+cts+oPVryk=; b=P0CiJn705qOhcjGca5bz8eUBHXn3meODQ6jYF+/kEeYFDblxGO3p/417IMjroSoStO JJNMnudAop4Rz7lqUhmcj+ns3kU8b8nRBtRLsEGUTyPNmczz62PTNi4i1rWSoyKi6Agt VHR9VZ4+E6R9jQaIq8lUNSEjv/lfsCc5V5YjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hSa1vuv7p5LGnqIFGONCS9906USFez9Y+cts+oPVryk=; b=cURlrdwcQ7m0WYNjDxT2bGmIC3NH3wei9BYwiONliVfZGWtfewojbYERr6wBAJWRzm 9z/tqIqfkOn4MkAvPzhOrbkOG/sEqjKhmsivbAY22+0R62EYxMLG1NNMzcdTKk7tumvx tdrdjAclouvfCfxegpvovVzf7jsGFdu8yoFBklxgS3WxE1YSsAWzFHGineP+qej99MEb w9rh1DpF8JFQ6+Xc3C5nY8wx8w4jozXhUdiapJ2oymr6QmGuHDYBPbKPVrEnXitGlE8h dxUcbLnlvrVDIck8+H8g0vWkwSOcyvYczCXsIU4hasqZxrdgD60N7JwrZu85zdUnTvd0 puWA== X-Gm-Message-State: AElRT7HPMxIq56YhSpx4ch++MTKucOwt1wJvPCRQHC/SUn6rbbSIbIlv pdhRJrF8sLmeu7WJZ2U7YCBJ4Q== X-Google-Smtp-Source: AG47ELuusa1xbv/nmnv+1O9CYgqmdmemWUivDZQt/P0urbSTvY6vZy+jc7jw+c9OW1ah26aI4+hJTA== X-Received: by 2002:a19:48c7:: with SMTP id v190-v6mr1361194lfa.26.1521046745790; Wed, 14 Mar 2018 09:59:05 -0700 (PDT) Received: from uffe-XPS-13-9360.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id t24-v6sm724849lfi.30.2018.03.14.09.59.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Mar 2018 09:59:04 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , Sudeep Holla , Lorenzo Pieralisi , linux-pm@vger.kernel.org Subject: [PATCH v6 02/25] PM / Domains: Deal with multiple states but no governor in genpd Date: Wed, 14 Mar 2018 17:58:12 +0100 Message-Id: <1521046715-30683-3-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521046715-30683-1-git-send-email-ulf.hansson@linaro.org> References: <1521046715-30683-1-git-send-email-ulf.hansson@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180314_125921_319139_E6C7F26A X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Vincent Guittot , Juri Lelli , Geert Uytterhoeven , Kevin Hilman , Stephen Boyd , linux-arm-msm@vger.kernel.org, Daniel Lezcano , linux-kernel@vger.kernel.org, Lina Iyer , Rob Herring , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lina Iyer MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP A caller of pm_genpd_init() that provides some states for the genpd via the ->states pointer in the struct generic_pm_domain, should also provide a governor. This because it's the job of the governor to pick a state that satisfies the constraints. Therefore, let's print a warning to inform the user about such bogus configuration and avoid to bail out, by instead picking the shallowest state before genpd invokes the ->power_off() callback. Cc: Lina Iyer Signed-off-by: Ulf Hansson --- drivers/base/power/domain.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index c2ef944..9aff79d 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -466,6 +466,10 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, return -EAGAIN; } + /* Default to shallowest state. */ + if (!genpd->gov) + genpd->state_idx = 0; + if (genpd->power_off) { int ret; @@ -1694,6 +1698,8 @@ int pm_genpd_init(struct generic_pm_domain *genpd, ret = genpd_set_default_power_state(genpd); if (ret) return ret; + } else if (!gov) { + pr_warn("%s : no governor for states\n", genpd->name); } mutex_lock(&gpd_list_lock);