From patchwork Fri Mar 16 01:04:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10285999 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C91160291 for ; Fri, 16 Mar 2018 01:08:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 102EC28CA3 for ; Fri, 16 Mar 2018 01:08:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 048E528CB4; Fri, 16 Mar 2018 01:08:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7776228CA3 for ; Fri, 16 Mar 2018 01:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PZ4MOK5Pbms9L2UMNRP2cEp59d/hivXkBgFt6nzFWMk=; b=mqe6iWSunLVz9C dF3hu3SiemqqKjGo1SgACzI7/UIdeLBUJ2vo3Ak5s7pC8V+81ouUStTbAUxNJ53nYlbSsJVbYhXT9 SAwGNwfSsgJMvmFrnZJ1iSH8OmF7OVl5XPvxDIVoMuyCva0ZFl/SqwJ8cDW8O/MsbXJu7Q+E5OhQO w13IG9S+RJYR4zvzF5dBPbCbiZVjDK9wuD9b0wa8x/GADZRP3W5ZgvF/lOmHAIFOjv5YDTBNCkHzf gqtWuI5N+cXOxBLb7PmrkRfckkwdQhPZZp8WtoBYy7PsNGr86fddnDKoed7vfrc576au2aVjyMgJv tEoJKniQCu1DfI9Nkwqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewdr5-0003Rx-VH; Fri, 16 Mar 2018 01:08:23 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewdo1-0000Yc-8w for linux-arm-kernel@lists.infradead.org; Fri, 16 Mar 2018 01:05:16 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0A2E160AFB; Fri, 16 Mar 2018 01:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521162306; bh=/Qda46YcE38zYczmpY8gxqR0G7VdLCDkTSGK0ZNKHoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oKz8IA0mSHwJxf0VF3/qRxIRuu/MPL+YMl/zX9ZYx5pQD7p3P+qhTjR9BsmvCAgzx 9x8Fw/f50g0mUqNJJzDAcn3Pn5NmSNiP/bM1hBshHbBNqALrvMr1gDclLkPBiX99ib Pctog3DcpUug7h8OTZHyDA7I3btETWV7pytrLM+8= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id AC3E060C64; Fri, 16 Mar 2018 01:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521162305; bh=/Qda46YcE38zYczmpY8gxqR0G7VdLCDkTSGK0ZNKHoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QlavN5UcjkO7wy39HFNsr1FNeGv2uMoVSPghQBFybcUaliTHP8mTFUnCdyctF/Vco 7U3bwH303jVWhN240cT6padk7sfVKwCaSKS8zo52LulLbFDekxzauE56k6B1B0+bEn aWbFBZGzDC++JXFoOlWgDich0R5XzciYSXkX9mjM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AC3E060C64 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@ocdeaurora.org, sulrich@ocdeaurora.org Subject: [PATCH v2 2/6] ixgbe: eliminate duplicate barriers on weakly-ordered archs Date: Thu, 15 Mar 2018 21:04:52 -0400 Message-Id: <1521162296-19729-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521162296-19729-1-git-send-email-okaya@codeaurora.org> References: <1521162296-19729-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180315_180513_499991_D49E019F X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 0da5aa2..58ed70f 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -1692,7 +1692,7 @@ void ixgbe_alloc_rx_buffers(struct ixgbe_ring *rx_ring, u16 cleaned_count) * such as IA-64). */ wmb(); - writel(i, rx_ring->tail); + writel_relaxed(i, rx_ring->tail); } } @@ -2453,7 +2453,7 @@ static int ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector, * know there are new descriptors to fetch. */ wmb(); - writel(ring->next_to_use, ring->tail); + writel_relaxed(ring->next_to_use, ring->tail); xdp_do_flush_map(); } @@ -8078,7 +8078,7 @@ static int ixgbe_tx_map(struct ixgbe_ring *tx_ring, ixgbe_maybe_stop_tx(tx_ring, DESC_NEEDED); if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) { - writel(i, tx_ring->tail); + writel_relaxed(i, tx_ring->tail); /* we need this if more than one processor can write to our tail * at a time, it synchronizes IO on IA64/Altix systems @@ -10014,7 +10014,7 @@ static void ixgbe_xdp_flush(struct net_device *dev) * are new descriptors to fetch. */ wmb(); - writel(ring->next_to_use, ring->tail); + writel_relaxed(ring->next_to_use, ring->tail); return; }