Message ID | 1521162296-19729-7-git-send-email-okaya@codeaurora.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B45F0602BD for <patchwork-linux-arm@patchwork.kernel.org>; Fri, 16 Mar 2018 01:07:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A84FB28BD3 for <patchwork-linux-arm@patchwork.kernel.org>; Fri, 16 Mar 2018 01:07:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D43828CA9; Fri, 16 Mar 2018 01:07:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5DE8A28BD3 for <patchwork-linux-arm@patchwork.kernel.org>; Fri, 16 Mar 2018 01:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hTzdH4fSv1UkWvLUqw06Ck/H3SepSOI7Ik7AB5lw8WU=; b=nmY9YyxhA5nxFq vIJV9N/xpCwrxGYclWwJpdjU7evXlsXWm7VHkEjPkzWYAviJzoLOrnoFQA1awDXFPVUXEPuo0K+4I 1WkKdWCcRWguMRq6Xr9UymB5WZPQlpTh5gVMZNXTYTdnTz3DGLwUbsP8qiRab/CkL3pivXgVV5GhL 7ih70dlVmi0+vGoDURzkNdaXT3ljIXKGZxpc03i9YF6q752J4f+GZnkfcIjRUhD4b1tTLw2wVfeHp SDeEzuSwzMVlNwj6YyA/ZqhJl1xo2DVMch/uiZfUR4JHR27jL8tVqnbwpmBh7I4Wv95ETaGW0wnnv fPwrV/bjk1Z4ja3e7Gfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewdpe-0002ZL-0F; Fri, 16 Mar 2018 01:06:54 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewdoD-0001aQ-D7 for linux-arm-kernel@lists.infradead.org; Fri, 16 Mar 2018 01:05:30 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1FA9360F71; Fri, 16 Mar 2018 01:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521162314; bh=AXMyFjzzSbzbm5hdWdurg8ose+pYZbmYLpHtSBkV7FU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l40hzY2C7fm8mkrN9aQbFkYKkHIBBmBpdZbp/JTV17EbEB0oZFWNc7oZHCJ0OO+CB pkzrGKOuoJCniMQN4l7T0QfZa4YkM8S18/F2S4LfbcbYb/3vn3vLx4cXOqH+dqd9CX KNEv5j4G7gtcP8E45cv+LMmFJtaKDbRsU0BN39yk= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E7D45602FC; Fri, 16 Mar 2018 01:05:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521162312; bh=AXMyFjzzSbzbm5hdWdurg8ose+pYZbmYLpHtSBkV7FU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JbU+MNq4Qi69ufPpqHOTNbaXBgdmbC4doERqC2uZfk9pZPMAGlLicmfkdQTvizNAa /WAYbdLQTJ6MYLefCYv+q/GpG6ZE+KbYTT61j291GG4vl4fHM2AfffXUtngBClvNKA lwnMFoOCVVOMTK6lGskYb8MpZOtGbdrOdbwfEY04= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E7D45602FC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya <okaya@codeaurora.org> To: netdev@vger.kernel.org, timur@ocdeaurora.org, sulrich@ocdeaurora.org Subject: [PATCH v2 6/6] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Date: Thu, 15 Mar 2018 21:04:56 -0400 Message-Id: <1521162296-19729-7-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521162296-19729-1-git-send-email-okaya@codeaurora.org> References: <1521162296-19729-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180315_180526_274535_CC3547D9 X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>, intel-wired-lan@lists.osuosl.org, Jeff Kirsher <jeffrey.t.kirsher@intel.com>, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c index b65f691..9e2e0fd 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c @@ -3644,7 +3644,7 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring, tx_ring->next_to_use = i; /* notify HW of packet */ - writel(value, tx_ring->tail); + writel_relaxed(value, tx_ring->tail); return; dma_error:
Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)