From patchwork Fri Mar 16 16:16:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10290461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA60560386 for ; Fri, 16 Mar 2018 23:01:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DDC09290EC for ; Fri, 16 Mar 2018 23:01:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D178C290F0; Fri, 16 Mar 2018 23:01:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 718D5290EC for ; Fri, 16 Mar 2018 23:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MobEn9TgyWKPjDDceqhoI/E8hOqliC99nDwdOdkwu5Y=; b=D5EQBC0/XHQ+Fo RXqqhhNIY40D3KNng75H7y726EWnEXfz67gkvmhwDQFxAjEG1WhjT0G1vgtbKGMOw65YdJftPK+05 EnGEv6ZtUZ13LBwF+YxZUwp2lx4tSBleRzVP7pdBBE2EcX16EKhryukcg5EjopSd7ESAaLE1g3hZE R5rtG/HV6YEPvPSPjfobO+yUBBSbK9ScV16uJJg4IVoTyXGS47t8INsOF5g8XcJ01NgLrA/RscyBT 06MSEONOmN4WmybbbE37Elohpja+ZYMXWDbumRR5FNsPsNjwJlXbe45qr02D6pv4Q0QpyGg4eG8sh j3hu9lRa9mrKx+Rh2OBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewyLt-0004Se-1Y; Fri, 16 Mar 2018 23:01:33 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ewtdL-0000JU-WB for linux-arm-kernel@bombadil.infradead.org; Fri, 16 Mar 2018 17:59:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AOndy06wepqSzpcNqs9wQUB8Swv+rbb1e1r0+AHhUaU=; b=iZgpK2dJk9y43y3oE/UPSLJLt1 Lv0hOwlRnmaulxj9Z6oLbuo/4gcAixbJNjg8g0iel2B6G0lJxOhE5DoomWnlzjjNLS7tHBI2sD3NL tnIlhh1hAiDjiLnSPUu//tInfHtmCfzlxco80El7HJ/nb5rqsJy+K32JxxQty51d7Fngx4+ud90dO jdBkFf2PuE+tfBlhTSVAWo7EtGFB7eO0eOz3k7X5veTaNeKLcTa1u62QSdmUSCFP2dJNmhp2as/IW LI2n87Adt0V4On1g64BMNG9Y5vI0N6O/YLZ3cizjl1OoqiS5YnzpIeDNlytn5i1Ku6qY2FSxJR4r8 fENjgW7A==; Received: from smtp.codeaurora.org ([198.145.29.96]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ews2Y-0004T2-4u for linux-arm-kernel@lists.infradead.org; Fri, 16 Mar 2018 16:17:10 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E365D60F78; Fri, 16 Mar 2018 16:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217023; bh=ovabtb8qaN3ElLW1NzzQID5Ib0B9xgPC1q0dgJnIkGI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lUQMbRSH0IEVkHehKMhuuiCg22Ii0/+5mGnIrKq88mCmNe/hNsffn+nUG9pf62lqm VtTPONfwxnSwdQnVKPlKAvfVhuO0ACAj3Aa9j9Hb3SiD+PL0jBrdx1hPCysLJ2jjU0 6n07rGQGzz2RxFbY9GoivfED3XA70Q4Shpk8joYk= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2B41760C64; Fri, 16 Mar 2018 16:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521217022; bh=ovabtb8qaN3ElLW1NzzQID5Ib0B9xgPC1q0dgJnIkGI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gM1e4++h5wZaOvGv1j8H6IMdzKvRm619xExWPaT98tTL26lTm46gs1ZCnxEzS3O8L h352trylr8shBLXZefymwQOD698EvZKsDl5sB3nywb1ATLVpC6lc2xeK7DLwPwL8TR 6ugF2z2HEmou+TqrP2rYFa6wR9WIF2mjU0fQ8Gbg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2B41760C64 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: netdev@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v3 09/18] fm10k: Eliminate duplicate barriers on weakly-ordered archs Date: Fri, 16 Mar 2018 12:16:22 -0400 Message-Id: <1521216991-28706-10-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> References: <1521216991-28706-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180316_121710_293238_ED0AF381 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , intel-wired-lan@lists.osuosl.org, Jeff Kirsher , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed(). Signed-off-by: Sinan Kaya --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c index 8e12aae..8d04e26 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c @@ -179,7 +179,7 @@ void fm10k_alloc_rx_buffers(struct fm10k_ring *rx_ring, u16 cleaned_count) wmb(); /* notify hardware of new descriptors */ - writel(i, rx_ring->tail); + writel_relaxed(i, rx_ring->tail); } }